#metabrainz

/

      • aeontech joined the channel
      • JonnyJD_ has quit
      • reosarevok joined the channel
      • ruaok joined the channel
      • kepstin joined the channel
      • samphippen has quit
      • luks_ joined the channel
      • luks has quit
      • chrisg has quit
      • chrisg joined the channel
      • chrisg has quit
      • chrisg joined the channel
      • Bookzombie has quit
      • johtso has quit
      • drsaunders has quit
      • yeeeargh joined the channel
      • yeeeargh has quit
      • yeeeargh joined the channel
      • regagain joined the channel
      • regagain has quit
      • aeontech has quit
      • aeontech joined the channel
      • Mineo
        I'm not sure if this is a stupid question or not, but how do I actually find add release edits for my subscribed artists from, say, the last week now that they're auto-edits?
      • aeontech has quit
      • zas has quit
      • diana_olhovik_ joined the channel
      • reosarevok
        Heh. That's a reasonable question. I completely forgot about the fact that /subscribed shows only open edits
      • We probably should change that, actually
      • (given that so many edits are moving towards being autoedits)
      • And just give it a toggle "show open/show all"
      • Freso
      • Please+choose+a+condition
      • It would be nice if someday those URLs weren't so bloody long...
      • reosarevok
        That doesn't make it subscribed though does it?
      • Freso
      • It does.
      • Did you even look at it?
      • reosarevok
        I just get type + created
      • Freso
        Try the is.gd link? Maybe something got cut off.
      • diana_olhovik_ has quit
      • reosarevok
        I did - still nothing :/
      • Mineo
        I get the same as reosarevok
      • reosarevok
        But it does have an "artist is in my subscriptions" option, anyway
      • Freso
        Anyway, you can "Artist" to be "is in my subscriptions"
      • reosarevok
        So you can use that :)
      • Also "label" I guess?
      • Mineo
        but I was more interested in the "7 days ago" part
      • reosarevok
        Yup
      • Freso
        Which is what "&conditions.1.field=artist&conditions.1.operator=subscribed" should do, but apparently that doesn't transfer for you.
      • reosarevok
        Weird
      • Mineo
        it's probably because the user_id is Fresos and we're not allowed to see his subscriptions or something
      • Freso
        Ah.
      • Does
      • work, I wonder?
      • Nope.
      • Freso makes a ticket
      • ruaok: Oh! I never noticed your ping yesterday! Pong!
      • Mineo
        http://tickets.musicbrainz.org/browse/MBS-8647 for the edits for subscribed entities thing
      • diana_olhovik joined the channel
      • zas joined the channel
      • zas has quit
      • zas joined the channel
      • JonnyJD_ joined the channel
      • diana_olhovik has quit
      • ok, next question: according to https://docs.google.com/document/d/1UY5aRFLJE3k... "add release" is edit type 74, but isn't it actually 31 (https://beta.musicbrainz.org/doc/Edit_Types/31)?
      • reosarevok
        bitmap?
      • (it does seem so, heh)
      • Freso
        reosarevok, Gentlecat, bitmap, Leftmost, sampsyo, …: Are you subscribed to the GCI mentor mailing list? Also, I'm thinking of maybe setting up some way so all the mentors can discuss stuff (or at least so I can reach all of you easily ;)). Any preferred ways? Subforum, mailing list, separate IRC channel, ... ?
      • Gentlecat: Do you think there's someone who could (and would) help you with mentoring CB programming tasks?
      • If at all possible, I would like to have two mentors per task.
      • Leftmost
        Speaking for myself, IRC is going to be the most consistent way to get a hold of me. That, or GTalk.
      • Freso
        Leftmost: I was thinking to make a Google Hangout maybe.
      • Since we obviously all have Google accounts anyway.
      • Mineo
        does a hangout mean I have to keep a tab open at all times?
      • Freso
        Mineo: Nope. Just that you will check it, say, at least once a day?
      • E.g., when you visit Google+ or GMail or whatever.
      • (There are also desktop clients, as well as obviously mobile apps.)
      • Mineo
        well, I don't visit either of them daily, but I can certainly check it regularly if we decide we want to use hangouts
      • Freso
        Gentlecat: Looking over the tasks you entered now; they look good so far! One thing to keep in mind for future tasks: please also add "technology" used to the tasks ("python", "flask", "sql", ...).
      • I like hangouts since I will get notifications on my phone. :p
      • Mineo
        also, edit type 72 is not "add release label" (as is stated in the notes), it's "edit recording"
      • diana_olhovik_ joined the channel
      • Freso
        Gentlecat: They've all been published now. Feel free to look them over again yourself and review/adapt/append tags. :)
      • ariscop has quit
      • drsaunders joined the channel
      • regagain joined the channel
      • Leftmost
        Thinking is hard.
      • samphippen joined the channel
      • UmkaDK has quit
      • drsaunders
        fyi search server is down
      • MajorLurker has quit
      • reosarevok
        drsaunders: it's been absolute crap lately :( I think zas is on the case though
      • drsaunders
        cool i didn't know if it was known or not
      • ruaok_
        yep.
      • i fixed them earlier, he is on it this time.
      • :q
      • feh
      • zas
        yes
      • usual shit
      • d4rkie joined the channel
      • i reduced the request rate, stopped roobarb search server, but dora search server still not recovering
      • Nyanko-sensei has quit
      • d4rkie has quit
      • reosarevok
        Huh
      • Is there no check to see that a series rel isn't duplicated?
      • Nyanko-sensei joined the channel
      • LordSputnik joined the channel
      • LordSputnik
        Freso: After reading the GCI mentor list email, I've started thinking about new BB tasks. Thinking of adding some unit testing ones and maybe a couple of userscripts
      • I've also added 1 BB task to the GCI site, but I'm going to wait until they expand the character limit to 1500 to do the others
      • ruaok_
        looking much better, zas. well done.
      • Leftmost
        LordSputnik, pinged you here with some stuff a couple days ago. (Not sure how much you backread.) Let me know if it's more convenient for me to PM it to you.
      • diana_olhovik_ has quit
      • zas
        ok search servers finally up
      • the issue is more and more a serious one
      • ruaok: i added 2 scripts in /root/bin on dora and roobarb to reject connections during startup, i'll improve that, and do a warm up script
      • that said it would be great if someone could have a look at search server code ...
      • also i'm think of using daemontools envdir together ratelimiter to be able to change the global rate without editing the script itself
      • i had a look at the code, the thing is quite simple in fact, but all the configuration is hardcoded ...
      • samphippen has quit
      • LordSputnik
        Leftmost: will re-share the doc for rika now
      • Also, I'm not sure a trigger will work - for example, can we differentiate well enough between create/update/merge that way?
      • I'd like to keep going with the individual methods, then if we can manage it later we can add triggers
      • samphippen joined the channel
      • Leftmost
        LordSputnik, we can do .on('creating', ...) or .on('updating', ...), but does it matter? If we are saving entity data, don't we want to create a revision?
      • I'm also working on a good way of dealing with polymorphism in the models. It looks like that's an area where bookshelf struggles: there's no way to say EntityRevision is derived from Revision and has attributes set from the Revision table.
      • LordSputnik
        Leftmost: no, bookshelf isn't good for polymorphism, but I haven't looked into how it deals with polymorphism definedin postgres, that might work
      • Leftmost
        Polymorphism defined in postgres? I assume this is something I should read up on.
      • LordSputnik
      • Leftmost
        It might also be worth filing an issue. I'll see what they say in the bookshelf channel and then poke through their github issues.
      • Sweet, thanks.
      • LordSputnik
        I've currently done it with this.morphTo, but I reread the docs recently and I think that might be for another purpose (defining a relationship to multiple tables)
      • Leftmost
        Yeah, I think so.
      • I'll take a look at inheritance, see what I can dig up.
      • LordSputnik
        bitmap: Possible edit table performance improvments from http://stackoverflow.com/questions/3074535/when...
      • (first answer)
      • Leftmost
        That's partitioning, which unfortunately doesn't really help in our case.
      • Partitioning only really provides a performance boost when postgres can guarantee constraint exclusion, i.e. that the query doesn't need to hit a particular table. That's rarely ever the case with edit tables.
      • LordSputnik
        Leftmost: not even if you only by default display edits within a certain date range?
      • The talk at the summit was about archiving a portion of edits and displaying older edits when the user asked for them, this partitioning seems like it would work for that
      • Leftmost
        It could, but that would be a pretty significant overhaul to UX, I think. I'm currently investigating some other methods which would provide improved performance without requiring broader changes.
      • LordSputnik
        Leftmost: I'm thinking, now that we aren't using sqlalchemy, it would probably be better to drop all of our inheritance in the database
      • Node ORMs aren't advanced enough to do it yet, and it also seems like it's not benefiting us hugely
      • adamcik has quit
      • Leftmost
        I was thinking about that a little. How do we deal with things like edit notes, or the different entity types?
      • adamcik joined the channel
      • Freso
        LordSputnik: Ah. You're able to enter tasks too?
      • LordSputnik
        Freso: yeah, I think all mentors can, and it auto-assigns to the person who entered it