do the templates (.tt) have access to the constants defined in lib/MusicBrainz/Server/Constants.pm?
(and if so, via what syntax)
also, in new edits, relationships will have at most 1 instrument or vocal attribute right? so "foo performs bass, drums, glockenspiel" would be 3 relationships when entered now, and only historic data would still have a single AR containing all 3?
bitmap
no, you have to add whatever variables you want into $c->stash to access them in the templates
Zastai
and I take it hardcoding the vocals/instrument root id would be frowned upon
bitmap
second question sounds correct
Zastai
am looking at MBS-8961; have a working prototype that groups non-instrument/vocal attrs first, followed by the others
but that checks for "is a vocal/instrument" by looking at attr.type.root.id, and I'm not sure how immutable those values are
bitmap
I'd say it's fine to define a variable in the template holding the gid
and compare against attr.type.root.gid
Zastai
is it also just 1 gid for all instruments? or is id 1 value plus a gid per instrument?
bitmap
every instrument has an id and gid
actually...
Freso
Zastai: Do you want a slot during the reviews during the meeting? (In 11 minutes.)
Zastai
nah, it's not important enough for that
LordSputnik joined the channel
Freso
Sure it is.
bitmap
the instrument gid should be the same as the link_attribute_type gid, I think
LordSputnik is now known as Guest94438
Zastai
ok then freso
will just emit the gid in the page to see if it varies
if it doesn't i'll check that instead of id
(i only got the idea for looking at the id because there's an INSTRUMENT_ROOT_ID constant that gets used for a similar purpose)
bitmap
yeah, the gids are constant for sure
root gid should be 0abd7f04-5e28-425b-956f-94789d9bcbe2 for instruments
d92884b7-ee0c-46d5-96f3-918196ba8c5b for vocals
Zastai
right. and will those be more or less constant than the id value? (if the same, a test for 14 is simpler than one for 0abd7f04-5e28-425b-956f-94789d9bcbe2)
Slurpee has quit
bitmap
well, the gid is intended to be constant, the id isn't
Freso
Guest94438: You may want to remember to check in with NickServ. ;)
bitmap
the id is effectively constant but can theoretically change in a schema change or something...
Zastai
fair enough, will check on the gid then
Freso
<BANG>
Hello all :)
Let's get right to it.
kartikgupta0909 joined the channel
We have Freso, zas, reosarevok, bitmap, Gentlecat, ruaok, LordSputnik, alastairp, Zastai, rahulr, QuoraUK, armalcolite, hellska, kartikgupta0909 up for reviews and 1 other agenda item. Let me know if you want on/off.
Freso: go!
Spent a good chunk of time looking into the circumstances about the non-renewal of chrisskye's contract, reading through e-mails, chat logs, etc.
Managed to actually be part of the BookBrainz meeting for the first time in a while.
Tried to upgrade the Discourse install, but it failed. Prodded zas, but not sure if I ever got a reply. I'll try again in a bit and re-prod.
Brought another open source project to the /supporters page, after Leo_Verto mentioned them in #musicbrainz (nusic, Android app: https://github.com/schnatterer/nusic )
Otherwise I've mostly been around and about, keeping up with forums and IRC to the best of my ability. Finally got the RPi2 back online yesterday, so keeping up with IRC should be much easier now. :)
(And I might actually be getting my 100/100 fiber connection this week too. We'll see.)
Freso: thanks!
zas: go!
I'm currently fighting with personal / family issues, i didn't do much
this week but overall monitoring and general maintenance
I hope to solve/push back those issues and come back during this week to
real work.
Thanks zas!
reosarevok: go!
reosarevok
I did support and editing, and decided I should stop slacking, so while I haven't decided on the hard style issue yet, at least I'm opening a couple smaller, hopefully simpler discussions to make *some* stuff happen
They'll be open for a week, then I'll decide what to do with them. No letting them sit there this time :p
Freso
Sure... ;)
reosarevok
This week I plan to finally take a decision on the boxset issue, or if I can't decide as such, then going for a second round of discussion with a more specific goal in mind
came up with a plan to move all the private chef-cookbooks/server-configs stuff into a new repo and make the docker setup use that
mostly spent time testing that in vagrant
ruaok wants to compare vagrant/docker notes with bitmap later
did gsoc code review and testing
fin
Gentlecat
I spent some time trying to figure out what was causing issues with memcached in dockerizied CB
couldn't, so I just ended up porting cache wrapper in python-brainzutils to redis
that seems to be working now
jcazevedo joined the channel
also upgraded sentry, and was trying to fix static file stuff in CB deployment with docker
done some code review
fin
ruaok
As you may have noticed last week I decided to not renew chrisskye’s contract, with immediate effect.
m8ram joined the channel
Over the past 3 months communication started to break down and in the last week, I felt unnecessarily attacked, causing me lots more stress on top of the of stress I already had.
I felt viciously attacked. I felt blackmailed.
After taking a time-out walk to calm down from being lividly angry, I decided that I didn’t need the stress and didn’t need someone who made me feel like this on my team.
I feel bad how I all of this went down, but this situation spiraled out of control with amazing speed and ferocity that I’ve never witnessed before.
I was caught off guard several times and it is hard to be patient when you feel like you’re being attacked.
This is all I am going to say about this topic.
I’ve told Freso my side of the story and if Freso cares to say any more about this, that is up to him.
aside from that I worked with armalcolite to get more PRs reviewed and merged and we're now on track. I'm quite happy with the progress on LB.
I've also started working on musicbrainz-vm which is a docker/vagrant MB in a VM setup.
the idea is that you install VB, Vagrant and then clone the repo.
and then do install.sh
and of course wait.
it would work if it didn't run out of disk space. alas.
I'll continue on this next week.
but this week, I'm headed off to Nowhere for a much needed break of dust, hippies, crazy parties and weird art.
I'm off grid 100% from Wednesday morning until Sunday late.
and boy, do I need it!
fin!
diana_olhovyk_ has quit
alastairp
this week mostly merging and working with SoC projects
chrisskye
I will post a link to my contract; has a Mediation clause, and Notice requirement (both breached). And, a copy of the draft of my email to the board, which seems to have triggered everything. And, any/all IRC chat logs, for any member of the community who might be interested in reviewing them. Transparency. Respect. Honesty.
alastairp
coming up this week is some new changes to be able to do search in the dataset edit
editor. fin
Zastai
have been looking at MBS-8961 today (avoid text like "additional, drums, guest and percussion" in artist relationship overview); have a working prototype (http://imgur.com/w3ySWH1) that groups non-instrument/vocal attributes first (so "additional and guest: drums and percussion")
will probably create a PR today
so far, the small UI things I've looked at have been fairly easy; will continue to pick up jira tickets that seem doable
Hi. I added a few achievements this week for the time an edition is released, that is pretty fun
Changed no of revisions to number of creations for the majority in order to make them a bit more meaningful
Freso
chrisskye: Keep in mind that your IRC chat logs may contain personally sensitive information that you have not been allowed to divulge before you share them.
QuoraUK
and am currently working on a nicer way of selecting the achievements you want to show off on your profile :D
fin.
armalcolite
Hi!
Fixed the jenkins build for listenbrainz and fixed some existing tests.
Updated api_compat branch based on ruaok's feedback.
Addressed a ticket assigned to me, hopefully it did not need any work. :D
Update the description for api_compat and now it is ready for 1st official review!
Now that test-suite is ready, i can get tests for API-Compatible commited.
fin.
hellska
Hi
reosarevok
Zastai: that colon there feels kinda weird FWIW
Zastai
i know, it's the one thing I'm tweaking
hellska
fixed some problems in the PR 189
Zastai
currently I leave it out if the first list has 1 item
hellska
received code review and comments on jira tickets
chrisskye
Freso: I can’t dispute feelings, but the insinuation of “blackmail"...is very close to defamatory.
hellska
and that’s all, I was quite busy with the thesis work and the presentation is next week!
fin
Freso
chrisskye: No one has said you blackmailed anyone.
chrisskye
ruaok, just said that is how he felt.
Freso
Exactly.
chrisskye
insinuation
Freso
kartikgupta0909: Ping?
kartikgupta0909
Tested different formats on the lowlevel data for acousticbrainz. Will be making the report this week. Also got the pending PR merged.
This week will be working on the server side API that is required for the offline dataset training tool.
fin :)
Freso
And that concludes the reviews!
chirlu: Discogs http/https URL normalization!
Maybe...
He added it only a few hours before the meeting.
Anyone got anything else?
If not, we'll move this topic to next week.
armalcolite
wow! reviews were pretty fast today. 1.57 min/person. :D
Freso
armalcolite: :)
Alright. Thanks for your time everyone!
</BANG>
hellska
armacolite: summer time ;)
armalcolite: :P
armalcolite
:D
Zastai
reosarevok: how about http://imgur.com/eBTXOXt - when both lists exist I space-separate the first and use comma_list for the second. otherwise, i use comma_list for the list that exists
so "guest, additional and solo" and "trumpet and bass" but "guest solo trumpet, glockenspiel and viola"
jesus2099 joined the channel
reosarevok
Sounds good to me
CallerNo6
chrisskye, fwiw, I look forward to hearing what you have to say. (also fwiw, I didn't read "blackmailed" as anything but a description of an emotional state)