#metabrainz

*sigh*. Thanks for fixing MEB-74 Gentlecat.

MEB-74: Token generation is not working https://tickets.metabrainz.org/browse/MEB-74

[listenbrainz-server] paramsingh opened pull request #111: [LB-101] Add album to response sent by tracks.scrobble in api_compat. (master...lb-101-record-albums) https://git.io/vMiei

I opened LB-115 for the api_sig bug I came across.

LB-115: tracks.scrobble does not work when api_sig is passed in request data https://tickets.metabrainz.org/browse/LB-115

This one is an easy fix, but I think it points us to maybe using these signatures to validate the data sent in the request.

yvanz: would you like to keep the remaining sidebar tickets as potential tasks for GCI next year ? I wouldn't mind submitting PRs for them.

Maybe we should check the data for errors during transmission for each request in api_compat where the signature is required by last.fm?

mayhem: ok sounds like a plan! shall I do the finishing?

please do. just add a quick intro sentence that you're taking over and go for it.

bueno

CallerNo6: ping

iliekcomputers: ignoring api_sig in the calls was done intentionally.

We do not know the client secret, so there is no way to verify api_sig

armalcolite: oh right, makes sense

refer to the last section, http://www.last.fm/api/webauth

Yea, I saw it, but I missed the secret at the end :D

armalcolite: the scrobbling didn't work when I pushed api_sig with the request

api_sig adds an extra "empty" track to the lookup dict

from what I see, that leads to the exception being thrown in messybrainz lookup for the empty track

that should not happen. I could not find any intance of api_sig in the source code so it should not make a difference

it should behave as if the field does not exist, but there might be a typo or something

that's what adds the extra track

armalcolite: As far as I can see, it's a one line fix. I'll send a PR tomorrow fixing it.

iliekcomputers: feel free to fix it. LB is still in its early stages and there is a lot of scope for improvement.

armalcolite: yeah, I'll do it tomorrow.

armalcolite: is it okay if I reopen LB-115 because the bug is still there?

LB-115: tracks.scrobble does not work when api_sig is passed in request data https://tickets.metabrainz.org/browse/LB-115

iliekcomputers: i guess it should remain open untill we are not sure if that bug is resolved. Since you say it is there, may be reopen it.

armalcolite: okay cool thanks

zas what should I do about the rest of my PRs?

Mineo: testNoScoreException started failing for all entities after I switched to latest commit on mbsssss

was that changed in https://github.com/metabrainz/mbsssss/pull/4?

the test: https://github.com/gentlecat/mb-solrquerywriter...

looking at the pull request, I'd say yes - all SearchHandler's seem to have received a default fl containing just "score"

samj1912: are you currently working on PICARD-915?

PICARD-915: In plugins list, some plugins don't show description https://tickets.metabrainz.org/browse/PICARD-915

Yup, working on all plugin related stuff together

:)

Saw :) thanks

Gentlecat: do you want me to update the tests?

sure, I wouldn't mind

samj1912: all plugins show descriptions for me.

but i reinstalled picard from scratch

anshuman73: Please, go ahead, we will never lack tasks for GCI.

mayhem: Gf is also vegetarian(/vegan), fwiw.

gcilou: Go as crazy as you feel like. :)

Freso: awesome. I'll add some more later ;)

But the main ones are in now

well, which one? vegan or vegetarian? kinda makes a difference.

srsly. what is your favorite cheese? any cheese you won't eat?

I'll eat mostly anything

favorite is any type of blue

nice. you'll help me go cheese shopping for the summit then?

there are 8 cheese shops (more or less) with in walking crawling distance of my house.

definitely if I can make it

gcilou: "finagle"? Was that intentional? I like it.

Freso: yes, intentional :)

Freso: is your GF vegan?

mayhem: She is vegetarian, but prefers to eat vegan.

If we go to the place Quesito it doesn't sound like it'll be an issue.

problem with that place is that it is close for only one person.

Ah.

and 4 people have to trek "halfway" across town.

whereas the amazing italian place is nice and central.

If it's a place with vegan options, amazing. If not but it's vegetarian, that'll work just fine too.

and conveniently near my house. :-p

oh la la which italian place?

I really dislike eating vegan, so I think we'll have to compromise on vegetarian. and I know the italian has decent veggie dishes -- chirlu had no issues finding food there.

Cuina Mandrossa? hang on.

Si, mandrossa is super goodz!

Le Cucine Mandarosso

k, you happy to saunter over then?

easy for you with the L1.

SothoTalKer: Why are you trying to install python discid for Py2.6 anyway? Latest Picard (what will soon be 1.4) does not support Python <2.7, and 2.7 is also about 10 years old by now. There's really no reason for sticking to 2.6...

3.6

mayhem: Just because one person eats vegan doesn't mean everyone has to.

Oh.

but i might downgrade to 3.5 again. nothing really supports 3.6 right now

SothoTalKer: If there are issues with Py3.6 you should definitely file issues/tickets/bug upstream.

I'm fine with sauntering that way!

the biggest issue is, nothing supports 3.6 yet :D

My system is on Py3.6 and I haven't encountered any issues.

me windows 4eva :D

please do!

i use ptvs and they won't even bother to release a version that supports py3.6 for visual studio 2015

Quesito: minor nitpick on the verbiage for stereotheque... we use the format "Company X uses MusicBrainz. ... "

the consistency police will come and hunt you down for this grave omission if you don't fix it.

me personally I am cool with how it is. :) :)

i might install a virtual machine with py2.7 for testing

LOL mayhem!

well, I'm just to make everyone aware, especially the vegans, that many air quality samples in spain have been found to contain ham-vapour.

SothoTalKer: You could just install a Linux VM.

hence the mention of the ham-police. those guys are mean.

Freso: go away, devil =D

:<

mayhem: the air here contains more than just ham-vapor!

lots of two-stroke scooter exhaust?

or are you talking about the yet-not-scientifically-confirmed foi-gras vapours that waft in from france?

Freso: IF i ever do that it has to be beginner-friendly ;)

If you can deal with the mess that is developing in Windows, you don't need something beginner-friendly :D

but someone has to do it. :x

tweeted!

companies love java :D

mayhem: definitely the foie-gras fumes!!!!

I really like the independence flag that is a few blocks away. I can see when the wind blows from france. time to go outside and inhale deep!

tweet looks good.

feel free to mix it up with different language.

we really don't want it to feel like we're a bunch of bots.