#metabrainz

yes, pointing it directly to uwsgi is an option

ah, great. I'll do that then.

next question... for containers that run services that have exposed tcp ports we have

--env SERVICE_6379_CHECK_TCP="true" \

but I've got two services that will run which do no expose ports.

how does it work to check that those services are healthy?

I'm not sure if you actually need to expose them

correct. but I want to ensure we can monitor them appropriately.

or rather publish ports

you can expose them in the image

--restart unless-stopped

should take care of restarting the containers if they stop

6379 is an "internal" port

I understand.

I am using that line as an example for context so you can understand what I am talking about.

my service has no port to expose.

the SERVICE_X_CHECK lines are for TCP exposing services.

how does the service check work for non TCP services?

[acousticbrainz-server] nupurbaghel opened pull request #226: Corrected: Viewing the recording information of a dataset or a snapshot requires being logged in (roman-project...master) https://git.io/vy4ul

[acousticbrainz-server] nupurbaghel closed pull request #226: Corrected: Viewing the recording information of a dataset or a snapshot requires being logged in (roman-project...master) https://git.io/vy4ul

[acousticbrainz-server] nupurbaghel opened pull request #227: Corrected: Viewing the recording information of a dataset or a snapshot requires being logged in (master...master) https://git.io/vy4gZ

Gentlecat: just wondering out loud. Why are challenges on AB open to users who are not logged in?

(I'm just looking at the just submitted PR)

it seems like instead of opening up the recording meta endpoint to everyone, we could just as easily restrict challenges to only logged in users

I'm trying to think about reasons why this wouldn't be a good idea... perhaps we want to disseminate this information widely, to people who don't need a user account

alastairp: I think it is a good policy to make things as open as possible, unless you have a good reason to make them closed.

OK. thanks for the counter argument

so, now we have an open endpoint, which given a mbid, returns the artist and title

do we think this could be abused? or am I inventing problems?

antlarr: ping

Everything can be abused by someone creative enough. :)

yeah

we could do a referrer check, but do we care?

alastairp: yes. if someone needs just that info and they dislike the MB rate limiting, then they will use AB, if it is faster.

samj1912: pong (but I have to go soon)

ah nothing, I was just refactoring the info dialog code

alastairp: not currently we don't

samj1912: great

and we've had a good run being super open with out APIs. being a little more protective seems wise now.

will you allow to set pairs of (orig, new) images ? :)

it is very poorly written :\

yes, I was planning on doing that

perfect! :D

just wanted your input so that we are moving in the same direction

I have removed the existing get_*_widget type methods and replaced them with classes

ruaok: can you clarify what you mean?

on a call. hang on.

sounds like we want to have challenge pages open -> 👍 fine with this

OK can do

but if we have a metadata endpoint, we should be careful about it -> also agree

-> heading out, back around meeting time

antlarr: I will try to finish it today, but I have an early morning flight to catch tomorrow and travel all day , so I will most likely finish it by day after

zas: Picard feat. freeze as of today, release next week?

samj1912: that's ok. I don't think I'll have time today to fix the issues from your review of #642 neither

Freso: no :P, me and antlarr are working on a last few updates

Freso: is it possible to add a single sentence that needs translation after today?

antlarr: Ask zas. :)

hmm, probably 2 or 3 sentences

zas: ^

:)

we can have a release on 14.3.17? 1 month after 1.4.0 :P

Freso: in.. 2 hours, right?

CatQuest: meeting time? yes

CatQuest: 1:48, but yes. :)

thnaks sam, als ii agree with your release date :D

zas: I'm working on https://github.com/metabrainz/picard/pull/642 and also would like to have https://github.com/antlarr/picard/compare/album... into 1.4.1 if possible

zas: can we set the feat. freeze on 8.3.17 11:59 pm UTC? :P antlarr will you be able to finish up by then?

I think so

to be honest, I don't like this "are you going to be ready 5 minutes before our feature freeze target?". it basically leaves no time for reviews or anything

Mineo: antlarr already has the PR made with changes requested :), if we are not able to get it in the timeframe for 1.4.1 we can just skip them in this release

1.4.1's main aim is to fix the drag n drop osx bug of 1.4, I just wanted 1.4.1 to be released so that we can switch the master to 2.0 and any further dev on 1.4.x can be carried out in their respective branches

do you really think we have enough manpower to maintain 1.4.x and work on 2.0?

well that was the plan :P

as for maintaining 1.4.x, we don't necessarily need to work on it, but hobbyists can back-port/fix future bugs on it if they want

Mineo: FWIW, “the plan” probably refers to https://chatlogs.metabrainz.org/brainzbot/metab...

alastairp: > can you clarify what you mean?

basically I'm saying that we need API keys for mb.org

which then also affects overall planning for APIs for our newer projects. but exactly how, I'm unsure as of yet.

yvanz_: thanks

yvanz_ Mineo: "the plan" is basically what has been talked about since January, regarding finishing up 1.4.x and starting progress on 2.0.

https://chatlogs.metabrainz.org/brainzbot/metab... is the first place I see it talked about, but it's been brought up a number of times by now.

Basically: release 1.4, release everything that didn't make it into 1.4 plus bug fixes for 1.4 as 1.4.1, "master" is now 2.0-development branch.

ruaok: I've come up with some stuff on how I plan to store stats from BigQuery in the Postgres db and I was hoping to get opinions, if you have time.

The idea is basically one table for each stat and storing when stats were last calculated for the entities and the users.

[picard] samj1912 closed pull request #535: PICARD-300: Dont save files if metadata is unchanged (master...picard300) https://git.io/vMWls

[picard] samj1912 opened pull request #643: PICARD-996: Fix cover art box show (master...picard996) https://git.io/vy4FG

samj1912/picard#81 (picard996 - 2d5ee1c : Sambhav Kothari): The build passed.

Change view : https://github.com/samj1912/picard/compare/5e2f...

Build details : https://travis-ci.org/samj1912/picard/builds/20...

alastairp: why shouldn't they be? we want to promote both challenges and results

<BANG>

🙋

hi

:)

Hi :)

The weather's lovely here these days... and I just got a ticket for Scandinavia. :|

iliekcomputers: How's your week been?

(Aka, go ;))

Over the weekend though, I sent a few PRs, worked on porting LB from 2 to 3

and started work on my GSoC proposal

fin :)

ferbncode: go

oi

Hi :D

Freso: i dag hvar det sol her ihvertfall

I worked on migrating spam reports off ORM and sent a PR. Also I worked on links on spam reports which was a todo task in CB. Also I started working on my proposal for migrating off python-musicbrainzngs and Using MB database directly idea for CB.

fin! :)

(Other people still up: samj1912 Freso ruaok reosarevok Quesito bitmap zas Gentlecat alastairp? LordSputnik? Leftmost? Leo_Verto? CatQuest — anyone I missed, raise thy virtual hand.)

Freso: Go! :)

😏

Keeping up with IRC, forums, etc.; had a meeting with Rob last week about how to prioritise and deal with the tasks I'm behind on; been spending too much time on the forums responding to artists trying to find their MBIDs :/ ;

:(