#metabrainz

/

      • CatQuest
        more cats \o/
      • Gentlecat
        and reviewed some code, as usual
      • fin
      • bitmap: ?
      • bitmap
        fixed some bugs and perf issues with the json dumps, as found on sentry
      • also fixed MBS-9342
      • BrainzBot
        MBS-9342: InitDb.pl fails to import data with DBD::Pg 3.6.0 https://tickets.metabrainz.org/browse/MBS-9342
      • drsaunders joined the channel
      • bitmap
        and MBS-9309
      • BrainzBot
        MBS-9309: Mediums fail to merge when two recording positions are swapped https://tickets.metabrainz.org/browse/MBS-9309
      • reosarevok
      • Quesito
        Gracias reosarevok
      • :)
      • bitmap
        and MBS-9365 as reported by ferbncode_ (thanks)
      • BrainzBot
        MBS-9365: event_meta_fk_id was never created as part of any upgrade script https://tickets.metabrainz.org/browse/MBS-9365
      • bitmap
        other than that, code review and deployed random stuff
      • fin, zas
      • zas
        played a lot with logs
      • did https://musicbrainz.org/tops/mb_top_stuff.html with the help of bitmap for the jquery part
      • ruaok
        that top stuff page looks great, btw. thanks!
      • CatQuest
        it's super great :D
      • yvanzo
        !m zas
      • BrainzBot
        You're doing good work, zas!
      • zas
        more will come on this
      • CatQuest
        what did you think all my "!m zas" was about? :D
      • zas
        i started to block a bunch of ws abusers (again)
      • ruaok
        and the spam users are already getting fewer hits. very good
      • hibiscuskazeneko has quit
      • zas
        plus usual upgrades and server supervision
      • samj1912 is here
      • fin, samj1912 !
      • ;)
      • Freso
        (Still up: yvanzo, psolanki, ListMyCDs, ferbncode; maybe up (please confirm): alastairp, Leo_Verto[m]; anyone else?)
      • ferbncode_
        bitmap: np :)
      • samj1912
        spent time this weekend figuring out mbxml code, apart from that fixed a jira ticket and code reviews
      • fin
      • yvanzo: go
      • yvanzo
        salute
      • I spent most of last week debugging a weird issue in tests renderer and coding the removal of illegitimate accounts.
      • Also did normal stuff: reviews, forums
      • finito, ListMyCDs? (psolanki seems to be missing)
      • ListMyCDs
        I have little concrete to report. I've been toying with the code and it's been challenging but also rewarding. I've learned a lot.
      • go, ferbncode
      • ferbncode_
        Hi :)
      • his week I mostly worked on the docker image for setting up a MB database with the dump imports. Also worked slightly on dump_manager.py related PR and worked on the final PR to get CB code completely off the ORM: https://github.com/metabrainz/critiquebrainz/pu.... That's all for my week. fin !
      • anyone left?
      • hibiscuskazeneko joined the channel
      • yvanzo
        alastairp or Leo_Verto[m] maybe
      • Freso
        Seems like we're through.
      • ruaok: spam review
      • ruaok
        k
      • yvanzo: what is the general state of the spam stuff?
      • I'm guessing that bitmap had other things to focus on.
      • ruaok prods yvanzo
      • Freso
        They were *just* here too...
      • ruaok
        ok, we'll get back to spam related things in a minute.
      • bitmap
        the PR he has up looks good, I think just tests need fixing
      • ruaok
        instead, lets go with ws/2.5
      • yvanzo
        It is almost complete, should be in production in two weeks.
      • ruaok
        ah, ok. back to spam, I guess. :)
      • how about the script to remove old accounts?
      • yvanzo
        The PR is for half of tickets, I already worked on the rest.
      • bitmap
        I can hotfix it when it's complete
      • CatQuest
        Spam Spam Sapm Glorius Spam ♫♪♬
      • ruaok
        bitmap: yes, I'd like that when the other fires are put out.
      • yvanzo
        We can probably push everything this week then.
      • ruaok
        I'm guessing we won't really have much of a change to review the impact before I leave on vacation on thursday.
      • does the spammer account removal script have a dry-run option?
      • CatQuest
        ♫♪♬ Spam Spam Spam Glorious Spam ♫♪♬
      • ruaok
        it might be nice to post an excerpt of the output and let people sanity check it.
      • Sophist-UK
        Freso: If you want to try to discuss multi-level works, ping me.
      • Freso
        Sophist-UK: I think it's the only topic for tomorrow, so... :)
      • ruaok
        yvanzo: please let people sanity check the results before you run it.
      • CatQuest
        +++111
      • yvanzo
        The removal should not be effective before two weeks.
      • ruaok
        sounds like we're too early to have much of a recap on the spam stuff.
      • ok, then we can review when I get back.
      • onward to WS/2.5
      • zas is having to spend a lot of time blocking asshats and in general combatting spammers.
      • we really need to move to an API key, there is no way around it MB has become too popular now.
      • Quesito
        +1
      • ruaok
        there is a toolkit that can make all of this pretty easy... Kong, right zas?
      • problem is that it only works with JSON.
      • zas
        yes
      • I can explain if you want ruaok
      • ruaok
        sure, go!
      • zas
        Basically Kong is an API gateway, providing everything to manage an API-key based JSON API, including plugins for rate limiting, oauth, and tons of shit
      • but we can't move to it, because our API is mainly XML
      • and it would require too much changes etc...
      • reosarevok
        So is it time for a real v3? or why v2.5?
      • zas
        here is the 2.5 trick
      • we have XML + JSON atm
      • Freso
        Fix the two JSON-out-of-beta blockers and make ws/2 JSON + Kong = ws/2.5?
      • ruaok
        reosarevok: it would actually be ws/3, but I did't want to confuse the topic with the actual ws/3
      • zas
        Exactly !
      • reosarevok
        But doesn't that still kinda force us to keep maintaining 2?
      • ruaok
        yes.
      • spuniun joined the channel
      • we're stuck with ws/2 for at least 2+ years.
      • zas
        yes
      • Freso
        (But can we kill ws/1 now?)
      • ruaok
        Freso: different topic, another day.
      • anyways, that is the general idea.
      • alastairp
        hi, I'm not really here at the moment, but https://www.3scale.net/ appears to do the same thing from what I understand, and is barcelona local
      • samj1912
        and we can also move to mbjsonin picard? :P
      • s/jsonin/json in
      • zas
        alastairp: interesting, we didn't dig that much yet, i guess there are some alternatives
      • samj1912: yes
      • reosarevok
        samj1912: no reason not to I guess, as soon as the two beta issues are solved?
      • ruaok
        alastairp: yes, we looked at it many moons ago, but the pricing is shit and traffic has to be routed through them.
      • kong is much more in the spirit of being independent.
      • Freso
        (Also, not FLOSS, FWIW.)
      • ruaok
        but the idea is that we have API keys and a motivation to move people to JSON.
      • alastairp
        ruaok: 👍 cool
      • ruaok
        we can give the ws/2.5 API better rate limits and ws/2 worse rate limits.
      • samj1912
        so we are switching entirely to a key based api now? or will simply having a key allow more requests?
      • ruaok
        as a further motivation.
      • samj1912: just listen!
      • Freso
        Younguns are so impatient these days… :)
      • ruaok
        so, we're floating the idea of this.
      • samj1912
        okay :P
      • ruaok
        what do people think?
      • Freso
        I think it sounds dandy.
      • Sophist-UK
        Who will have to get a key - a developer of a tool or every user?
      • ruaok
        once we have API keys we can do a lot of things.
      • give people better rate limits and even charge for them.
      • CatQuest
        I just read that as "danky" ಠ_ಠ
      • ruaok
        Sophist-UK: developers.
      • zas thinks we can do this without a lot of effort, so we wanted to float the idea and see what people thought.
      • another thing that we would do is use twitter style rate limiting on the new API.
      • reosarevok
        ruaok: so as a Picard user, I can't pay MB to let me hammer it with my own Picard?
      • Freso
        ruaok: Do you envision one key per tool/app, or one key per developer?
      • samj1912
        charging for rate limits will also include a SLA?
      • Sophist-UK
        How about a better rate limit for ws/2.5 than for ws/2 to encourage developers to switch?
      • ruaok
        the same concept we use for LB WS.
      • Quesito
        I think it's brilliant. and will help in an untold number of ways.
      • reosarevok
        Sophist-UK: " we can give the ws/2.5 API better rate limits and ws/2 worse rate limits." above ;
      • ruaok
        reosarevok and Freso: Not sure yet. Details to be worked out.
      • reosarevok
        p
      • Sophist-UK
        Sorry - missed that.
      • ruaok
        but ideally, it would be nice for a picard user to get a paid higher rate key.
      • CatQuest
        wait.. what now
      • paying for picard usage??
      • ruaok
        not that it would bring in a lot of money, but it would shut up some screamers. :)
      • CatQuest: paying for FASTER usage.
      • CatQuest
        :/
      • i don't like it
      • zas
        The idea, to start, is to just put a new front end (different url), but keeping the same backend
      • Sophist-UK
        Picard and Picard Pro. (Same code - only difference is that Pro is paid for and gets a better rate limit.)