19:06 PM
jsturgis has quit
19:08 PM
LordSputnik
Leo_Verto: sorry forgot
19:08 PM
Might not be able to tonight
19:08 PM
Feel free to go on without me though :)
19:09 PM
Leo_Verto
no problem, just wanted to know for planning tonight
19:09 PM
seeing as Leftmost is currently on a train, maybe we should do this another time then
19:10 PM
Leftmost
Not on a train, just in a bar. Is that worse? :P
19:10 PM
Americans don't ride trains.
19:11 PM
I'm on planes all of tomorrow, so won't be available.
19:12 PM
(From 8 UTC+1 to 6 UTC+1.)
19:12 PM
Leo_Verto
when are you going to be back in Montana?
19:13 PM
Leftmost
On the 13th, European time.
19:15 PM
Don't hold it up for me. I can comment async.
19:18 PM
arbenina_ joined the channel
19:19 PM
I'll try to write up some ideas and comments on what's there.
19:25 PM
arbenina_ has quit
19:41 PM
UmkaDK has quit
19:53 PM
jsturgis joined the channel
20:03 PM
samj1912
20:15 PM
github joined the channel
20:15 PM
github
[sir] samj1912 opened pull request #31: SOLR-9: Add ASIN to release results (master...solr9)
https://git.io/vdw2V
20:15 PM
github has left the channel
20:18 PM
samj1912 is slowly picking up on solr code
20:19 PM
samj1912
Mineo: once you know where everything is and what it does, the sir code makes complete sense. It is written and documented very well! :D
20:24 PM
ruaok: can you turn on the solr vm again? I wanted to set it up so people can help me find solr bugs, either that or I can update the existing config at solr.mb if it is a locally installed setup
20:27 PM
20:27 PM
BrainzBot
SOLR-22: Disambiguation not shown in (at least) work and label search results
20:27 PM
samj1912
you filed the ticket
20:27 PM
ruaok
samj1912: should be up soon
20:27 PM
samj1912
cool :)
20:29 PM
reosarevok: nvm, got it :)
20:29 PM
reosarevok
Damn, just got it too :p
20:29 PM
Ok
20:29 PM
20:34 PM
samj1912
bitmap, reosarevok: is disambiguation called something different in the database?
20:34 PM
reosarevok
might be comment
20:34 PM
samj1912
20:34 PM
okay
20:34 PM
reosarevok
Yeah, def comment then
20:34 PM
samj1912
cool
20:45 PM
SothoTalker_
should be renamed then o.o
20:49 PM
github joined the channel
20:49 PM
github
[sir] samj1912 opened pull request #32: SOLR-22: Add disambiguation comments to labels and work (master...solr22)
https://git.io/vdwoC
20:49 PM
github has left the channel
20:49 PM
reosarevok
SothoTalker_: renaming a column in the DB is not particularly trivial :p
20:50 PM
samj1912
reosarevok: added it for work and labels, if you get time, please let me know which all are supposed to have it but currently dont
20:50 PM
reosarevok
samj1912: make sure they're available elsewhere too
20:50 PM
haha
20:50 PM
I see
20:50 PM
SothoTalker_
reosarevok: no? a simple sql query should do it.
20:50 PM
reosarevok
Well is the stuff available to query somewhere right now?
20:50 PM
samj1912
20:50 PM
reosarevok
Ok!
20:51 PM
samj1912
its an old instance but should be latest one since I started making changes
20:51 PM
reosarevok
SothoTalker_: it would need to happen during a schema change since it affects every single down user, and it feels there's not that much to gain from it that it would make sense to force a rewrite of all code currently using "comment" :p
20:51 PM
(including for all data users like the BBC)
20:51 PM
SothoTalker_
"mimimi" :D
20:51 PM
reosarevok
samj1912: how does this actually work? :D
20:52 PM
samj1912
reosarevok: same way as ws/2/ works
20:52 PM
SothoTalker_
well, i understand :)
20:52 PM
samj1912
wait let me show you an example query
20:52 PM
reosarevok
That'd help :)
20:52 PM
gcilou has quit
20:53 PM
samj1912
20:53 PM
the part in the query before ":" is the field to be searched , the part after is the value
20:54 PM
reosarevok
20:55 PM
Wait, is this showing less results than ws/2?
20:55 PM
samj1912
yup
20:55 PM
might be
20:55 PM
not all data is indexed
20:55 PM
reosarevok
count="33"
20:56 PM
it shows less than 33
20:56 PM
How do I go to page 2?
20:57 PM
reosarevok is confused
20:57 PM
samj1912
&rows=20&start=10
20:57 PM
rows = number of results
20:57 PM
start = where to start from
20:57 PM
reosarevok
Ok nevermind, it does show it for events then
20:57 PM
samj1912
21:00 PM
reosarevok
21:00 PM
Anyway, other than that it seems like stuff does have the disambiguation where it should
21:01 PM
samj1912
reosarevok: hmm, I dont think it should
21:01 PM
reosarevok is going watch The Expanse again, please add yourself a ticket then ;p
21:03 PM
lol :P
21:03 PM
yes
21:08 PM
github joined the channel
21:08 PM
github
[sir] samj1912 opened pull request #33: SOLR-53: Show disambiguation only where it is not blank (master...solr53)
https://git.io/vdw6V
21:08 PM
github has left the channel
21:08 PM
samj1912
well, enough for today I think
21:09 PM
ruaok
you machine. :)
21:09 PM
I'm feeling vastly happier about the solr project now. thanks samj1912
21:10 PM
samj1912
ruaok: no worries :D, even I am excited about it now that I know my way around it a bit
21:10 PM
ruaok
phew.
21:10 PM
doing this job well is going to make a lot of people happy.
21:11 PM
samj1912
\o/
21:14 PM
my current plan is to bring solr to current search server parity and then go on improving things
21:14 PM
ruaok: is that fine?
21:15 PM
improving = adding new features / our reindexing process talk
21:16 PM
ruaok
yes, perfect plan.
21:16 PM
samj1912
cool
21:16 PM
ruaok
though, one tweak to your master plan...
21:17 PM
samj1912
?
21:17 PM
ruaok
parity, reindexing, testing, production, new features
21:17 PM
new features are dead last.
21:17 PM
samj1912
cool
21:17 PM
ruaok
live index updating is also a must
21:18 PM
but I think that falls under "parity". :)
21:18 PM
drsaunde joined the channel
21:18 PM
samj1912
uhuh, I guess I'll have to read more on solr for that one
21:19 PM
ruaok
that was one thing that gentlecat was working on.
21:19 PM
samj1912
when you add "live" in front of anything it becomes so much more complex :P
21:19 PM
okay
21:23 PM
ruaok: you might want to join #solr too (just for reference when we are stuck on blocks)
21:32 PM
khan has quit
21:41 PM
Leftmost was made for mountain climes.
21:42 PM
Leftmost
Mountains much further from the equator.
22:01 PM
samj1912
22:02 PM
ruaok
fixed
22:02 PM
samj1912
thanks :)
22:04 PM
updated the readme
22:23 PM
D4RK-PH0ENiX has quit
22:23 PM
D4RK-PH0ENiX joined the channel
22:23 PM
D4RK-PH0ENiX has quit
22:44 PM
D4RK-PH0ENiX joined the channel
22:49 PM
agentsim joined the channel
23:48 PM
LordSputnik
Freso, ruaok: added ideas for BB to the GCI page. Will go back over them tomorrow to add some more and categorise