Is it not shown in search results if they're the same?
samj1912
its not shown in the current search at all
reosarevok
Huh? But that link up there is to the current search
Or what am I missing?
samj1912
oh sorry it is
I meant the alias list
alias list in the artist credit of a related release
reosarevok
Oh
Hmm
I think that might have been intentionally dropped at some point
samj1912
and also the current solr server outputs the artist on each release(even if its the same)
I think I should fix that
reosarevok
Does the search not do that?
(the current search)
I haven't checked, but I'd expect it to be there
samj1912
nope, it doesn't show artist credit for a related release if it is the same as the original recording
reosarevok
Huh
Well, then you should keep that I guess, yeah
samj1912
okay
reosarevok
And the alias list thing should be kept as in the current search for now too I guess, concentrate on parity :)
(if someone thinks it should be added back to solr later, they can ask for it)
arbenina_ joined the channel
ruaok
bitmap: > did someone delete Gentlecat's MB account? he asked what happened to it, and that also might explain what happened to the OAuth keys, since they were attached to his account
it was the exact opposite way around. Gentlecat removed the oauth keys from meb.org, officebrainz and CB -- all the sites he created, which would've been fine, but he did not warn me about doing this. this disabled logins on those sites, which was a willful act of sabotage. Once I cleaned up the mess, I deleted his account.
samj1912
ruaok: please have a look at the pending PRs on sir when you have time :)
ruaok
I won't have time today, sorry.
samj1912
okay
iliekcomputers
Happy weekend😬
CatQuest has quit
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
github joined the channel
github
[mmd-schema] samj1912 closed pull request #11: Create definition for language (master...solr) https://git.io/vdV8O
github has left the channel
Nyanko-sensei has quit
SothoTalKer
maybe it was just a misunderstanding :x
github joined the channel
github
[sir] mayhem closed pull request #38: SOLR-17: Remove tag count due to buggy JSON output (master...solr17) https://git.io/vd10m
github has left the channel
ruaok sneaks in some reviews
ruaok
samj1912: I realize I haven't answered you from a few days ago about how I do reviews.
for the search stuff, I just read the code -- I don't have a complete setup to test things.
whereas for LB I have the complete setup (it is very easy to setup) and then I can actually run the code through a few tests.