#metabrainz

/

      • Freso
        SKGCI: fin?
      • SKGCI
        thankyou to the mentors for helping me put! Sadly my first and last GCI but the expereince was amazing thankyou!
      • chhavi_
        no issue. next time :)
      • Freso
        SKGCI: Still a week more!
      • SKGCI
        hahah yeah :D
      • fin. Leftmost you're next
      • Leftmost
        o/
      • I processed some GCI tasks and did a bit of code review. I also kicked out some BB PRs to fix a number of issues or improve things, the most visible of which is that now identifiers are tied to the appropriate entity types, preventing users from adding new identifiers which can't apply to the entity they're editing.
      • Fin. naiveai?
      • naiveai
        oh, that was quick
      • Freso
        Let's try and keep reviews short now. Only 12 more minutes, and still 7 people up for reviews.
      • naiveai
        I did a variety of things. I added two reports to MB which I am very proud of. First time I've worked with SQL significantly
      • Freso
        (Still up: darkhorse, IsaacZanoria__, anshuman73, ferbncode, chhavi_, Leo_Verto – other people maybe up (please confirm): LordSputnik, alastairp, ListMyCDs; anyone else?)
      • samj1912
        and topics left
      • naiveai
        did some duplicate refactoring for BB which was also very nice :) thanks Leftmost and LordSputnik!
      • Freso
        samj1912: Topics will get pushed to next week.
      • naiveai
        also improved french guess-case, and did a thing on whipper
      • fin. darkhorse?
      • Freso
        Thanks naiveai!
      • darkhorse: Ping?
      • anshuman73: Go!
      • anshuman73
        Seeing there are a lot of people in line for reports today, I'll keep it short.
      • been busy with exams/new year/college applications/exams again.
      • picked up GCI again today, will make sure I get my duties done; but another set of exams start friday, so :meh:. But seeing only a week is left for GCI, I'm really happy with what all we've got done this year.
      • fin
      • ferbncode: go!
      • ferbncode
        Hi o/
      • I updated my PRs https://github.com/metabrainz/acousticbrainz-se... and https://github.com/metabrainz/acousticbrainz-se... in AB after the CustomFlask and Redis changes in AB. Also, helped with the GCI tasks for CB. Also, had some discussion with iliekcomputers on improving CB tests.
      • fin
      • chhavi_: go!
      • chhavi_
        hii
      • So we made another round of progress on BB mockups. I did round 2 mockups of the landing page, bulk editing interface and relationship editor.
      • Since I am familiar with UX messups in MusicBrainz now, I am really trying to keep Leftmost and Ben aware of them and avoid them. Both have been really cool about it :)
      • This week I will be moving things for MusicBrainz mockups.
      • Also started learning React, so far so good :)
      • Fin.
      • Freso
        (Still up: darkhorse, IsaacZanoria__, Leo_Verto.)
      • chhavi_
        IsaacZanoria__: ?
      • reosarevok
        chhavi_: messups? :'( :p
      • vishalchoudhary[
        Drakhorse here. Was adding a common button for adding files and folder in picard. Got to know a lot of stuff ..
      • IsaacZanoria__
        Hi
      • chhavi_
        reosarevok: you know, the things people keep complaining about. Only from the interface perspective. Nothing else :)
      • IsaacZanoria__
        Uh, I’ve been working on tasks for critiquebrainz and bookbrainz, with a couple of no code tasks in the beginning
      • Was having trouble with the first critiquebrainz task because I couldn’t set up the env through docker, but the other tasks helped with furthering my understanding of sql and data structures in general, which I think will be helpful down the line
      • naiveai
        IsaacZanoria__: as Freso said, keep the reviews short for today, don't go into specifics
      • drsaunders jumps quickly in
      • IsaacZanoria__
        And, uh, thanks to all the mentors here who’ve helped me, or anyone else who’s answered my questions in irc, fin
      • drsaunders
        finished my 3rd NXNE
      • anshuman73 thinks it's fine to have the reviews, doesn't matter if we go over a minute or two, considering this is IsaacZanoria__ 's first review
      • Freso
        vishalchoudhary[: Got anything else?
      • drsaunders
        and boy was it a *itch, so i thought i would brad
      • brag
      • drsaunders jumps quickly back out
      • Freso
        If not, Leo__Verto: Go!
      • Leo_Verto
        I mentored some more GCI tasks, mostly BrainzBot and did some own work on that project and while it's not perfect yet, the setup has been improved quite a lot and is actually pretty fast now (now it won't download and compile Node.js if you already have npm installed!)
      • I also went to the 34th Chaos Communication Congress which was great fun and my MusicBrainz sticker was even recognized by a few people :D
      • If more people are planning to attend next year's C3, we could maybe even organize an assembly like the OSM community does.
      • fin.
      • Freso
        Leo_Verto: Poke me about that when we get closer. :)
      • Leo_Verto
        will do :D
      • Freso
        Alright. darkhorse/vishalchoudhary[ seems to not have more to add.
      • And no more people are up for reviews.
      • reosarevok
        Leo_Verto: nerd. I think ruaok has gone to some of those in the past?
      • ruaok nods
      • naiveai
        Freso: if it's possible, could I go into my agenda thing? i just want to bring it up, nothing more.
      • Freso
        naiveai's and chhavi_'s agenda items will get pushed to next week, since there's no way we can make any of thse in 2½ minutes. :)
      • Leo_Verto
        yeah, I somehow managed to miss him last year
      • naiveai
        ok, np
      • Freso
        naiveai: Preferably not
      • ruaok
        ya know, there is only 2 people there.
      • Freso
        So thanks for your time tonight!
      • anshuman73
        ferbncode: you still up ? I'd like to discuss some stuff regarding CB
      • reosarevok
        ruaok: tbf it's usually hard to miss you
      • Freso
        </BANG>
      • naiveai is going to sleep
      • naiveai has quit
      • naiveai: As you should. Goodnight!
      • Ah well.
      • ferbncode
        anshuman73: yup, I was going to ask you after the meeting :)
      • reosarevok
        ruaok: make sure you wear that purple jacket if you go next year, then you're 100% unmissable :D
      • ruaok
        and dying of heat indoors.
      • anshuman73
        ferbncode: oh, mine is regarding publish date task, one IsaacZanoria__ is working on
      • reosarevok
        sometimes you need to suffer for fashion
      • drsaunders
        ruaok is already unmissable....unless he's wearing a hat (or helmet)
      • anshuman73
        ferbncode: what's your preferred fix ? I like the ability to have a published column in the DB rather than have the publish date being the revios date
      • reosarevok
        drsaunders: knowing the kind of hats or helmets he'd wear, he'd still be unmissable :D
      • CatQuest
        inb4 hat or helmet is orang and purple
      • dammit reo
      • :D
      • IsaacZanoria__
        Oh, that’s me
      • Rahul_India
        Hey I'm not known to any programming language, can more 'no code' editing tasks be aaded to GCI
      • IsaacZanoria__
        Did you want me to just mark published as the last revision time stamp?
      • Cuz I could do that, but I thought you wanted this solution because you tagged it python and sql
      • anshuman73: but do the changes work? Because I still wasn’t able to set up the env to test it muself
      • anshuman73
        IsaacZanoria__: no no, I wanted to discuss what the best solution would be
      • heyoni joined the channel
      • IsaacZanoria__
        ok
      • anshuman73
        I like your current fix, but I still haven't tested it locally, mostly because it involves DB changes so I didn't wanna mess with my local setup before ferbncode and I agreed on a solution
      • as I've said in a discussion regarding this before, I prefer to show the original publish date and then a "revised on" tag
      • (if necessary)
      • ferbncode
        I think that adding the publish date as a column in the review table would be a good option
      • anshuman73
        Wanted reviews from other people on this too
      • IsaacZanoria__
        yeah, that’s what I tried to do
      • ferbncode
        that should be an ideal solution, given that the older revisions before the review was published can also be seem
      • *seen
      • anshuman73
        yes
      • I think we should have a "revised on" link as well in case a revision exists which then links to the revision history
      • what do you say ferbncode ?
      • ferbncode
        We have the "view older revisions" link at the bottom and yes, it would be good to show last revised date in case its different from the publish date
      • Leo__Verto has quit
      • IsaacZanoria__: I will try and test/review your PR soon :)
      • IsaacZanoria__
        Thank you
      • ferbncode
        anshuman73: we can make a task for that too :)
      • anshuman73
        for adding the conditional revised on date ?
      • +1
      • ferbncode
        yup, I will make a ticket
      • :)
      • IsaacZanoria__
        Is that gonna be a task?
      • anshuman73
        IsaacZanoria__: hopefully yes
      • unless you'd like to fix it in this PR itself
      • ferbncode
        anshuman73: what do you suggest we do with the existing reviews? keep their publishing date same as now, right?
      • anshuman73
        oh boy
      • you don't have access to the prod DB do you ?
      • Rahul_India
        with this also add some more 'no code' tasks too if possible
      • thanks
      • ferbncode
        no, not now, we can ask bitmap to help us. Also, I am not very familiar with the production setup however
      • SKGCI has quit
      • anshuman73
        ferbncode: I think the best step is that when that PR is merged, we'll need to restart the server, and fill the publish date columns with the review's revision 1 date
      • Rahul_India has left the channel
      • yeah, bitmap or zas will have to help, I'm not familiar with prod server either
      • plus no clue how we'll populate the new column for all previous reviews
      • anshuman73 screams for help
      • ferbncode
        that can be done using insert..select sql queries
      • anshuman73
        yeah, but prod access to do that
      • ferbncode
        but we need to take care about that while the PR is merged 😅
      • anshuman73
        yeah
      • ferbncode
        I think we can proceed with the solution, or think some more, and take care when the PR gets merged. right?
      • anshuman73
        yes
      • I'm cool with this solution
      • ferbncode
        Also, as you suggested, i think that ticket about "last revision date" is unnessary and can be made part of the same ticket
      • anshuman73
        +1
      • ferbncode
        okay, great :)
      • anshuman73
        perfect :)
      • dragonzeron joined the channel
      • dragonzeron
        did you guys get my message for the meeting
      • cause I was in school so I coudnt join in sadely
      • anshuman73
        dragonzeron: yes we did :)
      • dragonzeron
        ok yeah hopefully I was able to contribute a lot cause I have been working on this site and what not and help remove Wikipedia links
      • and replace with wikimedia