#metabrainz

/

      • demonimin has quit
      • iliekcomputers
        ruaok: re the cron thingy, I took a look and it seems that cron doesn't start automatically in the other containers anyways, so us just starting cron in the scheduler container with `cron -f` should be okay?
      • Rotab joined the channel
      • ruaok
        I've seen Cron running in the -web container. Should that happen?
      • demonimin joined the channel
      • iliekcomputers
        hmm, it shouldn't.
      • ruaok
        Have a look at the listenbrainz-web-beta container and see if you see it's log entries.
      • iliekcomputers
        it doesn't seem to be running in the beta-web container right now? did you stop it some time?
      • hmm there are logs though
      • weird
      • ruaok
        Not sure. Too sleepy. Will look tomorrow.
      • Nn
      • iliekcomputers
        alright, no prob, g'night!
      • i was wrong, i guess :)
      • naiveai
        Leo_Verto: how did you simulate multiple users in the tests?
      • Leo_Verto
        ha, I don't think that's supported :P
      • naiveai
        sh*t
      • Leo_Verto: oh wait nope, you can pass a "User" parameter to app.respond
      • Leo_Verto
        ah, nice, is that documented anywhere?
      • naiveai
        lemme check
      • Leo_Verto
        probably not, none of the testing environment is
      • naiveai
        nope
      • >note to self: add docs for testing later
      • found it from test_message_service.py
      • Leo_Verto: also, extremely minor note, should usernames be sorted alphabetically, or some other way (order they voted perhaps?)
      • though that may be hard to ensure - depends on whether json gurantees the order of lists
      • Leo_Verto
        vote order is the default, isn't it? just keep it
      • otherwise, doesn't really mattetr
      • but I'm pretty sure json keeps it
      • btw, how are you building your json?
      • hopefully not by hand :P
      • naiveai
        Leo_Verto: not quite sure what you mean
      • using json.dumps(object) really
      • anshuman73
        naiveai: json arrays maintain order
      • naiveai
        is that not how you're supposed to do it?
      • anshuman73: cool
      • anshuman73
        so if you're using json.dumps on a list, it'll make that into a json array, which is ordered, much like python lists
      • naiveai
        Leo_Verto: what I was thinking was to order all votes alphabetically on boolean votes
      • and in non-boolean votes, all the for users come first, then the against users
      • both sorted alphabetically seperately
      • it's a useful grouping because otherwise you'd have stuff like [red(+2, -2): hello, -world, -otherguy, happygolucky]
      • Leo_Verto
        ah no, json.dumps is totally fine
      • naiveai
        >mfw when someone thinks that I build my json strings by hand
      • >:(
      • Leo_Verto
        yeah, definitely order that by for/against, that should also follow the data structure you have right now pretty well, shouldn't it?
      • you never know :P
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | GCI https://goo.gl/8xSZem | Meeting agenda: Reviews, musicbrainz-cli (naiveai), GSoC ideas page (ruaok), BrainzBot voting(naiveai)
      • naiveai
        Leo_Verto: yeah, I just sort the for list, display, sort the against list, display
      • actually, since the for list is appended one by one, it should follow order pretty closely
      • so sorting seems kind of pointless since it does have the *potential* to be expensive
      • the only exception would be if someone changes their vote - they would show up later in the vote list
      • but I think that's fine
      • iliekcomputers
        ruaok: one solution I came up with (when you take a look): https://github.com/metabrainz/listenbrainz-serv...
      • samj1912
        Mineo: ping
      • rgggn has quit
      • kartikeyaSh_ircc joined the channel
      • samj1912 is surprised how some commits to mbsssss even got merged :\
      • naiveai
        mbsssss?
      • samj1912
      • naiveai
        that is clever :D
      • travis-ci joined the channel
      • travis-ci
        metabrainz/picard#2877 (master - ee08a43 : Sambhav Kothari): The build passed.
      • travis-ci has left the channel
      • samj1912
        zas: I think I did something wrong with the X_ACCEL redirection, I am getting a weird redirect here - https://test.musicbrainz.org/ws/2/artist?query=*:*
      • zas
        that's perhaps what i thought about when we talked about it, let me check
      • yvanzo
        samj1912: seen that in logs
      • samj1912
        yvanzo: the wrong redirect?
      • yvanzo
        samj1912: I think so, in mb ws/website container logs
      • (prod)
      • samj1912
        yvanzo: shouldn't be affecting prod?
      • and there was something wrong with the code in the solr PR we merged
      • zas
        it impacts prod ?
      • colbydray joined the channel
      • Leo_Verto
        naiveai: my roadmap for the future of BBot is 1) refactor everything from botbot to brainzbot 2) remove/fix links like the one you just got for help 3) migrate all the old plugins we use to using command prefix 4) throw out all the junk we don't need (e.g the kudos functionality)
      • and somewhere inbetween get the dependencies updated
      • naiveai
        I'm pinning ircmessage to latest rn
      • Leo_Verto
        nice
      • samj1912
      • yvanzo
        There were weird WS queries on prod, might be unreated though.
      • Freso
        ruaok isn't going to be here for the meeting, bitmap do you know enough to be able to lead the GSoC ideas agenda item? Or should we push it to next week?
      • Leo_Verto
        samj1912: is adding a "supported browsers" page a valid fix? :P
      • samj1912
        chhavi_: isnt going to be in the meeting today either, so her topic might be pushed to next week too
      • naiveai
        samj1912: what's the issue? i'm on chrome rn and it doesn't seem to have any issues
      • reosarevok
        Let's move the whole meeting to next week! :D
      • yvanzo
        Freso: GSoC application deadline is 23rd.
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | GCI https://goo.gl/8xSZem | Meeting agenda: Reviews, GSoC ideas page (ruaok), musicbrainz-cli (naiveai), BrainzBot voting (naiveai)
      • Freso
        yvanzo: Yes. That is not what I asked. :)
      • ruaok didn't send me anything about that agenda item, so I'm not sure if it's just meant to be a plea for adding ideas, or if it's something more.
      • Anyway.
      • <BANG>
      • samj1912 just realized chhavi_ 's topic isnt on the chan topic :P
      • Hi!
      • samj1912
        ola o/
      • Freso
        samj1912: She removed it.
      • And speaking of ruaok, I'll let him start!
      • KassOtsimine
        hi!
      • Freso
        ruaok says:
      • """
      • - Doing finances for 2017/Q4 and doing tax prep work for closing 2017, which took a lot of time.
      • - Part of the reason why the process took more time than usual is that I am working to automate more tasks, such as account reconciliation, invoice sending and anything that can possibly be automated. The motivation for this is that this way we will never have any need/desire to hire any contractors who cannot be vetted via our community vetting process that we have in place for developers. Clearly the non-community vetting process
      • doesn’t work well, so we’ll obviate the need for it.
      • - Some PR reviews for ListenBrainz
      • - Some minor hosting tasks relating to ListenBrainz
      • - Some tasks related to managing ongoing affairs with our attorneys.
      • - Heckling our secretary to fill out the doodle for the board meeting.
      • antlarr2 joined the channel
      • """
      • antlarr has quit
      • And chhavi_ says:
      • """
      • I just helped with a few UX tickets. Also, Ruaok and I, updated our Redbubble store with t-shirts and other merchandise. Feel free to request more t-shirt or any artwork to add to the store.
      • """
      • And Freso says:
      • 🙋
      • reosarevok
        🙋
      • naiveai
        \o
      • Freso
        This past week has been pretty much all about GCI as well as continuing my moving-to-Sweden process.
      • KassOtsimine
        forgive me, i'm on a stupid win machine, what is tthose?
      • Ashish
        hi.!
      • Freso
        I did reply to OTHER-321 with some of my thoughts about it, but I suspect we'll talk more about that a bit later.
      • BrainzBot
        OTHER-321: Brainzbot Plugin for Counting Votes. https://tickets.metabrainz.org/browse/OTHER-321
      • naiveai
        KassOtsimine: the emoji Freso always uses at the beginning of his messages - the \o emoji
      • reosarevok
        KassOtsimine: the hi thingy
      • naiveai
        Freso: yep
      • KassOtsimine
        ah
      • Freso
        I also poked at reported editors, after too long not poking at them, but I have to say GCI have been taking far too much of my working time this last week. :(
      • reosarevok
        Last week now!
      • Freso
        However, students can't claim more tasks now, so I hope I'll have more time to catch up on actual things in the coming week.
      • samj1912: Go!
      • +fin
      • haruute joined the channel
      • samj1912
        hello o/
      • KassOtsimine
        hello sambav \o
      • oh
      • samj1912
        this week I did mostly PR reviews and got an alpha solr search setup running on test.mb.org (I *might* write a blog inviting testers and bug reporters)
      • KassOtsimine is now known as CatQuest
      • Freso
        (People still up: reosarevok, bitmap, zas, yvanzo, iliekcomputers – maybe up (please confirm): LordSputnik, Leftmost, Leo_Verto, alastairp, CatQuest, ListMyCDs, ferbncode; anyone else?)
      • samj1912
        apart from that fixed a couple of schema bugs
      • that's all from me
      • zas: go
      • CatQuest
        now after gci I am looking forward to testing that :D
      • zas
        i worked on backup system, made good progress, still testing though
      • haruute is here
      • naiveai
        Freso: I'd like to say a little bit