#metabrainz

iliekcomputers, sounds like a good idea, I've been thinking about this a bit and we've already got a ton of SQLAlchemy objects in test_data so we'd just need to set up the schema and then we should be able to write all of those to the db, right?

yeah.

I remember ferbncode saying that it took too long to put stuff into the musicbrainz database, and that made the tests too slow.

well a temporary sqlite db should be quite fast, shouldn't it?

Leo__Verto: yes, that was what I was getting at too, let's create a temp database instead of using the entire MB database for now.

I figured out the reason the editor tests broke is hidden somewhere in this monster "self.editor_query = self.mock_db.query.return_value.options.return_value.filter.return_value.all"

how did ferbncode even come up with that kind of arcane mocking?

That's Rlreally the only way to make sure the query is correct without an actual db, I think?

*really

yeah, essentially this allows you to replace the return value of query.filter().all() but for some reason it doesn't return the list it should

instead I get an <MagicMock name='mock().__enter__().query().filter().all()' id='139851451372544'>, which is kinda the thing the mock should have replaced

okay, got it

iliekcomputers, by the way, do we still need python2 support in brainzutils?

Leo__Verto: yes, acousticbrainz is still python2

ah well https://pythonclock.org/

[listenbrainz-server] paramsingh opened pull request #423: Improve error reports to the user for spotify imports (master...spotify-messages) https://git.io/fDnPQ

Leo__Verto: I think we should add tests to serialize_editors to make sure password etc isn't returned.

sure

other than that, lgtm 👍🏽

iliekcomputers, done

man this, travis setup would run a lot faster if it didn't use docker and could make use of apt and pip caching :/

[brainzutils-python] paramsingh closed pull request #20: Add editor entity and use sqlalchemy-dst to automatically serialize it (master...autoserialize) https://git.io/f4b2X

[messybrainz-server] mayhem closed pull request #41: LB-372: MessyBrainz: Create artist_credit clusters using artist MBIDs in database (master...artist_cluster) https://git.io/vh6qr

ok, artist clusters are in the bag.

kartikeyaSh: can you please add the same debugging statements to the release cluster PR?

then I can finally run it and have a look at running code.

it would also be nice to update the gist associated with the PR.

I'll have to rebase the release PR over artist one to get common.py functions. And common.py has all the logging

please do

ruaok: what do you want me to update in the gist?

the output of the script, so we can see what it does now

okay, you mean artist_credit gist

not release example gist

that too. but ideally the release cluster PR and add debug features there and update the gist.

okay

[listenbrainz-server] paramsingh closed pull request #423: Improve error reports to the user for spotify imports (master...spotify-messages) https://git.io/fDnPQ

Freso: yay ok

ruaok: done rebasing and updating the gist

for release

CatQuest: If you have any DRs, I think tonight will be another good DR night.

(Only Reviews on agenda, and 3 of them have been mailed in.)

kartikeyaSh: on https://gist.github.com/kartikeyaSh/1c2a2c23787...

ideally there should never be UUIDs for the user to have to cross reference.

yes

instead, output the relevant metadata to show the critical information of the cluster.

ideally, the user would never ever have to cross reference anything when looking at the output.

that makes the output massively verbose, but that is fine. since it is a debugging flag.

if I have to put extra information like release title etc. I'll have to make additional queries to DB. So, I don't know if its worth spending computation power on.

if you need to make more DB requests then that is too much info.

Thats all the information that we can display without any additional queries

ok, for step 1, make the output so that the user doesn't have to look at a UUID nor cross reference anything.

perhaps we need to rethink the process of matching the data then.

right now things are easy and are being done by the database. for the next phases it will be a lot trickier and will need more output for us to judge what is going on.

In next parts artist names, release names will be used, so I'll have those to display somehow. It won't be a problem there

iliekcomputers: :)

<BANG>

`s/Adventure/Meeting/`

People up for reviews: Freso, reosarevok, bitmap, zas, ruaok, yvanzo, samj1912, iliekcomputers, rsh7, bukwurm, Leo_Verto, chhavi_, kartikeyaSh, CatQuest

rsh7: go!

rsh 7 says:

"""

Hello!

Last week I worked on increasing the efficiency of the import_mb_data script, the time taken to import the data has been reduced much more than before. Also, some improvement is still required and I will make more commits soon. Later, I started working on keeping the musicbrainz schema in AB updated with the original MB database and I am still working on it and will be able to create a PR in a day or two.

After this work, the part of importing the MB data in AB and their update related work would be over. The next task is to test both the methods of MB db access. That's all. fin!

"""

chhavi: go!

chhavi says:

"""

Hii,

Made a bit progress on design system, though not as much as I would have liked. Reviewed the mockup of release group page. Should have a little more time in coming days! Also, moved to Bangalore :)

"""

samj1912: go!

samj1912 says:

"""

Released solr to production, fixed a couple of bugs related to that. Currently in Banglore for a few days.

"""

iliekcomputers: go!

Hi

I did some work on the Spotify branch of LB this week.

Also, did some chasing around of finding users in CB that can't get their user ids from musicbrainz

That should be mostly done.

Also, PR reviews on MessyBrainz, brainzutils and AcousticBrainz

Fin.

kartikeyaSh: go

hi

(People still up: Freso, reosarevok, bitmap, zas, ruaok, yvanzo, bukwurm, Leo_Verto, CatQuest – anyone else, please let me know ASAP.)

Last week I worked on reviews of LB-372 and BU-15.

LB-372: MessyBrainz: Create artist_credit clusters using artist MBIDs in database https://tickets.metabrainz.org/browse/LB-372

BU-15: Add function to get releases using recording mbid https://tickets.metabrainz.org/browse/BU-15

Internet down

thats it for me

fin

Freso: go

🙋

Handled some reported editors, some flagged forum content/users, and was around and about.

fin; reosarevok, go.

Usual support, plus editing

I started the community project

For the Composer Diversity, added the first few

People, do contribute!

And I sighed a bit at the drums issue

That's it for now :) CatQuest?

eh hi, I haven't done much except sigh hard at the drum issue. so I'm kina burned out with that so I've decided to take proper time off, now if it's ok