#metabrainz

ok, let me chat with Mr_Monkey for a minute, then I'm on that.

*may-be

🐒

CatQuest: improvement works

alastairp: i figure we could have a new artist page in acousticbrainz, should i open a ticket for it?

pulkit6559: what would the artist page show?

(there's an artist page on musicbrainz already!)

alastairp: if anything, I'd show exclusively recordings for which you have actual submitted data, but not sure if needed

yvanzo: so I'd suggest renaming MBS-9926 to "Convert subscribers pages to React" and then adding a new "Convert user subscriptions lists to React" ticket - given nothing from that ticket is in beta yet, I think it's not really that confusing and it makes more sense than waiting to merge until the entire subscriptions/ folder is converted. It'd help us merge this now for the next beta, and then work on the other thing post schema change

MBS-9926: Convert subscription pages to React https://tickets.metabrainz.org/browse/MBS-9926

reosarevok: STYLE-1162

STYLE-1162: Language attribute on (translated) liner notes relationship https://tickets.metabrainz.org/browse/STYLE-1162

Thanks!

It was listed on the gsoc ideas page, so i thought i could start working on it

Do you have a link?

alastairp: the ideas page has "Lists of artists + albums/recordings for each artist"

reosarevok: It is very unclear to me what has been done and what still needs to be done on that ticket.

Maybe that's what pulkit6559 means?

yvanzo: https://github.com/metabrainz/musicbrainz-serve... https://github.com/metabrainz/musicbrainz-serve... are done (all /subscribed.tt except user) and the current PR is user/subscribed.tt

Btw, can you check the status of your assigned (but closed) tickets and link to PRs in comment if missing?

gr0uch0mars: should i use SingleLiveEvent everywhere in place of MutableLiveDAta

i mean should I replace the live datas in SearchViewmodel as well

reosarevok: Yes i was talking about that

search results always dwell on the same activy

so no prolem there

only when I use fragments in conjunction with activities

yes, I think you can leave it like Mutable

yes,

also I wanted to discuss the implementation

tell me

of other tabs in thee activity

should we query all data of the all tabs in a single query

or in chains

yvanzo: sure, re: linking PRs

reosarevok: Is the current PR gh:MBS#962 the last missing bit for this ticket?

MBS-9926 (III): Also use Subscribers.js for user subscriptions: https://github.com/metabrainz/musicbrainz-serve...

because a single query can with right inc parameters can get us all data we need in a single query, I suppose

gr0uch0mars: ^

yes, I was thinking about `inc` params. We should use them

or we should wait for tabs to open and query each separately

I don't think they will delay too much the response

I think one query is better

because I read that viewpager keeps 2 offpage fragments on hold as well

and we have 4

so in any case there will be 3 calls

so going with one query

ruaok: Last replication packet took about 25 minutes to process. Not sure if that's better or not to be honest! Could be disk I guess...

yvanzo: it is, if we split the "root/user/subscriptions/" part mentioned in the ticket description to a different ticket :)

(that's what I'm asking about)

(I have no PRs nor code written for that ATM)

yes, and in the future I was thinking of caching that single response. If you re-enter the same artist, you already have all the necessary info

requesting multiple queries would make caching more difficult

retrofit does auto caching i suppose

also in searchviewmodel , we first check if uery had changed and only then we uery again otherwise display the same

between sessions? I meant if you close the app and open it tomorrow

no not that

ah ok. I was thinking too much into future :)

reosarevok: IIUC, only subscribers lists have been converted so far (if we include this PR), the rest for this ticket is subscriptions lists, right?

as long as its in memory/background

we can do that in a util class

yes, your implementation is great, too. We should query only when strictly necessary

yvanzo: yes, but while all the subscribers lists are sharing code and very related, the subscriptions lists are not connected to them :)

(so we'd definitely be adding them as separate tickets if we were doing it now, with our smaller PR approach)

reosarevok: got it :) sure, go ahead!

I'll try to do it here as well with MBIDs

yvanzo: yay, thanks

CatQuest: what do you mean? :)

amCap1712: I was thinking of using the Repository to query first local DB (for cache) and, if not, then API

amCap1712: just implement another data layer (cache in DB) in the Repo. So your ViewModels query are not touched

yvanzo: then I think there's only two sets of half-done things for me to finish sending for merge RN, the stats code and the ES6 changes. The stats has only one or two PRs left (the open one + one of the other two is where you had issues with a sample DB, haven't fixed that one yet)

reosarevok: fext: https://beta.musicbrainz.org/release/621666f8-d... booklet says "Simon Phillips" is a sesson drummer "this was the only time we used a session drummer - Simon Phillips"

yvanzo: the ES6 stuff is probably mostly done, as far as we want to do it, so maybe one or two PRs there too

it's suboptimaled as "guest"

CatQuest: that just means "not part of the band", no? guess that's why "guest" is set

yea

I have never felt those things are too relevant, but we could consider it if there's interest

peopel are session musicians though

Style ticket? :)

yush

task or new feat

helo

NF I guess

I don't really pay much attention to those

👍

zas: I cannot find any picard-website resource on Transifex although picard-website code seems to have support for it.

reosarevok: STYLE-1163

STYLE-1163: New performance relationship attribute "session musician" https://tickets.metabrainz.org/browse/STYLE-1163

:D

Neat

:)

zas, outsidecontext: https://twitter.com/The3rdCrow/status/110331826...

Can we do anything to make it less suspicious? :)

I mean I could be completely mistaken aobut the use of "guest" here but I don't think so?

(i have legit never see nthe term "guest" used in a release. but i'm sure it's used loads of palces i havent jsut seen :D)

reosarevok: yes, probably with signing the installer like we do for the macos one

we have a story for that, and I actually want to tackle this in the coming weeks. have been doing more windows installer stuff recently anyway

wtf is "randsomware2 and why the fuck would yo uahve isntalled soemthing that blocks completely valid non-malware or virus programs form working?

CatQuest: because you are using a OS which advertises the use of such software ¯\_(ツ)_/¯

Yay!

Lol

spam

Oh shit. Sorry

Lol. I was scared 😢

Hi yvanzo , Can you send me the doc for convertion from tt to react please ?

The one which was on the metabrainz github. I'm unable to find it unfortunately

gr0uch0mars: ok, i'll do that once artist page infos are complete

great. Let's attack once at a time 👍

ruaok: Mr_Monkey: hi.

Yo

i was wondering if we could track back to the spotify release and see what else needs doing.

iliekcomputers: On my side, I'm changing the follow page playlist functionality a bit, and that will only leave implementing refresh tokens for the player.

hi, I am getting an error when importing the sql database in psql using command : sudo -u postgres pg_restore -e -C -O latest.sql -d postgres . Error showing is pg_restore: [archiver] input file appears to be a text format dump. Please use psql. Is there any other way to do it?

I'd love to talk about it with you at some point

Mr_Monkey: I'm here right now if you want?

As for ruaok , he's out at the moment, so won't speak for him.

Sure :)

Prashant1223: what project is this?

bookbrainz-site repository

yvanzo, Cyna: hi, I'd like a link to that doc too please

Sooo. Currently the user's spotify token we get from the db is used to connect to the web playback api, which returns a token that expires after an hour. Not ideal. How did you set it up on the server side? Is there any way I can use the same method ?

(tt → react that is)

I.e a private API endpoint or something

there isn't an endpoint yet.

but i could create one.

Prashant1223: I'll be with you very soon.

Okay

iliekcomputers: i am annoyed how norway is not in this list

but i pay like 79nok for 1 GB so

iliekcomputers: Well, that would be great.

i don't think LB has any private API endpoints yet.

I suppose that means you have it implemented in the server at the moment

Mr_Monkey: yep, there is a function to refresh tokens.

hi, is there a guide somewhere to the musicbrainz api?

is there any endpoint to access redirect tables?

pulkit6559: normally redirects will just get redirected, I think? :) Why?

we only refresh tokens during the import loop

i was trying to work this out in AB "Use the musicbrainz mbid redirect tables to find more duplicates", so i think ill need to access endpoints for redirect tables