#metabrainz

/

      • aliamo has quit
      • D4RK-PH0ENiX has quit
      • D4RK-PH0ENiX joined the channel
      • Nyanko-sensei joined the channel
      • D4RK-PH0ENiX has quit
      • aliamo joined the channel
      • aliamo has quit
      • Nyanko-sensei has quit
      • D4RK-PH0ENiX joined the channel
      • Wizzup has quit
      • Wizzup joined the channel
      • jwf has quit
      • Slurpee has quit
      • Cyna
        yvanzo: Can you tell me what are the expectations for GSoC students this year 😅
      • spookyninja joined the channel
      • spookyninja has left the channel
      • Cyna has quit
      • reosarevok
        samj1912: submitted again - let me know if it seems ok now
      • If it does I guess adding more XML tests should be more or less simple later on :)
      • Cyna joined the channel
      • spookyninja joined the channel
      • akhilesh joined the channel
      • spookyninja has quit
      • aliamo joined the channel
      • aliamo has quit
      • spookyninja joined the channel
      • rihan_ joined the channel
      • rihan_
        hello everyone :)
      • akhilesh
        Hello!
      • rihan_
        In bookbrainz, What does edition group(publication) stand for ? If there is subtle difference, what should when creating edition group ?
      • akhilesh
      • rihan_
        ohh! thaks akhilesh! :)
      • *thanks
      • akhilesh
        You are welcome!
      • spookyninja has quit
      • Cyna
        reosarevok: what does form_row_text function do in /admin/attributes/form.tt ?
      • reosarevok
      • (in root/components/forms.tt)
      • Cyna
        Ohh
      • Nice... thanks
      • reosarevok
        (form_row is also there)
      • There's already React versions of most of those so you can just reuse them
      • Cyna
        Yea. Ill use them for the convertion
      • spookyninja joined the channel
      • yokel has quit
      • yokel joined the channel
      • reosarevok: How do I know which attribute is required and which is not ?
      • Is it the attributes that are in bold that are required ?
      • reosarevok
        Yes
      • Cyna
        Could you check this out ?
      • Enter only the name and iso code 3
      • You'll get a error
      • reosarevok
        Yup, Frequency should also be mandatory
      • Not sure why it's not marked required. Feel free to change that while porting
      • Khalifa joined the channel
      • alastairp
        pac23: hi, I've updated the project description for the similarity task: https://wiki.musicbrainz.org/Development/Summer...
      • Cyna
        The error is too large to take screenshot of
      • Could you put any number in frequency and then submit ?
      • amCap1712 joined the channel
      • reosarevok
        lol
      • That form is a broken mess
      • Cyna
        What should I do ?
      • How do I know which is required and which is not
      • reosarevok
        The issues are mostly in Perl I think, not TT/React, so you can probably still convert it as-is
      • Cyna
        Is there a list ?
      • reosarevok
        Set only the two bold ones to required, and then let's see if anything else needs to be changed at the same time
      • Right now everything is required because of it being badly coded, it seems
      • But it shouldn't be
      • yvanzo: ^ https://test.musicbrainz.org/admin/attributes/L... probably shouldn't let me add a frequency above 2, given how we've defined them, plus apparently it doesn't allow empty iso 1 and iso 2 codes despite those being nullable
      • I can look into that, but what do you think about the frequency? Should be limit the possible values?
      • alastairp
        English @ 440Hz
      • Cyna
        How to I create a field type for FormRowText ?, is there a function for should I create the object myself ?
      • Khalifa has quit
      • reosarevok
        Cyna: search the codebase for other uses of it and compare :)
      • alastairp: sigh go away :p
      • alastairp
        :(
      • reosarevok
        Fine, fine, don't go away, just improve AB or something :D
      • pulkit6559 joined the channel
      • rihan_ has quit
      • alastairp
        yeah, I'm trying
      • pulkit6559: hi, I replied to your graphs issue on the forums
      • pulkit6559 has quit
      • uh
      • iliekcomputers: good morning
      • pulkit6559 joined the channel
      • pulkit6559
        alastairp: thanks, ill have a look at it :)
      • alastairp: also, can you provide the csv files that were present here https://www.upf.edu/-aporter/amplab/2017/, it will be easier to draw sample graphs if i had those files
      • alastairp
        ah, sure. is there a specific file that you wanted?
      • however, don't spend too much time building graphs - keep in mind that this is the entire point of the project. We don't want you to implement all of the graphs just for the proposal
      • you could also include some of the graphs from the repository that I linked to (and say that you copied these examples from there), and more importantly show a list of all of the graph types that you want to include
      • pulkit6559
        alastairp: ahh, i see. That would make things easier :)
      • alastairp
        the important thing is that the graphs make sense - this is what I was commenting on in response to your proposal. There are some graphs that you listed that don't make sense with the data that we have
      • the proposal should show that you understand the data that we have to work with
      • the extra post that you made is a great idea - you don't have to think about everything yourself and then include it directly in the proposal. You could make additional posts, for example to ask people what kinds of graphs they would like to see in AcousticBrainz
      • Mr_Monkey
        spookyninja: Regarding https://imgur.com/a/HRRH9rC : I like the idea as a visualization of entity relationships, but I don't think it would be easy to understand and use as a form. I think heading towards a more traditional approach would better fit the purpose of this new form.
      • alastairp
        but don't just ask the question with no context - include some existing examples, and show a list of the data that we have available. So perhaps then people can suggest their favourite preferred items
      • pulkit6559
        yes i have made amends regarding that, i will modify the proposed data flow wasnt that clear in the initial proposal
      • regarding box plots,i thought if we have lots of outliers then the data sent to the client will be large
      • alastairp
        for me, the data flow is much more important than a list of function names - I can't understand how you expect it to work with just a list of functions. You should describe in general terms how you load/process the data at each step
      • right, but that's a display decision
      • we could choose to show no outliers, or only the largest/smallest outlier
      • (you didn't specifically mention that in your question, so I didn't know that this was your concern)
      • Mr_Monkey
        akhilesh: I think submitting entities via the API is a hot topic and needs a lot more community discussion to know how to do it well. I think you can leave that part out of your proposal.
      • iliekcomputers
        alastairp: morning
      • pulkit6559
        ah yes, i should have been explicit about that
      • also, showing just the largest and smallest outliers is a good idea
      • alastairp
        pulkit6559: great. it's not a problem if you don't exactly know how to solve something (e.g. transferring lots of data), but if you explicitly list it then we know that you've thought about it and we can suggest solutions
      • pulkit6559
        alastairp: ill keep that in mind :)
      • spookyninja
        Mr_Monkey: I was thinking that they could use the current form for the editing/creation of the entities, but handle the relationship part with the visualization
      • Otherwise I was thinking that a shopping cart style of editing could work as well
      • reosarevok
        Does anyone know if ruaok will be here for the meeting?
      • Mr_Monkey
        spookyninja: The point is precisely not to use the separate forms that we currently have, but to design one form where you can create all the entities you need to describe a book, and that automatically links them (automatically creates relationships)
      • What do you mean by shopping cart style?
      • reosarevok: ni puta idea.
      • amCap1712
        reosarevok: nope, if he didn't change plans
      • reosarevok
        Sigh, ok. rang a bell
      • Thanks
      • amCap1712
      • reosarevok
        Damn. Thanks!
      • spookyninja
        Mr_Monkey: Ah thanks for the clarification. I guess I misunderstood the project description...
      • I'll work something else up
      • Mr_Monkey
        That was a good idea to visualize relationships between entities, though.
      • spookyninja
        Maybe we can use it to show relationships on the entity pages instead?
      • shiv6146 joined the channel
      • D4RK-PH0ENiX has quit
      • CatQuest
        lol i logged in as modbot on test
      • ,.... D:
      • "Mendelssohn - String Quartets Op. 12-80-81 (Sharon Quartet)"
      • huh
      • that's not what i copied
      • ,.... D:
      • "You’re currently not allowed to edit or vote because an admin has revoked your privileges. If you haven’t already been contacted about why, please send us a message. "
      • :(
      • shiv6146 has quit
      • D4RK-PH0ENiX joined the channel
      • reosarevok
        Well, I don't think bots are allowed to vote
      • But edit? Maybe someone was just playing around :)
      • CatQuest
        oh duh. i accidentally set "editing voting disabeled" :P
      • I was just lookinginot how editing privs look for like.. uh you
      • there is no way to edit locale is there
      • it should be an atribute too
      • then we could amend the ones when needed and also remove unsuitable ones
      • we could also thne make the searchbox for locale liek the vocla one is right now. searchable with text entered
      • ... is ther a ticket?
      • G0re has quit
      • reosarevok
        Locale is just using a code from Perl
      • CatQuest
        exactly
      • its crappo