0:02 AM
D4RK-PH0ENiX joined the channel
0:09 AM
baniket has quit
0:43 AM
code_master5 has quit
0:59 AM
Nyanko-sensei joined the channel
1:01 AM
D4RK-PH0ENiX has quit
1:40 AM
demonimin_ joined the channel
1:40 AM
demonimin has quit
1:48 AM
demonimin_ has quit
1:48 AM
ferbncode has quit
2:05 AM
demonimin joined the channel
2:47 AM
aliamo joined the channel
2:49 AM
ro0fka joined the channel
2:51 AM
ro0fka has left the channel
2:51 AM
aliamo has quit
3:04 AM
Nyanko-sensei has quit
3:04 AM
D4RK-PH0ENiX joined the channel
4:46 AM
spellew has quit
6:18 AM
baniket joined the channel
6:30 AM
gr0uch0mars joined the channel
7:15 AM
ferbncode joined the channel
7:40 AM
ruaok
moooooin!
7:40 AM
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | New GSoC students start here: https://goo.gl/7jsjG2 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda (17:00 UTC): Reviews, Season of Docs (reo), next meetings (Freso), howto guides (ruaok)
7:41 AM
pristine__: last night it became clear to me that it isn't obvious how to write data processing scripts that produce useful output.
7:41 AM
kartekeya had problems with this as well. I've been doing it for so many years, I took this morning to collect my thoughts:
7:41 AM
7:41 AM
give it a read and the let's discuss, ok?
7:49 AM
pristine__
ruaok: hi. I will return in sometime after the class. Let's discuss then, okay? :)
7:49 AM
ruaok
no rush
7:52 AM
anshuman73
Is it a good idea to include non-development work as a part of GSoC ? For eg. I think designing of badges achievements for CB's gamification can be done in the timespan, maybe even alonside woth coding parts, but am not sure if that should be a part of the proposal. TBH I would like to make it a part of it.
7:53 AM
yvanzo
mo’’in’
7:54 AM
ruaok
moin yvanzo!
7:54 AM
anshuman73: yes, that is fine. the main criteria is that the GSoC project needs some amount of coding -- it can't be all design.
8:04 AM
Lotheric has quit
8:04 AM
Lotheric joined the channel
8:29 AM
aliamo joined the channel
8:30 AM
reosarevok
ruaok: speaking of design - my MeB keyring died :(
8:31 AM
Feels the hole was a bit too close to the edge or something?
8:31 AM
anshuman73
ruaok: yes, ofc. Design is a small part of my proposed work
8:34 AM
aliamo has quit
8:35 AM
ruaok
reosarevok: the wooden one?
8:35 AM
reosarevok
Yeah
8:35 AM
ruaok
oops. good to know. I've got more, you can get another one.
8:37 AM
CatQuest
how does a keyring die??
8:37 AM
reosarevok
I mean, I used it for like half a year and it was in my pocket every day :)
8:38 AM
CatQuest
wait a wooden keyring? aren't those usually metal with optipnal dangly bits
8:39 AM
reosarevok
8:39 AM
The dangly bit was the problem :)
8:39 AM
The hole is very close to the edge, and that small strip in between just eventually broke
8:39 AM
CatQuest
yea. woddis not a good material for keurings
8:39 AM
anshuman73
okay, that is one really nice keyring
8:40 AM
CatQuest
atleast without some kind of metal reenforchment
8:41 AM
reosarevok
I guess it'd be hard to use a reinforcement while still making it with the fancy cutty machine
8:41 AM
But I feel if the hole was a biiit further down, it would be much more resistant
8:41 AM
CatQuest
rob has a fancy 3-d printer, no?
8:41 AM
reosarevok
I also have no clue how materials work though :D
8:41 AM
CatQuest
tsk
8:42 AM
outsidecontext joined the channel
8:42 AM
yvanzo
reosarevok, bitmap: is it a nice day for beta release?
8:42 AM
reosarevok
Possibly?
8:42 AM
I have no idea how releases work
8:42 AM
CatQuest
depends, how much are you gonna wreck this time? ;)
8:43 AM
reosarevok
It has a lot of my code, so god only knows
8:43 AM
yvanzo
Let me know which standalone PRs could still be merged today :)
8:43 AM
reosarevok
yvanzo: I would like to try doing one at some point myself, but today I'm going to the countryside again etc
8:43 AM
Unless you want to do it now :)
8:44 AM
CatQuest
wait. reosarevok doesn't know how releases work?!?
8:44 AM
8:44 AM
:D
8:44 AM
reosarevok slaps CatQuest with a trout
8:44 AM
:D
8:44 AM
fish!
8:44 AM
CatQuest noms
8:44 AM
yvanzo
Would be nice to have it done today so as to bring beta cycle back.
8:45 AM
CatQuest: nice one :)
8:45 AM
CatQuest
idk, cna you guys update test any time soon?
8:45 AM
with the new search for example etc
8:45 AM
yvanzo: :D
8:46 AM
yvanzo
reosarevok: if we get back to beta cycle, you will have the opportunity to do a release yourself every week :)
8:46 AM
CatQuest
oh no
8:46 AM
reosarevok
You mean every two weeks?
8:46 AM
Or ok, one beta one prod
8:46 AM
Sure
8:47 AM
Anyway, yvanzo: today is good, if you have the time. Is there something I can / should do?
8:47 AM
I'll check prs for a sec
8:47 AM
yvanzo
ok, thanks
8:47 AM
reosarevok
The sidebar ones are small
8:54 AM
8:54 AM
8:55 AM
8:55 AM
8:56 AM
8:56 AM
But none are super urgent or anything
8:56 AM
CatQuest: update test yes, with the new search dunno
8:56 AM
yvanzo
Yeah but we won’t be able to merge any during beta, so better take small fishes for now.
8:56 AM
reosarevok
AFAICT updating test is easy, but changing it to use SOLR might not be? yvanzo would know
8:58 AM
alastairp
iliekcomputers: thanks for the dump
9:00 AM
yvanzo
reosarevok: Why do we have both schema-change-2018-q4 and schema-change-2019-q2 branches? Shouldn’t the first one be renamed into the second one?
9:00 AM
reosarevok
Maybe? Probably? Ask bitmap :D
9:01 AM
yvanzo
schema-change-2018-q4 has never been released but still contain required changes for the next schema change release
9:01 AM
reosarevok
He said we didn't have a branch to point my PR into, so he created one
9:01 AM
BrainzGit
9:01 AM
BrainzBot
9:02 AM
reosarevok
9:02 AM
Oh, wait
9:02 AM
Commit message
9:02 AM
Ok, let me see
9:06 AM
yvanzo
reosarevok: Sorry I wanted to approve 989 instead of 999
9:06 AM
reosarevok
I got that, I was just trying to figure out what was missing because the code issues were fixed
9:06 AM
And then realized the commit message bit was left
9:06 AM
Gazooo joined the channel
9:06 AM
yvanzo
reosarevok: see GCIers commit messages for example ;)
9:07 AM
reosarevok
I'm always a bit confused about commit messages vs. PR messages vs. JIRA tickets
9:08 AM
9:08 AM
That ok? Specific examples are in the tests, but I guess I can add them there if needed?
9:09 AM
yvanzo
reosarevok: also remove subdomain and allow for +artist
9:09 AM
reosarevok
+artist was always allowed, I changed nothing there :)
9:09 AM
9:10 AM
yvanzo
I mean it was not specifically taken into account
9:10 AM
reosarevok
Ok I guess
9:10 AM
yvanzo
Btw, now that there is a 'clean' function, maybe the 'validate' function should allow clean URLs only.
9:13 AM
reosarevok: I prefer to wait for PR authors to merge their own PRs, just in case they have other changes in mind.
9:13 AM
reosarevok
Sure
9:13 AM
yvanzo
Anyway, I will probably make beta release in the evening only.
9:15 AM
reosarevok
yvanzo: how do we generally do the validate thing?
9:16 AM
(validate only if clean I mean)
9:16 AM
yvanzo
9:16 AM
reosarevok
Or do you just mean check it matches https:\/\/secondhandsongs\.com\/\w+\/[\d+]+ ?
9:16 AM
Sure, I just want to understand what that means
9:16 AM
yvanzo
it’s the same thing?
9:17 AM
reosarevok
Just means changing const m = /secondhandsongs\.com\/([a-z]+)\//.exec(url); to a more specific cleanup?
9:17 AM
eh. more specific *regex*
9:18 AM
yvanzo
more specific, as in, validate that URL is standardized
9:18 AM
reosarevok
So, const m = /^https:\/\/secondhandsongs\.com\/(\w+)\/[\d+]+$/.exec(url); ?
9:19 AM
yvanzo
yup :)
9:20 AM
reosarevok
9:21 AM
9:21 AM
That one we should try to merge
9:22 AM
9:23 AM
9:27 AM
9:28 AM
yvanzo
I did not get the comment about align-right, is it "generic" as in for every column?
9:29 AM
reosarevok
No, generic as "use this class for everything that should have right-align"
9:29 AM
We also have, say:
9:29 AM
9:32 AM
Also this:
9:32 AM
9:33 AM
Everything else for that seems to be barcode
9:38 AM
akhilesh joined the channel
9:40 AM
yvanzo
reosarevok: ok, added comment to the PR.
9:40 AM
letaiv joined the channel