#metabrainz

/

      • Lotheric_ is now known as Lotheric
      • D4RK-PH0ENiX has quit
      • Lotheric has quit
      • Lotheric joined the channel
      • Lotheric has quit
      • D4RK-PH0ENiX joined the channel
      • Lotheric joined the channel
      • Lotheric has quit
      • Lotheric joined the channel
      • CallerNo6 joined the channel
      • CallerNo6 has quit
      • CallerNo6 joined the channel
      • Cyna
        reosarevok: what does // mean ?
      • $split //= '';
      • Im trying to convert Diff.diff_side
      • reosarevok
        Wasn't that the stuff bitmap told you he was already converting?
      • tykling_ is now known as Tykling
      • Cyna
        Ohh he was... Didn't know
      • So now what do I do ?
      • They are used in the .TT file and for converting to React completely I need them
      • Guess I'll wait till it's done
      • Let me know if you have any other suggestions
      • D4RK-PH0ENiX has quit
      • reosarevok
        Cyna: he might have a commit you can use. Did you already finish add_remove for alias?
      • Cyna
        I made conversions for edit_alias
      • D4RK-PH0ENiX joined the channel
      • I'll also convert the other part for add and remove alias
      • CatQuest
        brb
      • CatQuest has left the channel
      • Lotheric_ joined the channel
      • Lotheric has quit
      • CatQuest joined the channel
      • CatQuest has quit
      • CatQuest joined the channel
      • Cyna
        what is html and locale vars ?, are they passed in from controller ?
      • reosarevok
        I mean, bitmap has told you like three times to start with add_remove. Your life would be easier if you listened to him :)
      • html is another filter. IIRC you don't need it on React because React escapes html by default, but confirm with bitmal
      • *bitmap
      • You can start the conversion without it and add something if he tells you you need something :)
      • Cyna
        I couldnt understand what he meant at that time 😅
      • reosarevok: I finished converting the add_remove_alias.tt. How do I test it ?
      • reosarevok
        Did you add the edit_template_react to the appropriate Server/Edit files?
      • If so, I think you can just add or remove an alias and then look at the edit it generated
      • Cyna
        what is edit_template_react ?
      • I didnt do it I guess
      • reosarevok
        Look at https://github.com/metabrainz/musicbrainz-serve... again and follow that general idea then
      • If your edit controller has booleans then you should use boolean_to_json like on that PR too :)
      • Cyna
        I'll have a look. Thanks :)
      • in my case I should edit `lib/MusicBrainz/Server/Edit/Alias/Add.pm` and Delete.pm , right ?
      • reosarevok
        Yes, I think so :)
      • Cyna
        I made the changes for Add.pm
      • Testing it now
      • when you have time please test my changes
      • I've only made changes to Add.pm for now
      • Im getting a weird error while testing
      • reosarevok
        What's the error?
      • reosarevok is writing some code, maybe can test myself later, but might be able to help with the error sooner :)
      • Cyna
      • Rendering issue but I dont know why did it occur... I followed steps clearly
      • reosarevok
        Cyna: did you add it to server/components?
      • (not sure why that's not on that PR actually, but it's in that file)
      • Cyna
        no should I ?
      • The PR you sent me didnt have the changes
      • And the other files dont have their respective paths either so didnt add it there
      • should i
      • ?
      • reosarevok
        Yes, you should
      • For files that get used in React.Embed you need that
      • I'm really confused why that wasn't in that PR
      • Lotheric_ is now known as Lotheric
      • Cyna
        Made the changes that fixed the issue
      • Now Im comparing it with tt counterpart and checking logical errors
      • Lotheric
      • question from ijabz
      • anyone know ?
      • Cyna
        reosarevok: what does this do ?
      • I've commited the latest changes to my remote branch... Its working fine except there are some rendering bugs
      • Issue in rendering after `Sort name`
      • reosarevok
        Cyna: " what does this do ?" what this? :)
      • Cyna: also, you have td and/or tr instead of th there
      • Also, you have begin_data instead of begin_date :)
      • But yeah
      • Original had th for the first of those
      • Should be th, then td
      • Etc :)
      • Cyna
        Ohh will have a look in sometime
      • Thanks :)
      • rdswift
        zas, I see that outsidecontext isn't around. Do you have any comments regarding https://community.metabrainz.org/t/picard-porta...
      • zas
        rdswift: not really, it seems tickets exist, and patches are welcome ;)
      • rdswift
        Okay, thanks.
      • zas
        it should be noted there's a command line option to select a different config file
      • and there's a ticket somewhere about "profiles"
      • rdswift
        Thanks again. I responded in the discussion with this information.
      • candyman joined the channel
      • candyman
        hey I'm trying to do some setup/eval of MB and I'm not sure if I'm taking the right route to achieve my goals...
      • anyone around that could answer a few basic questions?
      • Cyna
        reosarevok: Is there some other way i can write this ```IF !edit.display_data.begin_date.is_empty ```
      • reosarevok
        candyman: yes, ask
      • Cyna: I can check in a bit
      • Cyna
        sure thanks
      • candyman
        so the application I'm building is going to both need to pull artist genres (tags) rapidly, and will also be producing new data in the form of artists and their associated genres
      • reosarevok
        Cyna: that means " return !(defined $self->year || $self->month || $self->day);" (so it's empty if it's missing those three) FWIW
      • candyman
        so my 1st thought is that I would use the musicbrainz-api to both submit new data and pull new data rapidly
      • Cyna
        If possible, is there an easy to understand answer
      • 😅
      • candyman
        however the rate-limiting info says that only python-musicbrainz/0.7.3 gets a special limit of 50/sec - would that be true of the node version 'musicbrainz-api' as well?
      • that is, my application - if implementing the musicbrainz-api - could pull at 50/sec?
      • reosarevok
        candyman: I didn't even know we allowed someone to use 50/sec - I thought it was 1/sec for everyone
      • But I might be misremembering something :)
      • candyman
      • and that the IP address limit of 1/sec trumps the user-agent
      • reosarevok
        Cyna: actually: import isDateEmpty from '../static/scripts/common/utility/isDateEmpty';
      • Seems to be a thing already :)
      • Cyna
        ohh
      • reosarevok
        candyman: oh, yeah, that's us *blocking* some agents
      • (more than usual)
      • Because they're associated with bad usage
      • candyman
        so if I needed to make fast requests for MB info - there is no API option for this? I would need to setup my own server to peg at my leisure?
      • I don't need anything crazy but resolving one artist/sec is . . not ideal
      • reosarevok
        In general, yes. What's the use case? (can't they be done only once and then cached until needed again?)
      • candyman
        its resolving giant batches of artists that come from different sources - spotify playlists, songkick event listings, etc - almost on-demand
      • Cyna
        if possible please help me making a PropType for AddRemoveAlias
      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1083 (master…MBS-9918): MBS-9918: Convert the label public pages to React https://github.com/metabrainz/musicbrainz-serve...
      • BrainzBot
        MBS-9918: Convert the label public pages to React https://tickets.metabrainz.org/browse/MBS-9918
      • Cyna
        Its functioning perfectly now I'm adding flow to it
      • reosarevok
        candyman: how are you planning to do it? :)
      • (say, if you get "Nirvana", how will you map it to the right Nirvana artist)
      • candyman
        magic. no lol unfortunately Echonest's Rosetta stone isn't a thing anymore - so resolving Spotify -> MB has been hard but not impossible. I look at their albums and such
      • Songkick fortunately uses MusicBrainz ids so I can map directly a lot of the time
      • reosarevok
        I mean, for some artists we might have the Spotify ID on our side for example, but sadly we don't have anywhere as many as I'd like
      • candyman
        right. but assuming I could figure out that link, sounds like setting up a server - which OMG
      • the indexing has ended, dear lord that took some time
      • I as of just now have a server setup w/out replication
      • reosarevok
        Setting up a server might be the easiest way, yes, unless you can figure good ways of doing cache on your side
      • candyman
        alright so part 2 (sorry, you've been a great help, theres no part 3)
      • reosarevok
        Is this supposed to be mostly for yourself, or a bigger service? :)
      • candyman
        I don't plan on distributing the service super widely, a passion project
      • reosarevok
        If you're going to hammer your own server yourself (or with some friends) it probably doesn't matter, but if it'll be a bigger thing you're likely to want some caching anyway :)
      • Part 2? :)
      • candyman
        I feel that, thank you. I have an idea already for how to cache the event lookups - just let people 'think' their looking at live data...
      • reosarevok
        Tbh we don't get new tags that often, at least not yet
      • Although we'd love to change that, heh. Maybe if ListenBrainz takes off :)
      • Cyna: re: props, what do you have now?
      • candyman
        anyways, the new data that I submit. I find that Spotify and MB don't have any genre info, but I manage to figure it out some new genres from other sources
      • reosarevok
        Look at the display_data, you'll need to give that proper types.