#metabrainz

zarcade_droid: not at the moment, because BookBrainz is already taking long enough as it is

Moooin!

mo’’in’

An hour outside Madrid. WiFi on planes is still odd to me.

Moin o/

spellew: ping o/

mo'in

ferbncode: spellew opened a pr for brainzutils, in case you missed it

bukwurm: o/

iliekcomputers: Hey

How are you doing, iliekcomputers ?

iliekcomputers: yes, I did see the pull request. I just wanted him to ask him to create small subtickets for https://tickets.metabrainz.org/projects/CB/issu... as he progresses. I think it would be good if we see small tasks going from in progress -> released. What do you think? (We would then ping you often for releases)

CB-270: Add support for reviewing (or atleast rating) more entities

Moin!

ferbncode: that sounds really good

bukwurm: pretty good, how about you?

I am doing great. How all mentoring stuff going? You are a mentor this time as well right?

Not officially

Ah, ok

iliekcomputers: cool :)

Hi bukwurm !

Mr_Monkey: How are you doing? :)

Long time n see! Very good! How about yourself!

?

I am doing great :)

How's all the gsoc work going? :)

Only properly started last week, but it's going good so far :) I'm excited by the prospect of an API !

How goes the school year bukwurm ? Are you out of the woods yet or still have exams?

I am also very excited for the project

I have been out for an year now 😆

Ah shucks, I thought you still had a year !

Confused Monkey !

What have you been up to?

Just working, building stuff

Anyways, Monkey I was thinking of finishing off the import project

Ah, sweet, making your own Summer of Coding ? :D

Haha

That would be awesome

Do you think you would be available for a short meeting this week?

Yep !

At your convenience any day before 6PM CET

Sure. I have a couple of proposals - would like to discuss and get on a common ground

Great, I love options!

How does 5PM CET tomorrow sound?

I'll soon deploy a new openresty version on gateways, I'll switch to herb temporarily in few minutes.

bukwurm: Can you do 4PM CET?

Mr_Monkey: Sure, sounds good

👍

So where have you been working at bukwurm ?

I have been working for a startup called Quizizz based out of Bangalore.

It's an ed tech platform, and used almost in 50% schools in US, with around 20M+ active monthly users :)

Nice ! Enjoying working there?

Mr_Monkey: I am confused with the common section, because api requirements completely different from the website now. May I place whole api code in src/api and remove common section?

Doing JS?

Yeah, it's been great. Working with mostly JS, yeah. Would love to apply some of the stuff I have learnt here for BookBrainz.

akhilesh: Hi! It's still early in the project; I assume some utility functions will be the same as the server code. However, you can refactor it at a later point. I would suggest leaving the common folder for now, and removing it only later if there is really no common code at all.

Good idea!

akhilesh: As an example the src/server/helpers/auth file contains some code that will likely be a good candidate for common code

Mr_Monkey: A short gist of what I'll be discussing is shifting importer(consumer) as a separate micro-service connected to queue. With an api, we can then even open up importer for general use. Also, getting rid of some old code in favor of worker threads now stable in v12.

I am especially looking forward to v12 LTS with will end transpilation and have stable worker threads

It'll be stable this October

Ok, that sounds like good improvements, and likely to make a difference in processing time

Great

switching to herb now

Looking forward to our meeting tomorrow :)

Yep ! :)

switching back to kiki

Mr_Monkey: May you look my last commit please? have problem with inserting data in test_db

akhilesh: I was actually just running the test :) Generally, it would be helpful if you gave more information about the issue you encounter, and possibly error logs if applicable.

Do you know what the issue is?

some foreign key violation in bb.identifier table

That usually means the row you are trying to create requires a piece of information you haven't provided

I'm currently struggling to run the test, but I'll have a closer look when I manage to get them to run right

this is mine error, is same on you Mr_Monkey ?

akhilesh: Yep, same error

In this case, it looks like you are creating an Identifier without setting typeId

(Which also means you need the IdentifierType in question to exist)

That's how you read that error message. `violates foreign key constraint "identifier_type_id_fkey"` means you are missing that required column

And that the type_id must relate to an existing identifier_type_id

should I pass both typeId and identifierTypeId with identifierData?

Mr_Monkey: ^

akhilesh: typeId is sufficient, but should refr to an existing IdentifierType.

So you'll need to create an IdentifierType with id:1

Ok, Is your debugger working for api tests Mr_Monkey ?

If running fine, please share task.json and launch.json

akhilesh: yep, working fine, posting below:

iliekcomputers: hi, are you around today?

alastairp: yep, around right now.

cool. for how long?

~1.5-2 hours

great. give me 45 minutes and then let's do a release?

sounds good to me

to prepare, can you run that management command again? to update submission offsets

it should be finished by the time I'm ready

hmm, yeah, sure.

command running again.

63481 items

zarcade_droid: https://community.metabrainz.org/search?q=video... has the latest on a "MovieBrainz", AFAIK.

[acousticbrainz-server] alastair merged pull request #340 (master…ab-406-2): AB-406 Part 2: Offset for missing entries, offset computed on submission https://github.com/metabrainz/acousticbrainz-se...

AB-406: Add column representing submission offset https://tickets.metabrainz.org/browse/AB-406

iliekcomputers: I've pushed step 2 to master

the deployment process will be: 1) take down website, 2) run management command one final time, 3) confirm that there are no rows with null submission_offset, 4) bring up again

aidanlw17: can you rebase part 3 against master again?

aidanlw17: this PR should also remove the management script to populate the offsets

this seems ot be that release right? https://www.discogs.com/Delibes-Natalie-Dessay-...

erm wrong window lol