0:04 AM
D4RK-PH0ENiX has quit
0:10 AM
Wizzup has quit
0:14 AM
Delemas
0:17 AM
Wizzup joined the channel
0:23 AM
D4RK-PH0ENiX joined the channel
0:23 AM
D4RK-PH0ENiX has quit
0:24 AM
D4RK-PH0ENiX joined the channel
0:25 AM
Wizzup has quit
0:25 AM
Wizzup joined the channel
0:30 AM
Wizzup has quit
1:02 AM
Nyanko-sensei joined the channel
1:06 AM
D4RK-PH0ENiX has quit
1:07 AM
Wizzup joined the channel
1:11 AM
ephemer0l has quit
1:11 AM
ephemer0l_ joined the channel
1:26 AM
Nyanko-sensei has quit
1:27 AM
D4RK-PH0ENiX joined the channel
1:31 AM
Wizzup has quit
1:48 AM
Wizzup joined the channel
2:03 AM
G0re joined the channel
2:06 AM
Gore has quit
2:10 AM
Wizzup has quit
2:16 AM
Wizzup joined the channel
2:23 AM
Wizzup has quit
2:24 AM
Wizzup joined the channel
2:32 AM
Wizzup has quit
2:47 AM
Wizzup joined the channel
2:48 AM
BestSteve has quit
2:50 AM
BestSteve joined the channel
2:53 AM
Wizzup has quit
3:09 AM
Wizzup joined the channel
3:17 AM
Lotheric has quit
3:18 AM
Lotheric joined the channel
3:18 AM
Wizzup has quit
3:31 AM
Wizzup joined the channel
3:44 AM
Wizzup has quit
3:48 AM
Wizzup joined the channel
4:40 AM
Wizzup has quit
4:47 AM
Wizzup joined the channel
5:05 AM
yvanzo
mo’’in’
5:43 AM
Lotheric_ joined the channel
5:43 AM
Lotheric has quit
6:14 AM
Gore|work joined the channel
6:15 AM
G0re has quit
6:56 AM
Nyanko-sensei joined the channel
6:58 AM
D4RK-PH0ENiX has quit
7:55 AM
ruaok
mooin
7:55 AM
massive thunderstorms rolling over the city today...
7:59 AM
zas
mo'in
8:00 AM
amCap1712
hi zas
8:00 AM
i had opened a few tickets as discussed. can you take a look at those?
8:01 AM
PICARD-1551 , PICARD-1552, PICAD-1553
8:01 AM
BrainzBot
8:01 AM
8:01 AM
amCap1712
PICARD-1553
8:01 AM
BrainzBot
8:02 AM
zas
amCap1712: yes, I saw, thanks we'll have a look soon
8:02 AM
amCap1712
yeah, that would be great
8:07 AM
pristine__
ruaok: hey!
8:08 AM
ruaok
hi!
8:10 AM
pristine__
Our next goal is to get recommendation on Lemmy and test on beta?
8:11 AM
ruaok
yes.
8:11 AM
pristine__
Okay.....What should be the approach?
8:12 AM
Nyanko-sensei has quit
8:13 AM
D4RK-PH0ENiX joined the channel
8:15 AM
gr0uch0mars joined the channel
8:28 AM
MajorLurker joined the channel
8:47 AM
BrainzGit
9:36 AM
alastairp
iliekcomputers: good morning, how are you for looking at https, ratelimiting, and init?
9:36 AM
today, or tomorrow?
9:41 AM
ruaok
pristine__: let me get caught up on the work you've done last week.
9:41 AM
9:42 AM
I feel that this is a bit too specific for the things that have developed since you opened that PR....
10:48 AM
reosarevok
yvanzo, bitmap
10:48 AM
10:48 AM
BrainzBot
MBS-3871: Flag URLs with inappropriate content
11:26 AM
pristine__
ruaok: yes agreed #578 needs a lot of changes.
11:26 AM
ruaok
maybe close it for now?
11:26 AM
pristine__
Yup
11:26 AM
I will close it.
11:26 AM
ruaok
I think a good first intermediary step is to store the data CF tracks into a new schema on lemmy.
11:26 AM
Lotheric_ is now known as Lotheric
11:27 AM
iliekcomputers
alastairp: morning, I haven't gotten to redirects now. Let me work on that, we can do a release today
11:27 AM
pristine__
How should the schema look?
11:27 AM
Two different col/fields for two playlists.
11:28 AM
ruaok
well right now they should not even be playlists, but just tracks.
11:28 AM
pristine__
Yes, my bad. Tracks.
11:28 AM
iliekcomputers
ruaok: I've been testing incremental dumps over the past week. I think they should be ready for release after this batch of PRs.
11:28 AM
ruaok
iliekcomputers: great. I'm trying to touch up the last bits on the quickbooks stuff so that can finally be merged.
11:29 AM
after that i'll circle back on PRs
11:31 AM
pristine__: I guess the schema might be: row id, user id, track id, last_used (timestamp)
11:31 AM
that way when we use the track, we can keep track of it having been used for a playlist, so we don't overuse it.
11:33 AM
BrainzGit
11:38 AM
pristine__
ruaok: so we will need to remember the timestamp in Spark when the track was displayed on beta for user to listen, and if the last used is greater than this timestamp, it means user has listened to the track, other wise not.
12:00 PM
iliekcomputers
how will you get the timestamps to spark?
12:07 PM
ruaok
my plan wasn't to make spark aware of timestamps.
12:07 PM
I was hoping we can generate loads of tracks and store them in lemmy and keep timestamps there.
12:10 PM
pristine__
Umm.... Okay. CF spark will just generates loads of tracks and Lemmy will do the other work ( keeping track of tracks listened to by user etc.)
12:11 PM
ruaok
yep. let's hope that works for now. if we need to feed back which tracks have been used, we'll do that later.
12:12 PM
iliekcomputers
alright.
12:12 PM
pristine__
Cool.
12:15 PM
gr0uch0mars has quit
12:25 PM
iliekcomputers
>There are other GET methods here that we shouldn't redirect on either.
12:25 PM
alastairp: which ones are those exactly?
12:48 PM
alastairp
iliekcomputers: I was thinking about the legacy endpoints
12:50 PM
iliekcomputers
Right, all of them, I guess?
12:50 PM
alastairp
I'm not sure if it makes sense to keep them http-only, or just go ahead and do everything except legacy POST
12:51 PM
iliekcomputers
Would redirecting break clients?
12:51 PM
alastairp
it has the potential to break POSTs, which is why I don't want to do it, but I'm not sure about the GETs
12:52 PM
especially since you added the exception to the whole api
12:53 PM
if the legacy endpoints are part of the api, then it makes sense to exclude those too
12:54 PM
iliekcomputers
Hmm, yeah.
12:54 PM
Let's not redirect for all of them
12:56 PM
alastairp
12:57 PM
I wonder if there's a version of that which will tell us the blueprint of the view too
12:57 PM
iliekcomputers
I guess adding exceptions for this will be harder, there's no prefix
12:58 PM
alastairp
there's no prefix, but it's in a separate blueprint
12:58 PM
iliekcomputers
Oh, you're looking at the same thing, great minds ;)
12:58 PM
Lemme take a look
13:02 PM
alastairp
13:02 PM
> The endpoint for the :func:`url_for` function is prefixed with the name of the blueprint.
13:02 PM
at the very least, we might just be able to do that - "if urlfor-name.startswith("blueprint.")
13:04 PM
ah - I just noticed also that there are specific blueprint before_request handlers... does that make sense?
13:07 PM
iliekcomputers
That sounds nicer
13:07 PM
alastairp
we have quite a few regular BPs, though
13:14 PM
iliekcomputers
I was thinking of overriding it somehow for the API blueprints, but the startswith thing is probably less complicated and less work
13:20 PM
alastairp
setting a global one and then overriding it for the api one sounds a bit difficult/complext
13:20 PM
mmm, so. additionally: if you're in a request context, `request.blueprint` is the text name of the blueprint
13:20 PM
no need for any lookups. just match against a string
13:23 PM
BrainzGit
13:23 PM
BrainzBot
13:59 PM
iliekcomputers
alastairp: zas: what was the header to check to see the original protocol from flask? `X-Forwarded-Proto` is None
14:00 PM
alastairp
that's what it should be. maybe it's not set properly on beta?
14:00 PM
BrainzGit
14:00 PM
BrainzBot
14:00 PM
14:02 PM
iliekcomputers
14:03 PM
14:08 PM
alastairp
if everything else does and just that one doesn't, I'd say it's an oversight
14:10 PM
D4RK-PH0ENiX has quit
14:11 PM
iliekcomputers
i'm not sure, i haven't really used that header
14:19 PM
CallerNo6 has quit
14:20 PM
yvanzo
reosarevok: it is clearly not top priority, but I wouldn't mark it as won't fix, just found it is related to MBS-6686 btw.
14:20 PM
BrainzBot
14:21 PM
iliekcomputers
alastairp: request.url contains http and https correctly, from me seeing. I think it's because right now we only have the one container for the webserver, gonna need zas to confirm
14:27 PM
D4RK-PH0ENiX joined the channel
14:51 PM
alastairp: if you're around, we should release ratelimiting today, i'm don't think this will be ready today.
15:03 PM
not sure why it's redirecting in tests, wtf. i'm gonna look at this tomorrow, this is a bit irritating.
15:11 PM
BrainzGit
16:27 PM
Cyna
bitmap: I need help sorting out flow errors in taskOne branch. After that I could continue my work with place entity