1:30 AM
Nyanko-sensei joined the channel
1:33 AM
D4RK-PH0ENiX has quit
1:38 AM
nav2002__ joined the channel
1:42 AM
Nyanko-sensei has quit
1:43 AM
D4RK-PH0ENiX joined the channel
2:10 AM
Nyanko-sensei joined the channel
2:13 AM
D4RK-PH0ENiX has quit
2:17 AM
nav2002__ has quit
2:37 AM
Nyanko-sensei has quit
2:38 AM
D4RK-PH0ENiX joined the channel
3:32 AM
AfroThundr|main has quit
3:39 AM
ayerhart_ joined the channel
3:40 AM
ayerhart has quit
4:41 AM
chaban has quit
4:42 AM
chaban joined the channel
6:42 AM
BrainzGit
8:25 AM
chaban has quit
8:26 AM
djinni` has quit
8:30 AM
djinni` joined the channel
8:31 AM
nav2002_ joined the channel
9:06 AM
Gazooo joined the channel
9:37 AM
alastairp
aidanlw17: hi, tell me when you're in!
9:37 AM
I'm half way through reviewing your stuff
9:48 AM
jesus2099 joined the channel
9:56 AM
ruaok
moooin
9:56 AM
iliekcomputers: do you want to have a look at pr34 or should I go ahead and merge it?
10:00 AM
aidanlw17
Hi alastairp, I'm in now!
10:00 AM
alastairp
hi ruaok
10:00 AM
aidanlw17: great!
10:01 AM
just finishing some comments on the PR, I'll submit them and then we can talk
10:01 AM
aidanlw17
I'm sure it isn't too easy to review, as I keep working I keep finding different things to change
10:01 AM
sounds good! thanks.
10:07 AM
jesus2099 has left the channel
10:09 AM
alastairp
aidanlw17: OK, review done
10:09 AM
did you notice that the stats computation is really slow?
10:09 AM
I'm not sure I remember you mentioning this previously
10:13 AM
aidanlw17
Cool! Just looking through the comments now
10:15 AM
I think that I did notice that, not sure if I mentioned it
10:15 AM
nav2002_ has quit
10:17 AM
alastairp
there are lots of things that we can do to make it faster
10:18 AM
my gut feel is that we should be able to make it at least 1000x faster
10:18 AM
nav2002__ joined the channel
10:21 AM
aidanlw17
ok - that's good news! It takes a long time right now even on 1m recordings
10:22 AM
I'll work on making those changes today
10:23 AM
alastairp
nice
10:23 AM
I'll be around for about 3 more hours today, let me know if you have any questions
10:24 AM
the transaction stuff especially can be a bit annoying to get right
10:27 AM
aidanlw17
Yeah I agree, when to open the transaction is one area that I'm never 100% sure about
10:27 AM
Thanks, I will let you know!
10:28 AM
Did you get my message about the schema yesterday?
10:37 AM
alastairp
ah, yes! I saw it but didn't reply
10:37 AM
let me look at that
10:37 AM
BrainzGit
10:37 AM
alastairp
I'm going to try and review your custom parameter query method too
10:41 AM
Freso
10:41 AM
aidanlw17
alastairp: ok no problem.
10:41 AM
Do you mean AB-415?
10:41 AM
BrainzBot
10:43 AM
aidanlw17
Just so you know, I had some problems with keeping the branch history in check between AB-414 and AB-415. 415 is up to date with all the changes, but 414 is behind 415 - I made some changes to the index class etc. in 415 and have yet to move them to 414, although I think 414 is the right place to introduce them
10:43 AM
BrainzBot
10:44 AM
alastairp
sorry, unclear. I meant AB-404
10:44 AM
BrainzBot
10:44 AM
alastairp
ok, no worries about the merge issues. we can clear them up once we start merging things in order
10:44 AM
aidanlw17
Oh okay! Sounds good.
10:44 AM
alastairp
it's always fixable
10:45 AM
aidanlw17
Yeah for now, if you are looking at 414 or 415 ever, 415 is really up to date but not 414.
10:50 AM
BrainzGit
10:50 AM
BrainzBot
10:51 AM
alastairp
ok cool, once we merge 412 then we'll work out the plan of attack for the next ones
10:53 AM
Tykling has quit
10:54 AM
tykling joined the channel
10:57 AM
D4RK-PH0ENiX has quit
11:04 AM
Freso
11:05 AM
Wake of previous spam wave?
11:05 AM
ruaok
I think that was one of the first waves of spam account cleanups
11:07 AM
BrainzGit
11:08 AM
11:08 AM
Freso
ruaok: Yeah, I think so too, but it’s too long ago for me to remember accurately. :/ Ah well.
11:08 AM
BrainzGit
11:09 AM
11:17 AM
D4RK-PH0ENiX joined the channel
11:46 AM
outsidecontext joined the channel
11:52 AM
outsidecontext_ joined the channel
11:53 AM
outsidecontext has quit
11:53 AM
outsidecontext_ is now known as outsidecontext
12:35 PM
nav2002__ has quit
12:36 PM
iliekcomputers
ruaok: feel free to merge, I'm not sure if I'll look today
12:38 PM
nav2002_ joined the channel
13:05 PM
nav2002_ has quit
13:09 PM
nav2002__ joined the channel
14:05 PM
altarrel has quit
14:13 PM
kyan has quit
14:46 PM
BrainzGit
14:46 PM
ruaok
pristine__: ^^
14:53 PM
pristine__
<3
14:56 PM
nav2002__ has quit
15:00 PM
nav2002_ joined the channel
15:06 PM
BestSteve has quit
15:09 PM
BestSteve joined the channel
15:19 PM
outsidecontext has quit
15:23 PM
nav2002_ has quit
15:29 PM
BrainzGit
15:29 PM
BrainzBot
15:32 PM
Freso
15:33 PM
zas
Tools for moderating MB?
15:34 PM
reosarevok
You'd have to be kind of a tool to dedicate so much time to MB as I do, does that count?
15:41 PM
pristine__
ruaok: rebased #38 and removed conflicts
15:45 PM
djwhitey has quit
16:05 PM
BrainzGit
16:05 PM
BrainzBot
16:14 PM
Cyna
bitmap: the file in root/component/relationship-edittor.tt is the Ko file right ?
16:29 PM
yvanzo
16:32 PM
nav2002__ joined the channel
16:35 PM
alastairp
16:36 PM
I see there's an FMA importer script
16:43 PM
travis-ci joined the channel
16:43 PM
travis-ci
16:43 PM
travis-ci has left the channel
16:44 PM
reosarevok
alastairp: no, but I think the guess that the overlap isn't huge is good, unless someone has been going crazy with it
16:45 PM
alastairp
yeah
16:45 PM
16:58 PM
Cyna
bitmap: I've started working on the place entity, have completed the EditForm. KO part remains which I'll look into tomorrow :)
16:58 PM
chaban joined the channel
17:12 PM
I need some help understanding relationship-editor.tt file.
17:23 PM
reosarevok
17:23 PM
BrainzBot
MBS-5380: Contextualize further strings
17:23 PM
reosarevok
(and have new tickets for other strings that need this)
17:44 PM
reosarevok has quit
17:45 PM
amCap1712 has quit
17:45 PM
amCap1712 joined the channel
17:46 PM
reosarevok joined the channel
18:04 PM
bitmap
Cyna: great, let me know what questions you have
18:07 PM
yvanzo
reosarevok, bitmap: finding missing context is a task in se, thus a subtask of this ticket.
18:08 PM
reosarevok
But this ticket is useless in itself. "Further strings", whatever that means
18:08 PM
We should contextualize whatever we know needs it now, then close the ticket, then ask people to add other tickets if something specific is missing context, no?
18:08 PM
yvanzo
I agree, it is too vague, so finding which strings is required first.
18:09 PM
Developers are the most able to find which strings with similar content should have different context because of different meaning/intention.
18:13 PM
You can see it as a late code review focused on a particular point.
18:14 PM
(I know it seems to be boring to do, and that is probably why it has not been done yet.)
18:16 PM
bitmap
hrm, it doesn't seem like an efficient use of time to me, personally (I mean auditing every string in the message catalog)
18:17 PM
just so we can find out if some vague ticket is actionable
18:17 PM
yvanzo
It is not a current priority anyway.
18:31 PM
chaban has quit
18:36 PM
chaban joined the channel
18:43 PM
BrainzGit
18:43 PM
BrainzBot
19:05 PM
Gazooo has quit
19:22 PM
BestSteve has quit
19:22 PM
BestSteve joined the channel
19:51 PM
travis-ci joined the channel