0:04 AM
SothoTalKer has quit
0:05 AM
SothoTalKer joined the channel
0:13 AM
D4RK-PH0ENiX joined the channel
0:13 AM
D4RK-PH0ENiX has quit
0:14 AM
D4RK-PH0ENiX joined the channel
0:55 AM
ephemer0l is now known as landbrad
0:55 AM
landbrad is now known as ephemer0l
1:03 AM
SothoTalKer has quit
1:03 AM
djwhitey joined the channel
1:04 AM
SothoTalKer joined the channel
1:28 AM
Nyanko-sensei joined the channel
1:29 AM
D4RK-PH0ENiX has quit
2:31 AM
Nyanko-sensei has quit
2:31 AM
D4RK-PH0ENiX joined the channel
2:45 AM
travis-ci joined the channel
2:45 AM
travis-ci
2:45 AM
travis-ci has left the channel
5:18 AM
sahil_ joined the channel
5:19 AM
sahil_
Hey!
5:19 AM
I want to be a part of GSoC
5:19 AM
How can I start with it?
5:21 AM
Lotheric has quit
5:24 AM
Lotheric joined the channel
5:38 AM
sahil_ has quit
5:38 AM
sahil joined the channel
5:40 AM
nav2002__ joined the channel
5:48 AM
antfoo has quit
5:49 AM
antfoo joined the channel
5:59 AM
yvanzo
6:30 AM
sahil has quit
6:50 AM
sahil joined the channel
7:06 AM
D4RK-PH0ENiX has quit
7:07 AM
D4RK-PH0ENiX joined the channel
7:15 AM
travis-ci joined the channel
7:15 AM
travis-ci
7:15 AM
travis-ci has left the channel
7:55 AM
D4RK-PH0ENiX has quit
7:56 AM
D4RK-PH0ENiX joined the channel
8:17 AM
sahil has quit
8:53 AM
gr0uch0mars joined the channel
8:54 AM
gr0uch0mars
amCap1712: you could start by querying releases as a first feature, and keep expanding it go tracks in the future
8:54 AM
that way you can develop the basis for all the features we’d like to have
9:05 AM
NightGroove is now known as CatQuest
9:12 AM
travis-ci joined the channel
9:12 AM
travis-ci
phw/picard#121 (haiku-port-2.1.3 - b9e96ea : Philipp Wolfer): The build passed.
9:12 AM
9:12 AM
9:12 AM
travis-ci has left the channel
9:14 AM
amCap1712
gr0uch0mars: actualy i think querying tracks would be much easier
9:14 AM
i have done that currently
9:17 AM
also i am doing work on fingerprint
9:18 AM
also that bug i refered earlier is now fixed
9:20 AM
i will implement both the ways of tagging to matching tracks
9:22 AM
once thats done i'll work on writing tags to file
9:48 AM
nav2002__ has quit
9:49 AM
Freso
9:50 AM
BrainzBot
I will remember "pastebin.com" for you Freso.
9:50 AM
Freso
9:50 AM
BrainzBot
What was "pastebin.com" all about?
9:50 AM
Freso
9:50 AM
BrainzBot
I will remember "pastebin.com" for you Freso.
9:53 AM
nav2002_ joined the channel
11:02 AM
gr0uch0mars has quit
11:04 AM
iliekcomputers
I've been getting these weird mails with js code from jira
11:05 AM
ruaok
you too? any idea, yvanzo ?
11:05 AM
yvanzo
I guess these are from script kiddies trying to use an exploit on our contact form.
11:05 AM
This is the exact vulnerability that has been fixed last week.
11:11 AM
11:25 AM
ruaok
sounds like a good idea.
11:27 AM
yvanzo
done
11:30 AM
updating JIRA apps
12:12 PM
nav2002_ has quit
12:18 PM
nav2002__ joined the channel
12:47 PM
Sophist-UK has quit
14:16 PM
D4RK-PH0ENiX has quit
14:50 PM
D4RK-PH0ENiX joined the channel
14:59 PM
CatQuest
Freso: why did you forget and redo that pastbin thing?
14:59 PM
CatQuest didn't see any diff
15:07 PM
Sophist-UK joined the channel
15:14 PM
15:14 PM
BrainzBot
MBS-10290: fix documentation search
15:14 PM
CatQuest
(also bad name probably)
15:26 PM
reosarevok
I honestly have no idea
15:27 PM
Renamed at least :)
15:31 PM
yvanzo
Thanks!
15:44 PM
Cyna
bitmap: could you help me find the knockout files for relationship-editor.tt
15:46 PM
BrainzGit
15:46 PM
BrainzBot
15:48 PM
reosarevok
Cyna: the javascript for that is mostly under static/scripts/relationship-editor IIRC
15:49 PM
yvanzo
Cyna: knockout code for root/forms/relationship-editor.tt is in root/components/relationship-editor.tt
15:49 PM
reosarevok
Ok, yeah, and there :)
15:49 PM
Cyna
there knockout code is used but they vars used arent defined anywhere
15:50 PM
reosarevok
Then that's where I said
15:50 PM
yvanzo
the rest is root/static/scripts/relationship-editor/
15:51 PM
reosarevok
15:51 PM
yvanzo
Cyna: which variable for example?
15:51 PM
reosarevok
Sigh. Guess we're not trimming those very well
15:53 PM
15:53 PM
BrainzBot
MBS-2836: Trim annotations in database
15:59 PM
Cyna
the $data variable
15:59 PM
15:59 PM
Similarly there a few more knockout stuff in the file
16:03 PM
why does the script tag here have an id attribute ?
16:03 PM
16:03 PM
yvanzo: please help me figure out the above stuff
16:04 PM
yvanzo
16:07 PM
Cyna
so $data is used inplace of a foreach statement right
16:07 PM
?
16:08 PM
yvanzo
Cyna: script with id is a template that can be referred to render a dialog, see AddDialog and EditDialog in root/static/scripts/relationship-editor/common/dialog.js
16:13 PM
BrainzGit
16:13 PM
BrainzBot
16:14 PM
Cyna
yvanzo: In terms of React, I could say thats its a component right ?
16:15 PM
Its used for as templates by AddDialog and EditDialog
16:16 PM
yvanzo
Cyna: no, $data is not used in place of a foreach statement, it refers to the current view model object, that is either AddDialog instance or EditDialog instance here.
16:18 PM
Cyna: this script matches React rendering of a component.
16:18 PM
Cyna
Sorry I meant the template
16:18 PM
I was reading the <script> tag
16:19 PM
This could be converted to template and the data could be modified based on conditions
16:19 PM
*React Component
16:19 PM
$data could be replaced by a foreach statement
16:20 PM
yvanzo
yes about components, no about foreach statement ($data has nothing to do with it, read above)
16:22 PM
Cyna
I still dont get how I could remake the same in React :(
16:23 PM
yvanzo
Cyna: for example, every class in root/static/scripts/relationship-editor/common/dialog.js should probably be replaced with a React component.
16:23 PM
Cyna
$data refers to the objects model as you mentioned above, still done get how its doing so
16:23 PM
I'll have a look
16:23 PM
yvanzo
the content of the script tag should be used to write the 'render' function of these components.
16:25 PM
16:26 PM
16:34 PM
BrainzGit
16:34 PM
BrainzBot
16:34 PM
16:34 PM
16:41 PM
Cyna
reosarevok: could you please merge the PR related to my gsoc project to cyna-gsoc branch please
16:55 PM
yvanzo: ko.observable is similar to state in react right
16:55 PM
?
17:04 PM
Should I use React classes or I can also use react consts
17:04 PM
?
17:07 PM
I'm currently trying to set it up using react consts
17:07 PM
Lotheric
MBS-11203: Convert reosarevok to React
17:07 PM
:P
17:07 PM
reosareactavok!
17:08 PM
Cyna
🤣
17:20 PM
bitmap: what is this.widget ?
17:21 PM
How did the class get widget property, I dont find any good enough explanation on Google
17:23 PM
17:23 PM
if its a class props, how do I get it on react consts ?
17:29 PM
nav2002__ has quit
17:45 PM
CatQuest
is there any tool to easily convert rtf into html?
17:48 PM
nav2002__ joined the channel
18:16 PM
bitmap
Cyna: what are you working on right now? don't be trying to convert the relationship editor to React, because you'll never finish