Cyna: no, I literally just mean changing l('Name:') to addColonText(l('Name')) :)
(if we change all of those, then people won't have to translate both "Name" and "Name:" anymore)
Cyna
Ohh okay. Do you know how to solve the flow issuei mentioned above
reosarevok
DescriptiveLink does not return string
it returns a react element
(well, it *is* one)
I see DiffProps does call for string
So you should either allow for... was it React.Element or React.Node? I forget
Probably React.Node actually?
In those props, or if that seems wrong, have separate props for fulldiff that do allow string or React.Node
You should probably check with bitmap which of the two options seems better, since he wrote the diff code and he'd know better
Cyna
Well I guess he'll be online in about 10 hrs, I'll do something else in the meantime
reosarevok
Probably a bit less, but yeah
chaban has quit
pristine__
ruaok: The LB dumps right now are around 10G of size because listens from 2004 to 2019 are one place. People may only need listens of a particular year, we should have dumps of every year as well. And if someone wants listens of one specific month of a year, it is easy to download the dump of that year and get the listens of desired month rather than downloading the whole big dump.
I: added a new area. Then added a new place, using that area
Then changed the place to use another area
Then removed the first area
There will never be a case where the place's *current* area can be removed
But there will be cases where the history will show old areas, and those can be removed :)
Cyna
So its basically to keep the logs right. In real time its not possible but for history we ensure it is showing [removed]
reosarevok
Exactly :)
Cyna
Thanks
Now I guess only the flow issue remains
Then I guess 2 PR will be ready to be merged
reosarevok
I'll fix the bug I found, in the meantime, heh
Cyna
nice
chaban joined the channel
bitmap
reosarevok: I think removed entities will just have null for the gid. but RemovedCoreEntityT is hard to write (since CoreEntityT is a union type) which is why we haven't done it I guess
reosarevok
... why are you awake :p
bitmap
Cyna: any other parts you still need help with?
reosarevok
I mean, hi! :D
bitmap
because I went to sleep early, lol
Gazooo has quit
BrainzGit
[musicbrainz-server] reosarevok opened pull request #1240 (master…MBS-10432): MBS-10432 / MBS-10433: Block adding removal edits for areas that can't be removed https://github.com/metabrainz/musicbrainz-serve...
bitmap
I guess we should just define a LinkableEntityT in that file or something that encompasses all the entity types and has nullable gids
Do you have any suggestions / preferences on how it should look, since you asked for it? :)
chaban
Dunno. Maybe something like: "Please only use the rename option to fix e.g. typos. Do not use it if old name is used on releases. See Artist_Credits for more info"
you can’t coerce a react element into a string; if something expects a string where you’re passing a react element, you have to change the expected type
in FullChangeDiff right? the text props probably should be changed to “content” props (oldContent, newContent), and a hasChange prop added to override the default === comparison
since two different react elements will never be equal, but you can compare the area gids outside of the component and pass that in as hasChange
er no, it just outputs null in that case, so you can just perform the check outside