Hi prabal! You had questions about the revisions page ticket?
prabal
Yeah. For the pagination thing in revisions page , the way I'm doing is to change the numberofRevisions in the query to 'from+size', and then slice the array from 'from' to end. I'll get 'from' and 'size' from req.query. Can there be much better way than this because if 'from' is very high, the size of array will be large
Mr_Monkey
Let me have a look. You're talking about the query used on the server/routes/index.js page I assume?
prabal
Yeah. The same query will be used for the revisions page right?
CatQuest has left the channel
Mr_Monkey
prabal: Hmm. I'm definitely not an SQL pro, and haven't tried pagination methods. I'm not sure what the most efficient way of doing it is, but I'll read up on it, and suggest you do the same if you haven't already.
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
ruaok
Mr_Monkey: the easiest thing to do is to paginate sql queries
Mr_Monkey
My initial thought is using LIMIT X OFFSET Y, but you'd have to see if that remains efficient with a very big offset
ruaok
that.
Mr_Monkey
ah, good timing ruaok
Well, does that scale up nicely?
ruaok
postgres does well, yes. should be safe to use. but reosarevok, yvanzo and bitmap might have more insight to this as this is a common issue for MB as well.
Mr_Monkey
In any case, prabal, using LIMIT & OFFSET in the sql query seems like a good direction for a first implementation.
MBS-10547: Regression: "Reveal my email address" in editor reporting doesn’t do that
CatQuest
.. when does he remember by himself anything?
(not that i'm equally as bad at remembering but)
I'm not as*
Freso
(Just curious because I had expected you to assign yourself to it, but you still haven’t. :))
CatQuest
oh, also for the support on bookbrainz proposal freso. it looks less empty now (and with one interaction, maybe shy folks now will feel more at home doing it too!)
eh
"also *thank you* for the..
c1e0 has quit
c1e0 joined the channel
CatQuest is now known as BilleeKhoj
BilleeKhoj is now known as CatQuest
yokel has quit
c1e0 has quit
yokel joined the channel
BrainzGit
[bookbrainz-site] MonkeyDo merged pull request #335 (master…dependabot/npm_and_yarn/handlebars-4.5.3): chore(deps): bump handlebars from 4.1.2 to 4.5.3 https://github.com/bookbrainz/bookbrainz-site/p...
People up for reviews: reosarevok, yvanzo, zas, Mr_Monkey, Freso, pristine__, ruaok, bitmap, iliekcomputers, sbvkrishna, Cyna, CatQuest – anyone else, let me know ASAP!
reosarevok: Go!
reosarevok
Hi!
This week I dealt with GCI reviewing and otherwise had a Christmas / NY holiday
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GCI students start here: https://bit.ly/34O3FY8 | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews
Freso had beans for dinner before realising it was bean day 🤷
hipster :P
But it was not a disaster because there were other mentors on instrument tasks <3
(a little confusion about adding more task instances, but no matter :))
I hope gci does not go on during christmas next year. it's a bad idea.
In instrument adding ways it's still kinda dead. I've been playing pokémon shield, Let's go Pikachu and BotW :P
(guess what kind of handheld game thingy I got for my birthday :P)
Now it is back to work days however and I'm looking to mentor stuff. Got a couple tasks written up.
A specialised one for a model student and a couple that still needs a bit of work for BookBrainz. Hope to get monkey onboard for collaborating with those, and freso himself seemed to be interested in the audiobook one :D
Got a instrument blogpost written and waiting for the final instrument being done.
D4RK-PH0ENiX aka Nyanko-sensei has completed the IROM translation, so we (me and reosarevok) will soon send this email, so expect to se development in that field Soon™
CatQuest (and reosarevok and others): Be sure to write GCI team about not wanting it over Christmas. You can hope all you want, but if nobody actually tells their hopes/experiences to GCI team, they won’t know to adjust accordingly.