sarthak_jain: reviewing code on gists is difficult, also you should upload listens to HDFS on your local machine ( follow the steps I told shivam-kapila yesterday, he may guide you). Test your changes on your local environment first
Now testing doesn't mean pytest only. See if the output you are getting after running queries is desirable or not.
prabal has quit
ZaphodBeeblebrox joined the channel
CatQuest has quit
MusicbrainzB0T joined the channel
MusicbrainzB0T1 has quit
prabal joined the channel
sarthak_jain joined the channel
sarthak_jain
pristine__, I understand what you’re saying. But the thing is, if I am not making any changes, and just trying to run ‘pytest test_utils’, I face import error.
Even though I hve not made any changes to utils file yet.
Any reason for that?
c1e0_ joined the channel
pristine__
I am not sure because it's running fine on my local machine. Have you pulled lb-server master branch, so that you have recent changes
Labs repo has been merged into Lb-server
sarthak_jain has quit
c1e0 has quit
sarthak_jain joined the channel
sarthak_jain
Yes pristine__. Accidentally I had deleted the previous fork. So I forked it today and cloned on my machine.
And set the dev environment following the steps I did last time
only difference was I did not run the commands to setup databases
Just did ./develop.sh
sarthak_jain has quit
sarthak_jain joined the channel
I will check again in the evening and let you know
The good thing is the majority of the task has been done, I guess
sarthak_jain has quit
shivam-kapila joined the channel
shivam-kapila
pristine__: Hi. I followed the steps as you told
I am getting stuck at error `ftplib.error_perm: 550 failed to change directory.`
pristine__
shivam-kapila: I will ping you when I have a laptop nearby.
:)
shivam-kapila
I even did the `WRITE MODE=ON`
The error comes when I run `/usr/local/spark/bin/spark-submit spark_manage.py upload_listens`
pristine__: Cool :)
iliekcomputers: Hi. Did you have a look the new design I sent yesterday?
pristine__
shivam-kapila: can you please paste the complete error?
On gist
shivam-kapila
Sure.
iliekcomputers
shivam-kapila: not yet, I'll get back to you when I do
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, GSoC Ideas page (ruaok)
ZaphodBeeblebrox is now known as CatQuest
CatQuest
morn morn Mr_Monkey
thomasross has quit
thomasross joined the channel
Mr_Monkey
moin !
c1e0_ has quit
c1e0_ joined the channel
CatQuest
:D
wow I had a though. wat if there was a bot, or a botplugin that automatically submitted every link posted here (or in #musicbrainz) to the IA?
or like singh is the indian equivalent to "smith" or "olsen" :D
!m prabal singh
BrainzBot
You're doing good work, prabal singh!
CatQuest has left the channel
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
CatQuest
ah.. typing out the names of entities every time is a bore :'D
Mr_Monkey: we need to work on "10 recently used entities" in search dropdowns. really
for entities and languages and countries
one thing: so the title has a language that is mandatory (never midn if a person doesnt know what language the title might be in or that the title might be in a madeup language or just be a name ex)
then the *other* language field (which is totally optional)
what is that? for the text of the book right?
wouldn't it make sense to either: collate these so if one is filled the other is als ofilled (with the caveheat that exeptios *do* ocur but then what is the point of even having alanguage setting for the *title*)
how often does it ocur that a book is in one language but the title is in another?
and then is the language of the book's title really that important
Mr_Monkey
Language title is going to be important down the line, I think
I envision some use with localization for example
CatQuest
hmh..
Mr_Monkey
But it's also helpful for search
CatQuest
it's the thing about setting it twice. writing it twice
i think that by default if you will it in the othero ne shoudl be filled also
Mr_Monkey
As for how often a title and content aren't the same language, that's a good question. I know for sure it happens, maybe more often than we think
CatQuest
(we could put in a text to tell to make sure it is correct)
yea maye in aply named englsih book. but for instnace in norwegian translations. especially of osme years old. almost never
Mr_Monkey
There's those "?" icons that give a short explanation. You think it needs more?
CatQuest
I mean if we would implement a "fill in from title's language" button maybe
my grip is that I have to type "norw" (or engl") twice
Mr_Monkey
That des'nt seem too bad to me, frankly
CatQuest
and this for *every* single. entity.
it is. it gets old, really quick
i've got atleast 00 books (probably more) to add
eh
i've got atleast 100 books (probably more) to add
Mr_Monkey
Truthfully, it's the sort name i'd like to get rid of. It's hard for new users to understand and get right, and it doesn't seem useful to me. I think in BB it's currently completely unused
CatQuest
remember in mb: i cna jsut select them ost common one fro ma list
it's mandatory so it is used :D
but yes
also the "guess" button is bad. there shoudl be a "copy" button
Mr_Monkey
Well, that seems like a good solution to me. last 10 used or common ones at the top
CatQuest
indeed.
Mr_Monkey
Mandatory how?
CatQuest
that's also something I wrote in that docu i send you :D
you can't not fill in the sort name
jsut lie kyou can't not fill in the title language
it is red and x'ed
Mr_Monkey
Right, but we don't do anything with that data.
CatQuest
sure.
but we might at soem point
honestly
Mr_Monkey
I haven't been able to find one myself. Can you think of any?
CatQuest
when we had several languages the aliases and different named aliases on each language made sene. but we're not doing that anymore. so I don't relaly see the point of setting "language of title" (especially separate of "language of edition") when we do infact in ADDITION have "language of title of work" and "language of work"
we don't have "language of title" and "language of tracklist" separate in mb
(we have a language of work" (ie sung language))
in BB we can even sset severla langauges
why not just set language once and if. on the (honestly rare times?) when language of title != language of textof the book we can set a flag or a specia lbox then
Mr_Monkey
I think that would be a good improvement
Much simpler
CatQuest
:D
prabal
@CatQuest: haha no we're not related :P it's a common last name here xD
CatQuest
oh also, do we want really language of author's name? I mean, many names are not "norwegian" in origin . some are dutch or german. and how do you know if "pettersen" is danish or norwegian, really