hey _lucifer, are you planning on converting the app to React this summer of code ?
Mr_Monkey: is there any other reason that bookbrainz is being inclined to use Solr over Elasticsearch other than being native with other MeB projects ?
ishaanshah[m]
iliekcomputers: I am not sure if this is a threat but currently the LB's lastfm api key is revealed through react developer tools.
ishaanshah[m] uploaded an image: 2020-03-29-141554_1365x638_scrot.png (132KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/MXqyQATyXdYyZjNOWSTIdwKh >
_lucifer
Cyna: depends. stretch goal if time permits
ishaanshah[m]
I use a plugin
Dark-Reader
works, pretty well everywhere
rohitdandamudi joined the channel
c1e0_ joined the channel
c1e0 has quit
Gazooo has quit
madmouser1 has quit
ZaphodBeeblebrox joined the channel
ZaphodBeeblebrox has quit
ZaphodBeeblebrox joined the channel
CatQuest has quit
Sophist_UK has quit
iliekcomputers
ishaanshah[m]: yeah, that's a compromise we have to make. We've talked about it and are OK with leaking the key for now.
ishaanshah[m]
Ohk, I thought that it might bw risky
But how can it be fixed if we have to?
We will have to move the importer to backend right?
iliekcomputers
Yeah, which leads to copyright issues
ishaanshah[m]
Oh
iliekcomputers: Is the stats generation still running or something crashed, coz the stats on my page didn't change
iliekcomputers
I'll have to look, our spark setup is unstable
Maybe something broke
c1e0_ has quit
shivam-kapila
iliekcomputers: Afaik the delete a batch will be somewhat cumbersome. It says mixed indexing in shards prevents from deleting data. I am still looking for a solution.
Currently I found rebuilding indices and restart influx as a solution but that is not viable imo.
A possible reason could be version upgrade of influx due to which indexing changed.
iliekcomputers
shivam-kapila: at this point, it maybe easier to put the task in a queue and write a script that takes tasks from the queue and does them one by one
Influx is so bad jfc
shivam-kapila
Well it will be easier when switching to Timescale.
So putting the task in RMQ seems better
I will study about it. Thanks
Sophist-UK joined the channel
madmouser1 joined the channel
moufl has quit
madmouser1 has quit
madmouser1 joined the channel
moufl joined the channel
Sophist-UK has quit
madmouser1 has quit
madmouser1 joined the channel
madmouser1 has quit
madmouser1 joined the channel
scientist1642 joined the channel
scientist1642 has quit
scientist1642 joined the channel
madmouser1 has quit
ruaok
shivam-kapila: ping
sorry for the delay... I feel great today, but I am finding more things we need to address in your proposal.
`Next I will proceed with implementing changes in the RabbitMQ pipeline to exchange the new ratings data between listenbrainz-server and listenbrainz-spark.`
this isn't quite right.
shivam-kapila has quit
heh. I guess I'll make comments in the doc.
rohitdandamudi has quit
madmouser1 joined the channel
shivam-kapila joined the channel
shivam-kapila
ruaok: Hey. Sorry I was logged out at that time.
SothoTalKer_ joined the channel
SothoTalKer has quit
ruaok
np. I left comments in the doc.
shivam-kapila
ruaok: Thanks for that. I will start making the changes
SothoTalKer joined the channel
SothoTalKer_ has quit
Mr_Monkey
Cyna: Regarding Solr, it's mainly so that we can pool resources with the other MeB projects. It's much easier and saves resources to run only one standardised technology.
prabal: I saw! Now that's contribution !
prabal
About that search button text overflow bug, I saw you commented in Endurance's PR. I guess he'd want to make that change himself. I am not fixing it for now. It's not on priority right?
Speaking of search result, how would you prefer to see collection search result. 1. Showing collections search result in the main search page? 2. In the `All Collections` page, a separate search bar for collections.
ruaok
shivam-kapila: ping me when you're done, so we can iterate faster today.
shivam-kapila
ruaok: Okay I will.
anshuman73 joined the channel
Mr_Monkey
prabal: I think if in the future we want to make advanced search features it makes sense to be in a separate page.
SothoTalKer has quit
SothoTalKer joined the channel
heyarne[m]
the satistics on the acousticbrainz website are still from february. is that related to the problems with listenbrainz stats?
aside from main and beta, is there another set of listenbrainz servers (in particular, a test/sandbox one not connected to "production" data)? or am I required to run my own local server if i want to test submissions?
shivam-kapila: ^^ turned out well. I had to consult some other recipes for tips on what spices to start with.
shivam-kapila
ruaok: Looks yum.😋 Ohh I forgot to list the spices quantities. I will add that to the doc.
ruaok
thanks!
shivam-kapila
enjoy the meal. :)
thomasross joined the channel
ruaok: Modified the proposal. :)
Sophist-UK joined the channel
KrachbummNT has quit
Chinmay3199
Mr_Monkey: Ping!
Mr_Monkey
Chinmay3199: pong
Sophist-UK has quit
Chinmay3199
For increasing our code coverage I need to write test cases. So in short I have to make test cases for every needful function right? Mostly the ones there in src/server/helper
Mr_Monkey: correct me if I'm getting it wrong here
Mr_Monkey
Chinmay3199: Any function that isn't tested should be tested, in an ideal world
There's unit tests, and BookBrainz is in dire need of end-to-end tests as well
KrachbummNT joined the channel
Chinmay3199
That means I'd have to write as much cases as possible,sure. Thanks!