#metabrainz

/

      • chaban
        HenryG: Just approved it. :) Not all edit are automatically applied. See https://musicbrainz.org/doc/Introduction_to_Voting for more info.
      • HenryG
        chaban: Thanks!
      • ayerhart has quit
      • rohitdandamudi has quit
      • Chinmay3199 has quit
      • supersandro20003 joined the channel
      • supersandro2000 has quit
      • madmouser1 joined the channel
      • madmouser1 has quit
      • madmouser1 joined the channel
      • Sophist-UK has quit
      • madmouser1 has quit
      • madmouser1 joined the channel
      • madmouser1 has quit
      • madmouser1 joined the channel
      • djwhitey joined the channel
      • madmouser1 has quit
      • thomasross has quit
      • sweta05 joined the channel
      • IamDheerajS has quit
      • yvanzo
        mo’’in’
      • I did not find anything wrong with mb.o ws servers but these have likely been restarted a few hours ago.
      • sweta05
        hello all, here is my proposal for Storage for AcousticBrainz v2 data https://community.metabrainz.org/t/gsoc-proposa... ,it would be great to have valuable feedback from the community
      • rohitdandamudi joined the channel
      • Chinmay3199 joined the channel
      • prabal joined the channel
      • BrainzGit
        [bookbrainz-site] prabhleenkaur1007 opened pull request #400 (master…bb-445): fix(achievement): unnecessary badge GSoC 2016 https://github.com/bookbrainz/bookbrainz-site/p...
      • ZaphodBeeblebrox is now known as CatQuest
      • CatQuest
        hi shivam-kapila sorry
      • I've been afk for two days 😅
      • iliekcomputers: I'll make that ticket
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, April 1st? (catcat)
      • ishaanshah[m]
        ruaok: Hi!, can you have one last look at my proposal before I make the final submission
      • sweta05 has quit
      • iliekcomputers
        ishaanshah[m]: timeline looks better, well done.
      • feel free to submit.
      • ishaanshah[m]
        iliekcomputers: Thanks
      • sweta05 joined the channel
      • Gazooo joined the channel
      • madmouser1 joined the channel
      • iliekcomputers
        alastairp: will you have the time to look at sweta05's proposal?
      • ishaanshah[m]
        reosarevok: Hi, what exactly does X-RateLimit-Remain return in MB API
      • I thought it was the number of requests, that could be made, but the number doesn't decrease by one when I make a single request.
      • I wanted to limit the number of requests made by the importer using that.
      • iliekcomputers: What does LB return for the above
      • iliekcomputers
      • seems like AB returns number of requests remaining in the given time period
      • but the AB/LB ratelimits are different from MB
      • reosarevok
        ishaanshah[m]: I honestly don't know, I haven't touched the rate-limiting code
      • ishaanshah[m]
        Can you point me at the file which may have it
      • Livegrep doen't return anything from MB repos
      • alastairp
        iliekcomputers: yes, I'm looking at it now
      • iliekcomputers
        alastairp: awesome, thanks! :)
      • alastairp
        ishaanshah[m]: yes, AB and LB will be the same, but MB is quite different
      • ruaok
        ishaanshah[m]: is iliekcomputers is happy with the proposal, then I'm good as well.
      • iliekcomputers: have you looked at shivam's proposal one last time?
      • iliekcomputers
        haven't gotten the time, sorry.
      • ishaanshah[m]
        Oh, nice I will make the submission then, thanks iliekcomputers and ruaok.
      • iliekcomputers
        (happy to leave it with you, not sure i'll be able to give any actionable feedback before the deadline anyways)
      • ruaok
        ok.
      • I'll have one last read just in case then. thanks.
      • shivam-kapila joined the channel
      • shivam-kapila
        morning!
      • CatQuest: No worries I had gathered some data. I will ping if I need you help again. Thanks.
      • ruaok
        morning!
      • shivam-kapila
        Hi ruaok
      • CatQuest: Thanks. I just needed some huge amount of listens for testing. :)
      • CatQuest
        👍
      • shivam-kapila
        Just a thought. Isnt it a bit awkward that we can import anyone's Last.fm listens into our LB profiles by just knowing a username 🤔
      • iliekcomputers
        public store of data is public
      • shivam-kapila
        iliekcomputers: Oh. Thanks. I was gonna search about it.
      • iliekcomputers
        your listenbrainz data is available in the public domain for anyone to use too
      • shivam-kapila
        I knew about LB didnt know about Last.fm.
      • ruaok
        last.fm allows private scrobbles that a vast majority of people do not use. the founders of last.fm who helped with the hackathon launch of LB strongly advised us to not support private scrobbles.
      • shivam-kapila
        This is interesting!!
      • ruaok
        alastairp and I traveled to london to sit in the very large house of RJ to hack LB into existence. It worked. Never mind that we've rewritten most of that code by now, but still.
      • sweta05
        I am trying to fix thhis bug https://tickets.metabrainz.org/browse/AB-390?jq... I tested the functionality on my local host everything seems to work fine, but it looks little different at the front end.I added the pic to the comments please
      • check.
      • BrainzBot
        AB-390: Datasets uploaded with csv import are always made public
      • shivam-kapila
        One of the best things about LB for me is that its a hackathon product. I just love hackathons
      • iliekcomputers
        sweta05: what is the line above the checkbox?
      • shivam-kapila
        iliekcomputers: It looks like a div's border. Left and right borders are also visible on zooming in
      • scientist1642 has quit
      • iliekcomputers
        sweta05: let's remove the border and make the checkbox a bit smaller (and aligned with the text) and it should be good
      • thanks shivam-kapila
      • ruaok
        shivam-kapila: ok, you should submit your final proposal.
      • overall I think the first phase will play itself out differently that listed there, but there is little point in trying to fine-tune it.
      • I think the quantity of work for phase 1 is about right and I am not really fussed in which order it gets done in.
      • shivam-kapila
        ruaok: Its a bit jumbled. Thanks a lot for the review. :D
      • I will see if I can make it more ordered before the submission.
      • sweta05
        iliekcomputers : trying to find from where the line is coming, Okay i'll work on aligning the text and the box.
      • shivam-kapila: thank you i'll check it.
      • prabal
        Mr_Monkey: Ping
      • Mr_Monkey
        prabal: pong
      • prabal
        In my proposal I mentioned one route `'collection/:collectionId'` and for pagination `collection/:collectionId/:collectionId` for pagination. Is this fine or it should be changed to `collection/:collectionId/view` and `collection/:collectionId/view/view`
      • two `collectionId` in the route seems little odd
      • Mr_Monkey
        Hm. Why were there two :collectionId?
      • prabal
        For pagination?
      • Mr_Monkey
        Why do you need it twice?
      • prabal
        Isn't that how I did with revisions?
      • 'revisions` route will send markup
      • alastairp
        who did the work for collaborators on collections?
      • prabal
        `revisoins/revisions` route sends json to update the table
      • alastairp
        if you POST without an editor id, you get a stacktrace. is there a ticket open for this?
      • Mr_Monkey
        prabal: Right, but those routes don't have a dynamic id in there (like : collectionId)
      • So I think you should have collection/:collectionId and collection/:collectionId/paginate or something to that effect (I don't like the name, but…
      • prabal
        Hmm Yeah
      • Thankss
      • Mr_Monkey
        No problem
      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #767 (timescale…add-timescale-to-develop.sh): LB-503: Add command to connect to Timescale DB via develop.sh https://github.com/metabrainz/listenbrainz-serv...
      • BrainzBot
        LB-503: Add command to connect to Timescale DB via develop.sh https://tickets.metabrainz.org/browse/LB-503
      • ruaok
        shivam-kapila: what work on tests have you done so far?
      • (for timescale)
      • shivam-kapila
        ruaok: Not much. It was dependent on the timmescalelistenstore.py.
      • ruaok
        yeah, I'm working on that now, but I wish I has tests to run, which would make my life easier.
      • maybe we work on this together?
      • shivam-kapila
        Sure thing.
      • ruaok
        my goal is to make a timescalelistenstore that is function for function equivalent to the influx one.
      • shivam-kapila
        Hm. Tests would be easy to modify as its mostly SQL now.
      • ruaok
        the setup is quite a bit different between the two
      • but you should be able to copy the setup that we have in place for testing the DB modules.
      • shivam-kapila
        I was referencing the tests in DB module itself.
      • I will get some tests delivered to you asap.
      • ruaok
        how about you pick one function to test and get that setup working, then ping me?
      • shivam-kapila
        Better option for me too.
      • ruaok
        then we can integrate that and get one function properly tested and iron out all the little issues before we plow ahead to finish the rest of the code/tests?
      • get_listen_count_for_user ?
      • near the top, fairly simple function.
      • shivam-kapila
        On it.
      • ruaok
        thx
      • Freso: I kept getting discourse notifications on my private email because my MB profile uses that. I switched the email at MB, confirmed it, but it didn't propagate to discource. so I logged out and now my account is locked out. can you please have a look?
      • zas
        ruaok: I'll have a look
      • ruaok
        thank you!
      • iliekcomputers: I'm pondering if we should even bother using sqlalchemy for the timescale stuff. we're not going to do anything that will require an ORM and I fear the ORM gettting in the way. thoughts?
      • Freso: we still need your help
      • Freso: zas fixed it. thanks!
      • zas
        outsidecontext: any idea about PICARD-1791 ? we had multiple reports of such issue by win10 users recently
      • BrainzBot
        PICARD-1791: Network access is disabled error under VPN service https://tickets.metabrainz.org/browse/PICARD-1791
      • sweta05 has quit
      • CatQuest
        ruaok: 3d printing visers for doctors: https://www.nrk.no/osloogviken/storstilt-dugnad...
      • ruaok
        yes, thank you.
      • the hospitals in BCN do not want them.
      • I <3 livegrep (thanks iliekcomputers )
      • and zas, of course.
      • alastairp
        ruaok: ORM, or sqlalchemy-core?
      • ruaok
        whatever LB uses for its postgres access.
      • alastairp
        remember way back in London we had no end of trouble with flask sessions + psycog2 sessions
      • 95% of sqlalchemy use in LB is just -core, which is just a session management wrapper around our hand-written queries
      • ruaok
        ah, thanks for that reminder. I'll keep that in place then.
      • alastairp
        perfect