Cyna: If you want you can try your hand on something complex that will take you to the guts of it all, if that's what you are looking for: https://tickets.metabrainz.org/browse/BB-451
It touches on how entities are edited/created, how relationships between them are handled, revisions, etc. There's already been an attempt to solve it (initially just visually, then more in-depth), and I would encourage you to read the reviews on it where you'll find a good bit of information and useful bits of code from other branches: https://github.com/bookbrainz/bookbrainz-site/p...
BrainzBot
BB-451: When deleting entities, linked entities retain stale relationships to "(deleted)"
Mr_Monkey
Don't hesitate if you want to discuss it more
D4RK-PH0ENiX has quit
Cyna
Sure Im up for it... Ill have a look :)
alastairp
2:43 PM <iliekcomputers> What happens if we just make the hook run lint.sh which does it inside docker?
I'm not sure what I think about a hook in git which calls something in docker. It seems like a recipe for disaster... not sure a better way to do it
10:01 PM <shivam-kapila> We need something as sleep etc because I guess sometimes the DB container isn't up by the time it tries to connect to it. I face it a lot of times with Timescale running test.sh
BrainzBot
LB-508: Initial database creation does not always succeed on first try
Zastai joined the channel
alastairp
This is a documentation issue, not an application issue. If you look at the readme file at those instructions, it was updated a few months ago when we introduced develop.sh and the instructions were replaced incorrectly. we should restore the old version
alastairp: I explored the code as iliekcomputers and found dockerize at most places. So seems its not an issue. I need to add it to timescale though.
Also Tim has reported quite a good number of confusions though in the docs. I think we should update it and also compile the latest ones to readthedocs.io
alastairp
shivam-kapila: sure, that's true, but if the documentation was up to date, this issue wouldn't have happened
Does "unknown" mean "never donated" vs "should be nagged" -> "donated, but too long ago"?
Right now we seem to only be nagging "should be nagged"
I'm *thinking* we should change it to nag everyone who doesn't return 0, but
Maybe you can confirm it
ruaok
when did this start?
reosarevok
Lemme see
ruaok
I pushed an update live on friday, I wonder if that broke it. but that code hasn't changed in eons.
reosarevok
Two years ago :p
On our side, it seems
When converting to React it was assumed it was a 0/1 bool but it's in fact -1/0/1
I'll fix it
v6lur joined the channel
ruaok
thx
Cyna
Hey Mr_Monkey, The wrote you wrote for processMergeOperation. It does the merge operation right ? and not the delete
We need to remove the relationship from both entites relationshipSet for the relationship to be properly deleted.. As far as I've read.. That seems to be the issue.
Mr_Monkey
Correct. It's just an example of how you would go about changing relationships for an associated entity (If I merge A and B in to B, any entity that has a relationship to A should be changed to B
You don't need to modify the entity being deleted, but any other that has a relationship to it should be removed
mzfr joined the channel
Cyna
Another question, why has transacting used everywhere instead of transaction
Isn't it somewhat wrong even in english sense 🤔
I now get why bitmap is always so keen on getting the FlowJs right... Makes understanding code a hell lot easier
[listenbrainz-server] dependabot-preview[bot] opened pull request #780 (master…dependabot/pip/psycopg2-binary-2.8.5): Bump psycopg2-binary from 2.8.4 to 2.8.5 https://github.com/metabrainz/listenbrainz-serv...
D4RK-PH0ENiX joined the channel
iliekcomputers
Yeah, seems a bug in the pipeline, it isn't very stable, I'll take a look
Don't worry about the time it's been opened, not a problem. I was prodding because i'm eager to close up FA things. I'll have a look at that PR as ell as see if there's anything else needed for cleanup.
(Also, I was recently working again on updating our build system, and one issue in particular was blocking me regarding less files, that I think are solved now with the new FA, so huzzah !)