#metabrainz

/

      • Zastai
        CatQuest: it shows the full iso timestamp when you hover over the "X days ago", so you do have full precision available when you want it
      • but I would say that not too long after "a year ago", it should probably flip over to "Month Year". "November 2000" is more useful than "19.5 years ago".
      • travis-ci joined the channel
      • travis-ci
        Project bookbrainz-site build #2823: passed in 2 min 12 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...
      • travis-ci has left the channel
      • Zastai
        (but not everyone has a 20-year last.fm history to import, of course, so it's an easy oversight :) )
      • Lotheric_ is now known as Lotheric
      • sumedh has quit
      • Lotheric
        country flags aren't showing on musicbrainz beta
      • they are there on regular brainz
      • BrainzBot
        MBS-10464: Country flags disappeared on beta, works on regularBrainz
      • Lotheric
        something about flags resource not uploaded correctly to staticbrainz.
      • alastairp
        Zastai: that's a nice suggestion about changing the form of timestamp past a particular age
      • Zastai
        I'll make a ticket
      • alastairp
        I wonder if it could be 'ago' only on the main listen page, and the moment you go to a search/paging view, it changes?
      • also an interesting question about the people who logged something 3 years ago and haven't added anything else
      • should _that_ show "3 years ago" or "2017"?
      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #807 (master…test_fix): Fix RecentListens snapshot test https://github.com/metabrainz/listenbrainz-serv...
      • yvanzo
        updating mb.o
      • Lotheric
        \o/
      • Zastai
        still "May 2017" I'd say. granularity below one month becomes useless
      • alastairp
        sure, I didn't mean to only put 2017. Something with a full date.
      • Freso
        Idk about that. If I see three listens in "May 2017" and nothing else for that month, it might be interesting to see at a glance whether they’re all on the same day or if it’s like one listen on three separate days.
      • alastairp
        but the question is at what age do you switch from 'ago' to a specific date
      • Freso
        More than one second ago. :p
      • (Don’t mind me. I just also dislike "ago" times. :))
      • Lotheric
        use the daran calendar and sols
      • :p
      • ~darian
      • ishaanshah[m]
        iliekcomputers: I changed mount to shallow in the tests
      • It was causing some warning to pop up
      • I think it should be shallow so that child components are not rendered
      • What do you think?
      • yvanzo
        done
      • KrachbummNT has quit
      • KrachbummNT joined the channel
      • prabal
        Mr_Monkey: ping
      • gabrielcarvfer joined the channel
      • thomasross joined the channel
      • gabrielcarvfer has quit
      • zas
        outsidecontext: around?
      • sumedh joined the channel
      • outsidecontext: I found the issue concerning PICARD-1803 but I'm not sure how we should fix it. Ping me back when around.
      • BrainzBot
        PICARD-1803: Instrument EWI is rewritten "e w i" https://tickets.metabrainz.org/browse/PICARD-1803
      • reosarevok
        Argh
      • Our historic edit code suuuuucks
      • yvanzo, bitmap: we have code such as
      • Should I add the id (assuming we have it stored, such as here) to Release->new() because releases are never expect to *not* have an ID?
      • Or is it irrelevant because we don't actually use that ID?
      • It just feels weird to claim release ID can be null for flow typing, but I guess maybe we can just be like "lalala we don't use it anyway let's ignore it clashes with the typing"
      • bitmap
        reosarevok: if we have it, I'd probably include it to be safe and 'cause why not
      • Freso
        <BANG>
      • It’s Easter Monday!
      • People up for reviews: Mr_Monkey, Freso, yvanzo, zas, alastairp, pristine__, bitmap, ruaok, reosarevok, shivam-kapila, CatQuest, ishaanshah[m], Cyna, _lucifer – anyone else, please let me know ASAP!
      • Mr_Monkey: Go!
      • OTOH, Mr_Monkey was pinged 45 mins ago and never responded, so maybe let’s go for the next one…
      • yvanzo: Go!
      • zas
        I'll go if no one does...
      • Mr_Monkey
        Sorry !
      • yvanzo
        Hi!
      • Mr_Monkey
        IRC issues
      • zas
        ah :)
      • Mr_Monkey
        I can go afterwards
      • yvanzo
        Mr_Monkey: can you go first please?
      • Mr_Monkey
        Sure
      • Freso
        Honestly not sure how many we’ll see around. It is Easter Monday, but OTOH there are hopefully not too many people off at family gatherings and such, so…
      • Mr_Monkey
        Lots of PR reviewing last week in view of updating the BookBrainz website
      • Lots of good improvements with this update thanks to all the contributions !
      • Freso
        !m contributors
      • BrainzBot
        You're doing good work, contributors!
      • Mr_Monkey
        I also continued and mostly completed reworking our build system, which was timely since an issue was introduced with the local development setup that could be fixed in the same fell swoop
      • I also worked on fixing an issue with search indexing on BB
      • And another sprinkles of smaller issues
      • That's it !
      • yvanzo: next?
      • yvanzo
        thanks!
      • Last week, I updated MB beta and transcluded some MB wikidoc pages.
      • Thanks to chaban and Zastai for contributing to the MB wiki.
      • And thanks to Rotab for the pair of bugfixes he submitted.
      • Zastai
        Well, "contributing". I mainly linked to my own libraries.
      • yvanzo
        Otherwise, I continued to work on MB search indexes dump.
      • chaban
      • yvanzo
        We discussed MBS internationalization/localizability issues.
      • Freso
        chaban: On it.
      • yvanzo
        And I went back to converting code to React.
      • Fin I guess, and sorry for being late! Go zas?
      • zas
        Hey
      • Usual supervision, we had few bandwith drops this week, but they all recovered quickly and apparently not under our control
      • also upgraded all systems, and grafana
      • Freso
        chaban: They’re blocked, you should be good to revert etc. again now. Thank you.
      • zas
        Also worked a bit on Picard and reported annoying MBS i18n issues for others to work on (evil laugh)
      • that's it for me. alastairp ?
      • yvanzo
        Zastai: bindings and community sharing are very welcome! :)
      • alastairp
        hi
      • Zastai
        (zas: that message should have been written entirely in emoji, really)
      • alastairp
        this week was a bit slower than normal for me, I've been trying to balance my 2 jobs and haven't found a good balance yet between job 1, job 2 and lockdown.
      • that's to say, not much done this week. I had a good talk with zas about sysadmin stuff for acousticbrainz, and I spent some time categorising tickets in jira and matching them up with my development plan
      • since I didn't get a lot done last week, I'll be focusing more on AB this week
      • fin, bitmap?
      • bitmap
        hey
      • last week I worked on testing the SQL upgrade script for https://github.com/metabrainz/musicbrainz-serve... and deployed that to production
      • Freso
        (People still up: Freso, pristine__, ruaok, reosarevok, shivam-kapila, CatQuest, ishaanshah[m], Cyna, _lucifer – anyone else, please let me know ASAP!)
      • bitmap
        tl;dr editing/viewing alias locales should work now
      • reosarevok
        Yay
      • bitmap
        then finished writing a pgtap test for the "merge dupe artist credits" cleanup script in https://github.com/metabrainz/musicbrainz-serve... but need to figure out how to appropriately clear the cache still
      • (we have some artist credits in the DB that are 100% identical except for their ids)
      • also worked on converting the series edit form to React, since it plugs into some internals of the (old) relationship editor, and would otherwise break with the new React relationship editor
      • mostly just did code review otherwise. fin, reosarevok go!
      • reosarevok
        Hi!
      • I've been working on React conversion, mostly
      • Started working on old historical edits, since with non-historical I'm still not sure which ones Cyna is already working on
      • Remembered that they're a huge mess of missing data, but eh, will get there
      • Darkloke joined the channel
      • Other than that, a few recent bug reports and stuff like that
      • CatQuest: are you around?
      • If not, Freso :)
      • Freso gives CatQuest a few secs
      • Freso
        I guess I’ll go.
      • 🙋
      • I didn’t do too much last week, still trying to get my mental state back together. But it did pick up a bit by second half of the week, so I managed to do a bunch of catching up, and I also got to spend a couple of hours writing out the reply to the person re: last week’s meeting item.
      • I also poked at some other reports.
      • I think that’s a fin.
      • pristine__: Around? If so, go!
      • I guess not, ruaok: Go!
      • ruaok
        k
      • Freso
        (People still up: shivam-kapila, CatQuest, ishaanshah[m], Cyna, _lucifer(, pristine__?) – anyone else, please let me know ASAP!)
      • ruaok
        last week I did the finances (record transaction, balance accounts, pester people with late invoices, send new invoices, follow up on sent invoices)... I never explain what this means, but it is usually some 2-days of work.
      • thankfully only 1 per quarter, so its not too bad.
      • I also worked on the timescale migration with shivam-kapila and iliekcomputers... who bailed me about a bit when work got frustrating. thank you! <3
      • I expect to finish that in the next day or so and then work on the migration tools for moving the data across.
      • looks promising, really.
      • shivam-kapila
        (welcome :) )
      • ruaok
        fin.
      • shivam-kapila: go!
      • iliekcomputers
        I'll go too
      • shivam-kapila
        Hello everyone!
      • Last week I worked on a bunch of tests for timescale migration
      • Deleted the whole code of previous night the next day :/
      • Apart from that assignments tood the whole weekend
      • Took*
      • Wating to go back to code
      • Explored some interesting React stuff
      • I guess thats it
      • Fin!
      • rohitdandamudi
        Add me too!!!
      • shivam-kapila
        iliekcomputers: Go
      • iliekcomputers
        Hey