People up for telling their stories of the last week: zas, Freso, alastairp, Mr_Monkey, ruaok, yvanzo, pristine__, bitmap, reosarevok, ishaanshah[m], _lucifer, shivam-kapila, Cyna, CatQuest – anyone else who wish to tell their story, let me know ASAP. :)
zas: Go!
zas
Hey
nothing fancy this week, mainly usual supervision, upgrades, PR reviews, and various support actions
fin. Freso ?
Freso
🙋
Had exams and tried to keep up in between, not much else to report.
fin.
alastairp: Go!
alastairp
hi. I'm going to paste some stuff because I managed to get quite a bit done
I did some small administrative tasks around our dockerfile and build process (AB-431, AB-408)
I took some examples from the listenbrainz develop.sh file and integrated this into AB, made a few improvements and added some new features
I set up backups, so that user data created on AcousticBrainz (e.g. dataset models) are backed up using the MeB backup system
I enabled a new feature on AB pull requests: https://github.com/OrkoHunter/pep8speaks. The idea is that this tool will automatically give feedback on code formatting for all PRs, this saves my time, so that I don't have to do it when reviewing PRs, and can instead focus on the actual changes.
I also saw a discussion at a SoC summit a few years ago where they suggested using bots for this kind of task because getting feedback from a bot is more impersonal, and therefore doesn't feel as much like a personal attack - that way your first feedback on your first PR isn't a bunch of text from a person pointing out all of the stuff that you did wrong.
I migrated AB to use webpack instead of gulp, and got it generating assets in both development and production mode. I fixed a few weird environment things that we had configured in AB due to the way that gulp assets worked, which is good.
I also upgraded all python and javascript dependencies (including a major version upgrade to babel 7) and made a PR to BU to upgrade flask, which is pending a small discussion with iliekcomputers
I also upgraded react to the latest version, which is used in the dataset editor (we were using a version from 2015!) and made some improvements to the code layout in the editor. This is pending some small changes to the way we store datasets in the database before it gets released
I introduced a bug in the hl calculation, causing it to stop between Monday and Saturday. I fixed the issue, but noticed that we're running very tight when comparing the rate of new submissions and the rate that the hl calculator works. We had almost 200k pending items and it took all weekend to work through the backlog
I looked into some optimisations for this (AB-439). While looking at this, I found an easy speed up which is something that ruaok picked up as an issue mid-last year which is something that has been causing more load than necessary on our database server (AB-440)
Last week had more PR reviews, some finishing up of build setup update and lint warnings fixes
Freso
(People still up: ruaok, yvanzo, pristine__, bitmap, reosarevok, ishaanshah[m], _lucifer, shivam-kapila, Cyna, CatQuest – anyone else, let me know ASAP. :))
Mr_Monkey
I also spent a lot of time writing sql queries to fix up some malformed stuff in the detabase, some relationships and identifiers from back when there were no constraint as to what entity type could be related to what other entity type
And lot of manual fixes for identifiers, which unfortunately I can't autofix for the most part.
I'll be continuing database cleanups little by little.
That's most of it ! reosarevok go !
reosarevok
Hi!
This week I made changes as needed on the open PRs
I also kept converting a few more edit types to React
And worked on some URL Cleanup code
And went see some birds and chilled because I don't want to pass my max hour limit :p
CatQuest: around this time? :)
Freso
Oh, also, I meant to say at the beginning: I’ll only be waiting 40 seconds for people to reply now, instead of my usual 60, to hopefully get things moving along a bit more smoothly.
On that note:
ruaok: Go!
ruaok
k
last week I sent off our tax info to the accountants and did some business analysis, trying to sort out how we can ride out this storm.
shivam-kapila and I got the timescale port of the LB code base done -- there are a few more tweaks to be done and then I need to work on the data import stuff. then we can really start the testing for it.
I may not be doing too much tech stuff this week, since my focus is going to be business planning. which sucks my soul, but we need to do it.
oh, and also we officially have a new mailing address.
not that anyone would care, but if you have the old address memorized, it is time to memorize a new one.
which, of course, no one but I actually did, so there is little point to this. lol.
that was merged to beta and I don't think any issues cropped up yet
also redid most of the script to merge duplicate ACs in https://github.com/metabrainz/musicbrainz-serve... so that it limits the amount of work done per hour more effectively & doesn't inflate replication packets
debugged an issue on beta causing certain links to all go to the homepage. turned out to be a bug in Template Toolkit, which was annoying
later in the week I worked on finishing converting the release index page to React, though it requires some changes in how we send data to the template renderer, because of how huge the pages are. so I'll submit a PR for that first
also reviewed various PRs from reosarevok / yvanzo
fin! yvanzo ?
yvanzo
Hi!
I mostly worked on musicbrainz-docker (search & support).
Freso
(People still up: pristine__, ishaanshah[m], _lucifer, shivam-kapila, Cyna, rohitdandamudi – anyone else, let me know ASAP. :))
yvanzo
Fully tested loading search indexes from dumps retrieved through FTP.
There is an open PR that should be merged into mbvm-38-dev dev branch soon.
This branch will need very little clean-up before being merged into master in turn.
Also fixed small issues about musicbrainz-docker and/or MBS.
Plus usual reviews, beta release, maintenance...
That's all from me, go pristine__?
Freso
No pristine__ it seems, ishaanshah[m]: go!
ishaanshah[m]
Hi everybody!
Last week was mostly assignments for me.
Thankfully most of them are over now, so can focus back on tests again
Thats all for me
shivam-kapila: go!
Chinmay3199
Mr_Monkey: in BB-463, does moving identifiers from edition to corresponding work mean adding the identifier to work and deleting it from edition? Manually XD?
