decided to take sometime away from the keyboard but that lasted for 3 days
Worked mostly around with the BB identifier and cleaning up the database there
Get back to learning more about End to end testing with Cypress
Finished some pending college assignments XD
fin.
Freso
Alright!
Thank you everyone for your reviews!
One more topic on today’s agenda…
bitmap: PG extensions
bitmap
okay
one sec, have some text to paste
one thing I'd like for us to do to simplify the PG upgrade is to drop the musicbrainz-collate and -unaccent extensions - we can replace those with functionality built into PG, even without breaking 9.5 (not using any v12 features)
there have been some years-old requests to drop these extensions so people can more easily run MBS on AWS for example, so it'd be nice to do it while manual intervention is required
this would require adding a couple functions and rebuilding some indexes, but I guess that might be fine since we already have to fix the earthdistance extension that way, as I mentioned earlier
ruaok
now is the time for this.
bitmap
to be clear, this would modify some functions and rebuild some indexes, but it wouldn't affect replication one way or another. does that sound okay?
yvanzo
+1
ruaok
fine by me.
iliekcomputers
sgtm
ruaok
+1
bitmap
ok, motion carried then. thanks!
Freso
Alright!
That is all for this meeting then.
Thank you everyone for your time. Please stay safe out there!
</BANG>
alastairp
bitmap: does that mean that postgres has since gained the functionality to do what we needed these extensions for previously?
Mr_Monkey
Thanks Freso !
Take care everyone !
alastairp
iliekcomputers: thanks for the pr :)
bitmap
alastairp: it's had functionality for both of these things since at least 9.5, though the unaccent extension has been improved since
alastairp
that's great
bitmap
so I think it's suitable enough to replace musicbrainz-unaccent - we only really use it for direct search & deciding whether a disambiguation comment is required, anyway
iliekcomputers
np!
yvanzo
Thanks!
bitmap
& with the COLLATE feature PG I was able to basically reproduce the musicbrainz-collate sort order almost exactly
yvanzo
Freso: maybe can you please update the list of "people up for reviews" after pasting the ones you have been reported?
I always read these last because it goes too fast and we cannot interact with anyway.
Freso
yvanzo: I do post updated lists several times during the meeting.
shivam-kapila
I think he means like after todats reosarevok review
alastairp
iliekcomputers: did you see yvanzo's comment on your old guidelines PR? Do you know why you originally opened this pr in guidelines and not syswiki?
iliekcomputers
alastairp: i did see the comment, i don't remember the reason. I'm happy to put it in syswiki
alastairp
thanks. It felt ok to me to have it public as kind of a "this is why we have things like push.sh, and this is generally how we work, how tags are made, etc, even if you can't actually deploy it youself"
but I agree that there's no clear reason to have it there
yvanzo
Freso: it's just I read this list minus people actually connected that went for review, anyway, not a big deal. :)
Freso
Ah, I see. I’ll consider it. FWIW, the first name on the list will always be the one I call on first.
