0:25 AM
d4rkie has quit
0:25 AM
Nyanko-sensei joined the channel
0:28 AM
rdswift has quit
0:28 AM
dseomn has quit
0:44 AM
rdswift joined the channel
1:10 AM
KindOne has quit
1:12 AM
dseomn joined the channel
1:14 AM
supersandro2000 joined the channel
1:29 AM
KindOne joined the channel
2:32 AM
Gore has quit
2:33 AM
Gore joined the channel
2:49 AM
Chinmay3199 joined the channel
3:17 AM
KindTwo joined the channel
3:18 AM
KindOne has quit
3:21 AM
KindTwo is now known as KindOne
4:21 AM
Lotheric joined the channel
4:21 AM
Lotheric_ has quit
6:52 AM
sumedh joined the channel
7:18 AM
v6lur joined the channel
7:22 AM
sumedh has quit
8:00 AM
diru1100
Mo"in' !
8:51 AM
jmp_music joined the channel
8:58 AM
ruaok
moooin!
8:59 AM
Mr_Monkey
Moin !
9:05 AM
Gazooo has quit
9:06 AM
Gazooo joined the channel
9:07 AM
zas
moooin
9:08 AM
jmp_music
moinn!
9:46 AM
v6lur has quit
9:47 AM
c1e0 joined the channel
10:07 AM
MajorLurker joined the channel
10:08 AM
shivam-kapila
ruaok: Hey
10:08 AM
For the tryharder thing
10:08 AM
ruaok
hey. I had a fabulous weekend without any sort of work. I really needed that. :)
10:09 AM
shivam-kapila
Breaks are necessary :)
10:09 AM
ruaok
and I am glad you fixed the tests. i was too tired to continue as you could tell.
10:09 AM
did you push your stuff somewhere?
10:09 AM
shivam-kapila
Not yet
10:09 AM
Will push all together
10:10 AM
Front end is almost done. Just a clarification. For try harder = true, the listen length is to be zero or it can have other values too
10:11 AM
Just a basic adjustment of values needed and then I will push the stuff for you to take a look
10:12 AM
supersandro2000 has quit
10:12 AM
supersandro2000 joined the channel
10:12 AM
ruaok
> listen length
10:12 AM
number of listens fetched?
10:12 AM
shivam-kapila
yeah
10:14 AM
Because in case some listens (< 25) are fetched, the next button can get the thing done IG.
10:27 AM
ruaok
sorry, today is the next step of relaxation of lockdown and I'm trying to sort out exactly what we can do.
10:28 AM
going to an outdoor cafe and having a beer is allowed again. today may not end up being so productive either. 🤣
10:28 AM
> Because in case some listens (< 25) are fetched, the next button can get the thing done IG.
10:28 AM
shivam-kapila
Wow glad situation is getting better there
10:28 AM
ruaok
My thinking was that if we ask to fetch 25 listens and we get fewer listens that that, we show the "try harder" button.
10:28 AM
is that too simple?
10:29 AM
you're still in lockdown, right?
10:29 AM
shivam-kapila
Yeah
10:29 AM
State lockdown extended till 30 june as I heard
10:29 AM
ruaok
OUCH.
10:30 AM
shivam-kapila
> is that too simple?
10:30 AM
The button is being displayed, reload is working too, just getting the right params to get that working
10:31 AM
ruaok
so, that is all that is missing then?
10:31 AM
shivam-kapila
Yup
10:32 AM
and a lil manual testing to verify this
10:32 AM
ruaok
ok, that should be a trival thing to do. let me to do that before beer time.
10:34 AM
ok, now passing try_harder to react props. running tests.
10:36 AM
shivam-kapila: remind me what was the parameter that should get passed back to the profile page? was that try_harder=1 ?
10:37 AM
shivam-kapila
ruaok: I am yet to push the latest commit
10:37 AM
Just a few minutes please
10:45 AM
Lotheric_ joined the channel
10:46 AM
Lotheric has quit
10:57 AM
ruaok
I wonder if try_harder should end up being an int value that indicates HOW HARD to try.
10:57 AM
shivam-kapila
So you want to implement the fibonacci series type expansion?
10:58 AM
ruaok
we should consider it.
10:58 AM
for now I'll make it try 50 days.
10:58 AM
shivam-kapila
Ah simple
10:59 AM
Although I will make it int to expand the scope in future
10:59 AM
In case the need arises
10:59 AM
Makes sense?
10:59 AM
ruaok
perfect
11:01 AM
Freso
11:09 AM
ruaok
shivam-kapila: I pushed my changes to timescale-rebased-again.
11:09 AM
> Try harder somewhat implemented. One unit test is failing and more tests need to be added for try_harder
11:10 AM
might be good enough for manual testing. now lunch!
11:10 AM
shivam-kapila
Oh you made my work easy
11:10 AM
Thanks
11:22 AM
killmePI has quit
11:22 AM
killme joined the channel
11:30 AM
supersandro2000 has quit
11:30 AM
supersandro2000 joined the channel
11:32 AM
c1e0_ joined the channel
11:35 AM
c1e0 has quit
11:39 AM
c1e0 joined the channel
11:41 AM
c1e0_ has quit
11:52 AM
c1e0 has quit
11:52 AM
cleo joined the channel
11:52 AM
cleo is now known as Guest74139
12:26 PM
Guest74139 has quit
12:41 PM
travis-ci joined the channel
12:41 PM
travis-ci
12:41 PM
travis-ci has left the channel
12:48 PM
BrainzGit
12:48 PM
SomalRudra
gr0uch0mars _lucifer
12:50 PM
gr0uch0mars: _lucifer: ^
12:50 PM
_lucifer
good work, SomalRudra
12:52 PM
SomalRudra: I saw you raised min api to 21 why so?
12:56 PM
SomalRudra
That was to handle few kotlin extensions.. do u reckon keeping it 15? I can try
12:57 PM
_lucifer:
13:02 PM
_lucifer
SomalRudra: yes its better to keep it that way unless necessary
13:04 PM
SomalRudra
okay!
13:04 PM
_lucifer
another thing I wanted to point it is whether it is possible to include taglib as a dependency from internet
13:04 PM
instead of having the source inside the app itself
13:05 PM
there are two issues with keeping taglib in the app source
13:05 PM
non compliance with fdroid (to comply either obtain the dependency from a trusted repo or build from source)
13:06 PM
building taglib from source will slow development by increasing build times and is error prone as well
13:09 PM
One more thing, you forgot to exclude output binaries from the commit
13:09 PM
13:12 PM
and add the necessary lines to .gitignore
13:42 PM
SomalRudra
_lucifer: Sounds great ! Sure I can do that.It's already a library and the official taglib repo is a submodule here. So,I can try using it as a dependency using jitpack. But the library has some issue. We need to fix them first.After that,I will try adding it as a dependency. Please have a look at why it crashes at runtime.
13:42 PM
and about excluding the binaries,I need to figure that out. Share some more resources if you have them
13:45 PM
_lucifer
See the above link I shared
13:45 PM
copy its contents to .gitignore and push a commmit
13:47 PM
it should work fine, at most we need to append the correct prefix
13:47 PM
if it doesn't, for now just do it and let's see if it works
13:47 PM
we'll fine tune it later
13:48 PM
sumedh joined the channel
13:56 PM
SomalRudra
ok
14:33 PM
shivam-kapila
ruaok: All tests passing
14:34 PM
Working tested
14:35 PM
Took more time as my laptop got too much heated. Huh. :/
14:49 PM
BestSteve has quit
14:49 PM
BestSteve joined the channel
14:57 PM
yvanzo
Freso, reosarevok: yup, reviewing it!
15:01 PM
thomasross has quit
15:01 PM
reosarevok
<
15:01 PM
3
15:01 PM
thomasross joined the channel
15:02 PM
yvanzo
bitmap: Ok, thanks for the syswiki notes :)
15:03 PM
thomasross_ joined the channel
15:03 PM
thomasross is now known as Guest57993
15:03 PM
Guest57993 has quit
15:03 PM
thomasross_ is now known as thomasross
15:04 PM
thomasross has quit
15:05 PM
thomasross joined the channel
15:05 PM
ruaok
shivam-kapila: very cool. pushed your changes yet?
15:10 PM
shivam-kapila
Yups
15:11 PM
Shall I open a PR or you will directly fetch that?
15:17 PM
ruaok
I'll pull directly.
15:25 PM
which branch?
15:36 PM
shivam-kapila
timescale-rebased-again
15:36 PM
ruaok
k
15:36 PM
shivam-kapila
Also added test for try_harder