#metabrainz

Yeeah that would be better

OK, we can start doing that in the shared google doc we've been using.

And from that you or we can make a plan of attack for the next few weeks

Yes

I find it easier to go forward on a project when it's laid out in digestible chunks

Yeah alright

This pr should be easy to finish

famous last words

XD

Have to add the modal

The way it was done in the entity Page

Lol

I'll continue writings tests and complete this pr this week

OK. I think you identified the first two targets: PRs 435 and the parts of 477 that don't require a second user

(I'll review in the morning)

Yeah ok

Also we talked about params validation for the POST routes

How should that be done

I was thinking about using this for that https://www.npmjs.com/package/express-joi-valid...

Or would you prefer not using any library and just writing middlewares

I'm not opposed, it looks like a useful tool.

Depending on how complex the validation we need to do is, you could also simply have a list of accepted params, and throw an error if any param the route receives is not in that list

But I'll be honest, it's not the top priority

Gooooood night!

💤

ok

Do you want to join me on the google doc, and help me flesh out the outline as I go?

prabal: How does that outline of the next few weeks work for you?

It looks niccee

Better to have definite goals for the upcoming weeks

It looks niccee

Sorry I'm having network problems :'(

I don't count that against you. Are there ways I can help so that you can work offline?

[musicbrainz-server] mwiencek opened pull request #1616 (master…edit-data-flow-types): Function to generate Flow types from edit data https://github.com/metabrainz/musicbrainz-serve...

Nah it's alright. thanks

Is there anything else Mr_Monkey?

That's it for me!

Of wcourse I'm still here if you have questions or doubts (if the internet connection gods smile upon you)

I'll go back to working. I've had enough fun in last two weeks :P

I didn't code much after we deployed it on the test.bb

:P

Yeah, the end of the project is in sight, and so is that of the coding period :)

Yes :)

If you go faster the the outline we drew up, we already have a good list of stretch goals and improvements, which is nice.

Also you said you'll review that PR in the morning right?

There's more cool stuff in there for when you're done with tests :)

ep, correct

Yep*

It’s Creme Brûlée Monday!

https://www.youtube.com/watch?v=fdZCc-fzacY (explicit)

I haven’t received any mailed in reviews, so…

People up for reviews: reosarevok, ruaok, alastairp, bitmap, yvanzo, Freso, zas, Mr_Monkey, jmp_music, prabal, diru1100, _lucifer, ishaanshah[m], shivam-kapila, Cyna,CatQuest,

reosarevok: Go!

I want to add few more tests in that

Hi Guest10905!

(I can’t change my nick 😭 )

Hi!

i'll ask for review when it's ready

hi

This week I worked on some more React conversion and a few small bugs / improvements

I plan to keep doing more of the same - there's a ton of React edit PRs open though so maybe I shouldn't flood the PR queue too much :D

Guest10905: go

o/

Pretty much the same as last week. Lurking around, trying to fix an issue with my laptop (I think I fixed it), now hobbling around on a sprained ankle, trying to keep it raised when stationary.

fin.

ruaok: Go!

k

the past week was about getting the timescale release out.

of course silly me, wrote a blog post about the migration before the release and ended up on hacker news.

which gave us good feedback about some minor things to improve... which have all been improved and released already.

go team!

the migration itself was fairly smooth with only minor issues that needed cleaning up.

after that I returned to work on troi and help pristine___ with recommendations.

over the weekend I jumped in an hosted a couple of lookup queries that will enable the upcoming world view of where the artists are that you're listening to. (and the heatmap of your listening times!)

the whole LB team has been on fire in the past week and moving fast and releasing things.

its really be a good amount of fun to be part of it.

thank you iliekcomputers, shivam-kapila, ishaanshah, pristine___ and Mr_Monkey. And maybe even alastairp. :p

ishaanshah: tell us more about these sweet graphs!

(I hope you have screenshots to share!)

I didn't do any of the work these last week, good work everyone else

Hey everyone

ok, its clear now. no thanks alastairp.

:p

last week I worked on the daily activity frontend and backend

The frontend is nearly done, hopefully will be able to release it by tomorrow

!m LB team (but alastairp)

You're doing good work, LB team (but alastairp)!

Also worked on some minor fixes on the spark side

Thanks to ruaok and iliekcomputers, we will soon have the origins of artist that users listen to

Noice

I have improved upon the UI today, let me take a screenshot and post it in a bit.

fin!

(People still up: alastairp, bitmap, yvanzo, zas, Mr_Monkey, jmp_music, prabal, diru1100, _lucifer, shivam-kapila, Cyna[m], CatQuest – anyone else who want to give review, let me know!)

alastairp: next?

hi

yvanzo: it's OK, I'm not even part of LB team, so the exception is not needed :)

says the co-founder of the project.

I spent some time this week working with jmp_music on his SoC project, we made a number of advancements and it's looking good, I'm sure he'll be able to explain.

I finished https://github.com/metabrainz/acousticbrainz-se..., and I finished testing https://github.com/metabrainz/acousticbrainz-se...

I reviewed iliekcomputers' https://github.com/metabrainz/listenbrainz-serv..., and will add some notes tomorrow

I learned of another project where people were using our original database dump to do some analysis of the AB data, because of that it pushed me to take another look at our pending PR https://github.com/metabrainz/acousticbrainz-se... to finish dumps. Most of this is good, I'm just running some test dumps to see that everything works as expected

ruaok: I'll just sit on my ivory tower and make proclamations

bitmap: next?

*continue to

hey

exactly

not a super productive week, as I mostly worked on finishing https://github.com/metabrainz/musicbrainz-serve... and experimented with moving data fetching for build_display_data into our JS

a couple weeks ago I was working on changing how we pass data to the template renderer, since we're running into performance issues and nasty hacks there, but I ran into more unpleasant issues and had to scrap bits I was working on

we could avoid all this if we just fetched things from the database directly in Node, which is what I was experimenting with

other than that I did a small amount of code review and tried to debug MBS-10982

MBS-10982: Batch-adding relationships temporarily uses a huge amount of RAM https://tickets.metabrainz.org/browse/MBS-10982

also set up gzip compression for barman WAL files so we won't run out of space so quick on williams

I think that's about it :) fin, go yvanzo ?

hi!

Not a super productive week either but I fixed more small issues and reviewed more PRs!

Fin, go shivam-kapila!

Thanks yvanzo

Hi everyone

(People still up: zas, Mr_Monkey, jmp_music, prabal, diru1100, _lucifer, Cyna[m], CatQuest – anyone else who want to give review, let me know!)

Last week was a see-saw between LB and vivas/assignments

I managed to be almost on track this time and the UI is *almost* done

I will be shooting PRs after vivas

So perhaps a new LB soon 🤞

I think thats it

zas: go!

Hey

I mainly worked of Picard code reviews

also I calmed down few abusers, and whitelisted few legit users trapped in QNAP blacklist

I started to experiment with timescaledb in order to migrate current stats using grafana + influx to it

calmed down or smacked down?

(second option)

that's it for me. Next, Mr_Monkey ?

Heyo!

[listenbrainz-server] mayhem opened pull request #989 (master…fix-listens-api-sort-order): Fix API sort order https://github.com/metabrainz/listenbrainz-serv...

I was off for a good half of last week. No energy in the heat and a covid scare (tested negative)

woo!

good news

I did rebase the ongoing ListenBrainz PR improving navigation, after the timescale switch

ruaok: here too please

I'd love to get that merged ASAP. can I help?

Read about the Bookogs and Comicogs project (sister projects of Discogs) that are unfortunately closing down, and welcomed some members of their communities.