12:42 am
supersandro2000 has quit
12:42 am
supersandro2000 joined the channel
12:43 am
supersandro2000 has quit
12:43 am
supersandro2000 joined the channel
1:02 am
d4rkie has quit
1:03 am
Nyanko-sensei joined the channel
1:41 am
MajorLurker joined the channel
1:53 am
MajorLurker has quit
2:19 am
Gore has quit
2:19 am
Gore joined the channel
2:38 am
shivam-kapila
Morning
3:33 am
sumedh joined the channel
3:41 am
_lucifer
morning
4:11 am
white_shadow joined the channel
4:15 am
white_shadow
not slept or you came early today?
4:15 am
_lucifer
came early
4:19 am
sumedh has quit
4:20 am
shivam-kapila
white_shadow: where are you from
4:21 am
white_shadow
Beijing
4:21 am
shivam-kapila
Oh yes _lucifer
4:27 am
white_shadow
shivam-kapila and you?
4:29 am
shivam-kapila
white_shadow: I am from india
4:38 am
white_shadow
rafales arrived :p
4:43 am
sumedh joined the channel
5:19 am
djwhitey has quit
6:29 am
sumedh has quit
6:34 am
sumedh joined the channel
6:50 am
sumedh has quit
6:57 am
sumedh joined the channel
7:16 am
djwhitey joined the channel
7:32 am
Sophist_UK joined the channel
7:35 am
Sophist-UK has quit
7:45 am
ruaok
moooin!
8:02 am
supersandro2000 has quit
8:03 am
supersandro2000 joined the channel
8:10 am
zas
mooooooin
8:13 am
yvanzo
mooooooooo’in’
8:23 am
sumedh has quit
9:05 am
Gazooo has quit
9:05 am
sumedh joined the channel
9:11 am
Gazooo joined the channel
9:12 am
BrainzGit
9:13 am
_lucifer
shivam-kapila: morning again
9:15 am
ruaok
iliekcomputers: have you ever mock'ed psycopg2? its been a bit of a challenge.
9:44 am
white_shadow has quit
9:46 am
shivam-kapila
_lucifer: good morning
9:51 am
white_shadow joined the channel
9:57 am
pristine___
ruaok: `0.6861021519` one example of rating. How many decimal places do you want?
9:58 am
ruaok
three should be enough. thanks!
9:58 am
pristine___
i was thinking `round(rating, 3)`
9:58 am
ruaok
great minds.
9:58 am
pristine___
woho. same same
9:58 am
thanks
11:13 am
BrainzGit
11:13 am
11:13 am
11:14 am
11:14 am
11:14 am
11:15 am
11:15 am
11:16 am
11:16 am
ruaok
thanks for blowing the PR count out of the water dependabot
11:25 am
BrainzGit
11:36 am
Major_Lurker has quit
11:53 am
djwhitey has quit
12:17 pm
12:26 pm
killmePI joined the channel
12:26 pm
killme has quit
12:28 pm
sumedh has quit
1:27 pm
abhinavohri joined the channel
1:29 pm
abhinavohri
Hi
1:31 pm
I know basic python and git. I am new to opensource.I want to contribute to the listenbrainz project .How can I start .
1:32 pm
ishaanshah
Hi abhinavohri
1:32 pm
1:33 pm
abhinavohri
Hi ishaanshah
1:33 pm
Ok
1:33 pm
ishaanshah
There are filters available which ypu can use to find some easier bugs
1:40 pm
sumedh joined the channel
1:45 pm
abhinavohri
ishaanshah: I am unable to find any filters to get easy issues.Can u please suggest something?
1:49 pm
ishaanshah
1:49 pm
BrainzBot
LB-583: Add tests for Spotify search functionality
1:49 pm
ishaanshah
abhinavohri ^
1:49 pm
abhinavohri
ishaanshah:
1:50 pm
ishaanshah: ok i will look into it.Thank you
2:09 pm
2:09 pm
BrainzBot
LB-594: Rename "adjust_days" and "adjust_months"
2:10 pm
abhinavohri
ishaanshah: If i change the name from adjust_month to offset_month will it be okay?
2:14 pm
shivam-kapila
abhinavohri: hey! Welcome
2:14 pm
Looking at the code I dont think offset days will make up for that
2:15 pm
abhinavohri
hello! shivam-kapila
2:15 pm
ok.... do you have any suggestions?
2:16 pm
shivam-kapila
Offset IMO is something that will be added/subtracted to something
2:16 pm
Not currently. Sorry
2:17 pm
abhinavohri
ok.... what about get_relative_month ?
2:18 pm
ishaanshah
shivam-kapila: the link for the code is incorrect
2:18 pm
2:18 pm
This is the function we are talking about
2:18 pm
I think offset makes sense
2:18 pm
shivam-kapila
Yep I got that ishaanshah
2:19 pm
If its fine by you I dont have any conflicts
2:20 pm
shivam-kapila waves a green flag
2:21 pm
abhinavohri
so is offset_month final?
2:21 pm
ishaanshah
abhinavohri: I think offset_month is good, I can't think of anything better right now, but if I do I will definitely let you know
2:22 pm
abhinavohri
ok thanks to both of you .I will open a PR soon
2:22 pm
ishaanshah
Also can you add docstrings for both of the functions while you are at it.
2:23 pm
abhinavohri
ok s
2:23 pm
shivam-kapila
abhinavohri: just curious where do u study :)
2:23 pm
ishaanshah
abhinavohri: thanks :)
2:23 pm
abhinavohri
I just completed my +2
2:23 pm
shivam-kapila
Oh nice
2:24 pm
abhinavohri
yups
2:24 pm
shivam-kapila
Its very inspiring to know that you found your way to OSS
2:24 pm
At a good time
2:25 pm
abhinavohri
_lucifer is my elder brother .He introduced me to OSS.
2:25 pm
shivam-kapila
Oh
2:26 pm
I guessed that btw ;)
2:26 pm
abhinavohri
oh nice :)
2:27 pm
shivam-kapila
_lucifer: you want 2 laptop now🤣
2:27 pm
_lucifer waves at abhinavohri
2:27 pm
_lucifer
maybe shivam-kapila 😂
2:27 pm
shivam-kapila
Clever
2:28 pm
shivam-kapila looks at his younger brother
2:34 pm
sumedh has quit
2:34 pm
sumedh joined the channel
2:40 pm
white_snack joined the channel
2:42 pm
white_shadow has quit
3:36 pm
sumedh has quit
3:54 pm
SomalRudra
shivam-kapila: just wondering how do u put the subsection text.
3:54 pm
_lucifer do you mean this SomalRudra
3:55 pm
yeah
3:55 pm
😁
3:55 pm
_lucifer
write /me in front of your message
3:56 pm
SomalRudra works
3:56 pm
SomalRudra
owk worked 😁
3:56 pm
_lucifer
:)
4:05 pm
SomalRudra
abhinavohri: welcome. _lucifer will get u a nickname soon (get me one too 😐 )
4:12 pm
white_snack has quit
4:13 pm
white_shadow joined the channel
4:17 pm
rdswift: good until he's the lil one here 😄
4:18 pm
shivam-kapila
I also want a nick name
4:24 pm
SomalRudra
_lucifer: you got 2. Help us get to one
4:25 pm
_lucifer
i personally prefer to choose a nick after a movie or tv character i like
4:29 pm
shivam-kapila
I like my brand name🤣
4:34 pm
_lucifer
cannot use off with diru1100
4:34 pm
diru1100 now it should work
4:34 pm
diru1100
Yaayyy 🎉
4:35 pm
_lucifer
test something else [off]
4:36 pm
yup diru1100
4:36 pm
and i just discovered if you add