#metabrainz

/

      • supersandro2000 has quit
      • supersandro2000 joined the channel
      • shivam-kapila
        pristine___: awesome
      • morning
      • My next playlikst
      • diru1100
        Morning!!
      • Check it out
      • c1e0 joined the channel
      • sumedh joined the channel
      • pristine___
        shivam-kapila: <3
      • reosarevok
        bitmap, yvanzo: ideas re: https://tickets.metabrainz.org/browse/MBS-11071 ? (also, good to know React does help! that specific page is still slowwww tho)
      • BrainzBot
        MBS-11071: Speed up loading editing history
      • sumedh has quit
      • c1e0 has quit
      • sumedh joined the channel
      • yvanzo
        mo’’in’
      • reosarevok: loading edits asynchronously but that might be for later on.
      • killmePI is now known as killme
      • sumedh has quit
      • diru1100
        I shared SB to my friends and DL enthusiasts
      • Now SB has around 30 stargazers 🧡
      • sumedh joined the channel
      • nelgin
        yvanzo ?
      • pristine___
        diru1100: SB?
      • shivam-kapila
        SpamBtainz
      • SpamBrainz
      • diru1100
        Yes 😅
      • pristine___
        diru1100: oh! I took *stargazer* literally, so got excited.
      • jmp_music_
        Morning!
      • diru1100
        Haha, yea 😅. Although there's a star gazing local community in an NGO called Swecha which am part of.
      • nelgin
        bitmap ?
      • nm, going to bed.
      • CatQuest
        ooh stargazeing
      • c1e0 joined the channel
      • gr0uch0mars joined the channel
      • supersandro2000 has quit
      • supersandro2000 joined the channel
      • pristine___
        so I want to mock `get_candidate_set_rdd_for_user` and ensure that `generate_recommendations` is called two times with diff return values from `get_candidate_set_rdd_for_user` based on input given to `get_candidate_set_rdd_for_user`
      • kinda stuck, anyone?
      • _lucifer
        Someone left the following feedback for the app in Spainish "Quiero ayudar a la aplicación"
      • can someone translate, Google's translation seems to be incoherent
      • ruaok
        I want to help with the application.
      • also moooooin!
      • shivam-kapila
        ruaok: you know android too. fascinating
      • _lucifer
        oh ok thanks
      • ruaok
        shivam-kapila: either that, or I know how to speak (some) spanish, lol.
      • CatQuest
        _lucifer: sometimes it helps to split up the sentence so that gtran only does it per word
      • shivam-kapila
        oops. stupid me.
      • ishaanshah
        pristine___: side effect might be helpful
      • CatQuest
        (you gt "I want" "help" "to" "the application" which, well kinda makes more sense)
      • ishaanshah
        you can change the declaration of the function and add a condition in the mock declaration
      • CatQuest
        why would you mock the declration?
      • is it a bad declaration or something?
      • ishaanshah
        CatQuest: for testing it
      • CatQuest
        pristine___ wants to mock it :(
      • uh do what I know is, mock: make fun of
      • s/do/so
      • or maybe mock: fake
      • pristine___
        > you can change the declaration of the function and add a condition in the mock declaration
      • ishaanshah: like? can you elaborate?
      • ishaanshah
        CatQuest: yep the 2nd one :D
      • CatQuest
        ok?
      • yvanzo
        nelgin (good morning): That is the same problem of environment not being set when running a bash script in musicbrainz container using 'exec'.
      • CatQuest
        I guess this is an british/indian use of the word I'm not used to
      • yvanzo
        nelgin: However, I can still not reproduce this bug (neither was I able to reproduce it last time).
      • ishaanshah
        pristine___: Meaning you could create another python function which returns based upon the input argument
      • nelgin
        yvanzo, Not sure what to tell you.
      • ishaanshah
        and while patching it, pass the function in `side_effect` parameter
      • yvanzo
        So the bug seems to be environmental, Docker/Compose version maybe?
      • nelgin: please run: sudo docker-compose exec musicbrainz env | sort ; sudo docker-compose exec musicbrainz bash -c env | sort
      • nelgin
        musicbrainz@musicbrainz:~/musicbrainz-docker$ cat /etc/lsb-release
      • DISTRIB_ID=Ubuntu
      • DISTRIB_RELEASE=20.04
      • I'm using the default ubuntu version.s
      • ishaanshah
      • nelgin
      • yvanzo
        nelgin: ok, I found the bug
      • _lucifer
        CatQuest: thanks for the tip. will try it.
      • ruaok: reosarevok: it is possible to forward reviews and feedback from play store to email. I have that enabled for my personal email. are you interested in forwarding it to support@meb ?
      • ruaok
        sure, lets do that.
      • _lucifer
        you'll need to login the play store console from your account and tick the preference from settings
      • yvanzo
        nelgin: fixed it in master: git pull --ff-only && docker build musicbrainz # should be fast, just updating one script in the image.
      • note: a new release is expected today
      • (with MBS upgrade)
      • nelgin
        unable to prepare context: path "musicbrainz" not found
      • Oh, does that need to be a sudo too?
      • yvanzo
        sorry, sudo docker-compose build musicbrainz
      • nelgin
        Ah ok
      • yvanzo
        (sudo usage depends on your system)
      • nelgin
        sudo usages depends on your instructions :)
      • yvanzo
        you probably don't need sudo
      • I put it because it is the most common situation.
      • nelgin
        I always use it anyway, I modified sudoers to not require a password so it doesn't really bother me.
      • yvanzo
        my bad instruction was to use 'docker build' instead of 'docker-compose build'
      • (fwiw, I use sudo too)
      • nelgin
        Ok, that is complete. SHould I just run that last step to again to enable live indexing?
      • admin/setup-amqp-triggers install
      • yvanzo
        make sure to replace the container first
      • the 'musicbrainz' container
      • nelgin
        err
      • Let me get the instructions
      • yvanzo
        sudo docker-compose rm -s musicbrainz
      • sudo docker-compose up -d musicbrainz
      • nelgin
        OK done
      • yvanzo
        # that's it
      • nelgin
        sudo docker-compose exec indexer python -m sir amqp_setup
      • admin/create-amqp-extension
      • admin/setup-amqp-triggers install
      • Do I need to do all 3 of those again or just the last one?
      • diru1100 has quit
      • yvanzo
        probably not, you just need the last one
      • diru1100 joined the channel
      • Gazooo794 has quit
      • nelgin
        $ admin/setup-amqp-triggers install
      • Installing indexer triggers ...
      • BEGIN
      • CREATE FUNCTION
      • [skip a lot]
      • Regenerating SQL scripts in /tmp/indexer-sql/...
      • Could not find CreateTables.sql, search_path might not be correct
      • Could not find CreateTables.sql, skipping
      • Could not find CreateIndexes.sql, skipping
      • Could not find CreateSearchIndexes.sql, skipping
      • Could not find CreateReplicationTriggers.sql, skipping
      • Done.
      • $ admin/setup-amqp-triggers install
      • setup-amqp-triggers: cannot install: file 'admin/.setup-amqp-triggers-sql' exists
      • Either setup-amqp-triggers is already running or stopped before its time.
      • Remove this file if you are sure the script is not still running:
      • rm -frv admin/.setup-amqp-triggers-sql
      • I was told to do that previous, so I guess I need to step back one?
      • yvanzo
        "Could not... skipping" are harmless
      • nelgin
        Oh ok
      • yvanzo
        please paste the full log in a pastebin
      • Gazooo794 joined the channel
      • I'm pretty sure it's successful, but just to confirm
      • nelgin
      • yvanzo
        yup, seems fine to me
      • wait...
      • alright, sorry :)
      • nelgin
        If you say so...
      • musicbrainz@musicbrainz:~/musicbrainz-docker$ admin/configure add live-indexing-search
      • Successfully set/updated COMPOSE_FILE in '/home/musicbrainz/musicbrainz-docker/.env'.
      • Question is, how do we know it's actually working?
      • v6lur joined the channel
      • yvanzo
        grep live-indexing-search /home/musicbrainz/musicbrainz-docker/.env
      • nelgin
        COMPOSE_FILE=docker-compose.yml:local/compose/memory-settings.yml:compose/replication-token.yml:compose/live-indexing-search.yml:compose/replication-cron.yml