#metabrainz

/

      • apetresc is now known as apetresc[m]
      • apetresc[m] is now known as apetresc
      • sumedh joined the channel
      • sumedh has quit
      • Pragya joined the channel
      • Pragya has quit
      • sumedh joined the channel
      • sumedh has quit
      • pristine___
        Mr_Monkey: what was the issue when you were trying to run the rec feedback PR locally?
      • alastairp
        hi _lucifer, thanks for the notification. I'll look for and hide the review
      • maybe we should just merge that PR that we were talking on, and then work on the improvements that I suggested later?
      • _lucifer
        sure
      • alastairp
        I've hidden the review and front page works again, I'll merge and release the other today
      • what's the story here? This isn't a redirect right, because if it was a redirect it would correctly change to the new entity?
      • this entity has completely disappeared?
      • _lucifer
        i have updated the miscellaneous bugs pr with description of the bug. (earlier i had tput the description in the commit message)
      • we should merge that as well
      • alastairp
        great
      • _lucifer
        i do not think redirects work properly. if they do then the entity was deleted from MB
      • alastairp: https://musicbrainz.org/release-group/e623e122-... does not show it as well
      • so deleted from mb?
      • Gazooo79494 has quit
      • if there is a log of mb deletions we could confirm this from there as well
      • Mr_Monkey
        pristine___: Not sure, but mainly that I didn't have time to investigate what the problem was :)
      • Zastai joined the channel
      • Gazooo79494 joined the channel
      • pristine___
        Will you be able to today?
      • Mr_Monkey
        Yep
      • alastairp
        _lucifer: thanks for the comments. I'm loading up a shell now
      • to take a look at language stuff
      • pristine___
        Mr_Monkey: also, did you read shivam-kapila 's comment on the PR. I agree that the ecllipse is not very clear about its func, maybe we can show emoticons on the card Or write something feedback: (eclipse V), though I also feel that it will look odd. Before moving on can we discuss about it?
      • Mr_Monkey
        Perhaps a different icon other than the ellipsis would work, one that represents the idea of feedback
      • pristine___
        Umm... Sounds like a plan. Do you have any suggestions for such icon? I will search too.
      • Mr_Monkey
      • Or combining thumbs up and thumbs down in a single icon
      • pristine___
        Mr_Monkey: I like this one
      • what do you think?
      • this gives the impression that once user click on it, there will be more feedback icons
      • +1 here
      • or can we do it the fb style?
      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1154 (master…refactor-dir-recs): make separate dirs to store recording and artist recommendation scripts https://github.com/metabrainz/listenbrainz-serv...
      • pristine___
        once user hover on `like` text
      • all the emotions will be displayed
      • shivam-kapila
        +1
      • pristine___
        (on a side note, fb animations are really cute, we can do that maybe later, not sure how much work is that)
      • shivam-kapila
        Too much :p
      • Mr_Monkey
        I like the smile-plus icon, but it requires a pro license which we don't have
      • ruaok
        if it helps design, we can probably pay for a license.
      • shivam-kapila
        I dont think we need to
      • Mr_Monkey
        > once user hover on `like` text
      • pristine___ what do you mean by that?
      • shivam-kapila
        Pro style icons are easy to copy with some css
      • ruaok
        $99/year. I wouldn't actually mind doing that. I think they do good work and it would be sensible for us to support them.
      • Mr_Monkey
        ruaok: I think there's other ways to solve it to be honest
      • No copying !
      • Certainly not.
      • pristine___
        Mr_Monkey: do you use fb?
      • Mr_Monkey
        If you think it's justifiable ruaok , thn we could do that.
      • ruaok
        ok, if you don't feel that we should, then ok. but as a general rule, $100/year isn't much and I like supporting other projects.
      • shivam-kapila
        Mr_Monkey: not copying. Sorry. I meant designing
      • Mr_Monkey
        Um, not a lot of FB, and pretty heavily modified with scripts.
      • ruaok
        totally justifiable. tell me if you want it.
      • pristine___
        I will send you a ss
      • a sec
      • Mr_Monkey
        But I see the way they do it pristine___
      • I was confused about the use of "like text"
      • pristine___
      • ah!, okay
      • so what do you think of that?
      • can we do something like this, the ss I shared above?
      • Mr_Monkey
        So, a button with some icon + like text , and when the user hovers over it we show the dropdown. That sounds good to me, especially if that's a choice the FB design team took (suposedly after a good amount of A/B testing)
      • pristine___
        yes
      • Mr_Monkey
        Personally, design-wise I hate that they're so freaking big, but the mechanism is totally sane
      • pristine___
        :p
      • Mr_Monkey
        Gosh, I hadn't seen they animated them.
      • pristine___
        yeah, it looks cute to me
      • :p
      • Mr_Monkey
        I feel like I'm back to the days of MSN Messenger…
      • pristine___
        so i much work is it? combining text + some icon (I prefer thumbs up here)
      • I have no idea how to do that in css
      • :(
      • ruaok: thanks for the merge :)
      • ruaok
        np
      • Mr_Monkey
        How much work? well, you already have pretty much everything in place I think. Changing the ellipsis icon to a thumbs up icon with text, and changing the dropdown mechanism to trigger on hover and click
      • pristine___
        Ah! sounds *not-that-difficult-to-me*
      • :p
      • but before moving on to this (text+icon), I think we should resolve the other comments on the PR, ping me when you run the PR on your local machine
      • Gore joined the channel
      • Mr_Monkey
        OK, I'm running it now, and got a few comments. Will put them on the PR directly.
      • I'm also going to have a look at the stopPropagation thing.
      • pristine___
        Mr_Monkey: I think we don't need the stopPropogation thing if we want to adopt fb stuff. Can you please open fb and try liking/loving/or anything a picture/post?
      • I really love the whole process of giving feedback in fb
      • Mr_Monkey
        I trust you, to be honest
      • One less problem to solve
      • pristine___
        It like hober over the text, click on the feedback icon, the drop down will close and the selected emoji will be displayed in place of the text.
      • Mr_Monkey: thanks! I wanted you to have a look since I won't be able to write the whole process :p
      • Mr_Monkey
        I think that'll work well
      • pristine___
        (And my kids glove can code that)
      • :p
      • Mr_Monkey
        One thing I'm not convinced by is the look of the icons currently, with the css styling.
      • What I originally had in mind was to use the solid and regular FA icons for hover/non-hover states, instead of using css to change their look
      • pristine___
        Regular like? Without color
      • Is there a different name/class for regular icon and a solid icon? That ways we won't need css, we can just change the class for hover/non-hover
      • shivam-kapila
        Yep
      • Mr_Monkey
        Exactly that
      • pristine___
        Oh. Cool
      • Mr_Monkey
        You'd have something like this to import both styles:
      • pristine___
        Oh my god! That's so cool.
      • Learnt something new today!
      • But we have to use css to set the colours?
      • Mr_Monkey
        Yes, but simply once as (for example): color: #C62828;
      • And we won't be changing from `color` to `stroke` anymore
      • Which means that hover detection would need to be done in the RecommendationControl component to decide using the solid or regular icon, instead of with CSS
      • You can use something like this in RecControl: ` onMouseEnter={this.toggleHover} onMouseLeave={this.toggleHover}` to detect hovering on the element.
      • `toggleHover` would set a state boolean `hovered`, which you would then use to decide which icon to use, along with a `feedback` *prop*.
      • In short you want this (pseudo code ahead): `if (this.props.feedback === "" && this.state.hoverred) {//use the 'solid' icon} else {//use the 'regular' icon}`
      • Something along those lines in any case
      • I have to run now (family in town) but if you have questions do ask and I'll answer this evening before the meeting.
      • Ooh, my summit t-shirt just arrived!
      • ruaok
        eggciting. is it as good as we hoped?
      • pristine___
        waiting for mine ;)
      • shivam-kapila
        If I get it tomorrow I am gonaa wear in wedding
      • ruaok
        deffo wedding attire. for sure.
      • alastairp
        who is an admin on transifex?
      • (good morning)
      • ruaok
        I think I might be.
      • alastairp
        I just created an account, alastairp. Can you see if you can give me adminy access to critiquebrainz? https://www.transifex.com/musicbrainz/critiqueb...
      • ruaok
        i theory an invite should be on its way.
      • Mr_Monkey
        Really good quality tshirt ruaok ! The print looks really good
      • ruaok
        glad to hear that! where was it shippped from?
      • reosarevok
        yvanzo: I just saw https://github.com/metabrainz/musicbrainz-serve... - I guess if I literally just want to disable this, the best option is to pass a separate disabled boolean and have disabled={disabled || frozen} but if you prefer something else do let me know
      • alastairp
        hi reosarevok
      • got some time to talk about languages and language codes?
      • reosarevok
        I guess?
      • Have a video meeting in 50 min but nothing before that
      • And I already have my upper half properly clothed
      • alastairp
        so, we use iso639-1 codes in CB to list languages that a review could be written in: https://en.wikipedia.org/wiki/ISO_639-1, https://en.wikipedia.org/wiki/List_of_ISO_639-1...
      • however, some of these languages appear to be what is termed a "macrolanguage": https://en.wikipedia.org/wiki/ISO_639_macrolang...
      • reosarevok
        Yeah. we generally use -3 codes if they exist
      • alastairp
        we ran into this issue when CatQuest wrote a review and tagged it "no" - Norwegian, rather than one of the two specific languages inside that macrolanguage, Bokmål or Nynorsk
      • because we use a python package called babel to convert -1 codes into their localised names: https://usercontent.irccloud-cdn.com/file/BRaTC...
      • reosarevok
        But in general we have our own languages list in the DB *and* translations already exist too
      • As such, any reason not to just use the MB table?
      • (maybe with an extra table in between to control which ones to show)
      • alastairp
        and babel doesn't include translations for macrolanguages (here, we use the default in english "Norwegian")
      • interesting. I wonder if the choice of using -1 was intentional