#metabrainz

/

      • supersandro2000 has quit
      • supersandro2000 joined the channel
      • d4rkie has quit
      • Nyanko-sensei joined the channel
      • davic has quit
      • ballin joined the channel
      • ballin
        looking to do some data vis on my listens data from listenbrainz. any projects i should be aware of? (python or R especially?)
      • *data vis, munging/parsing, joining with other data (ex. album covers, spotify, youtube), that kind of thing
      • supersandro2000 has left the channel
      • sumedh joined the channel
      • adhi001 joined the channel
      • ballin has quit
      • yef has quit
      • yef joined the channel
      • yef has quit
      • yef joined the channel
      • yef has quit
      • yef joined the channel
      • yef has quit
      • yef joined the channel
      • yef has quit
      • yef joined the channel
      • thomasross has quit
      • sumedh has quit
      • sumedh joined the channel
      • sumedh has quit
      • sumedh joined the channel
      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1811 (master…MBS-11262): MBS-11262: Fix l_attributes translation calls https://github.com/metabrainz/musicbrainz-serve...
      • [musicbrainz-server] reosarevok opened pull request #1812 (master…MBS-11263): MBS-11263: Allow % (for encoded stuff) on beatport URLs https://github.com/metabrainz/musicbrainz-serve...
      • adhi001 has quit
      • Gazooo79494 has quit
      • Gazooo79494 joined the channel
      • alastairp
        morning
      • yvanzo
        mo’’in’
      • alastairp
        ruaok: can you ping me when you're around? Got a few questions about LB tests
      • ruaok
        Moin. Still Out running some errands... Will ping in an hour or so.
      • alastairp
        OK, I'm in no rush. see you later
      • yvanzo
        reosarevok: thanks, I fixed it.
      • Nyanko-sensei has quit
      • Nyanko-sensei joined the channel
      • ruaok
        hour? whatever. what'cha got, alastairp ?
      • alastairp
        ruaok: you added your tests to integration tests. Is that because this was the only place that had the timescale db set up?
      • because based on what I understand from these tests, your stuff would fit better in the unit tests (it's just putting in/reading from the db)
      • it seems like the integration tests are for testing pipelines - stuff goes in, gets queued, gets picked up, etc)
      • it makes sense to me that we create TS tables in the unit tests, and add these playlist tests to the unit tests section
      • ruaok
        hmmm.
      • I went looking or the API tests and couldn't find them, then remembered that they are in the integration tests, then added the tests there.
      • that is to say, I hadn't really considered the question. now that you mentioned it, not sure why that is.
      • I can try to move them to unit tests and see if anything asplodes.
      • alastairp
        there is a tomato/potato question about what the boundary is between unit/int tests
      • my thought was that the integration tests only existed because we had data flowing through a pipeline of multiple services
      • *my understanding
      • ruaok
        I'm actually with you -- given that we *can* put them in unit tests, why not?
      • alastairp
        cool
      • I don't mind doing that - because I'm right at the point where I need TS in the unit tests for DB tests
      • ruaok
        cool, perfect. thanks.
      • alastairp
        so I'll add TS to the test setup, and move yours (after taking a look to see if it fits in with other tests)
      • ruaok
        I'll try and focus on finishing that troi branch I promised to have done more than a week ago.
      • great
      • any chance you can look at the mega branch mbid-mapping soon?
      • alastairp
        you said cool, perfect, and thanks. so now I need to come up with another one word reply indicating agreement that doesn't make it seem like i'm just copying you
      • I have the tab open, and it's on today's list
      • ruaok
        brilliant!
      • ;-0
      • alastairp
        OK, interesting. there are a small handful of view tests in the unit tests, but you're right that all API tests are in integrations.
      • definitely something to double-check with iliekcomputers if we can grab his time for 5 minutes
      • abhinavohri joined the channel
      • abhinavohri
        @alastairp I have some doubts related to my two PRs.
      • v6lur joined the channel
      • CatQuest
        so, how long since I asked to change my email adress on the wiki should I except to get that confirmation email?
      • BestSteve has quit
      • BestSteve joined the channel
      • expect*
      • sumedh has quit
      • sumedh joined the channel
      • bitmap has quit
      • zas
        a forum user cannot log in after he changed his email address on MB, known issue?
      • bitmap joined the channel
      • reosarevok
        Freso: ^ ?
      • (not known to me)
      • zas
        He gets "There is a problem with your account. Please contact the site's administrator" error even from a fresh browser window (new browser, no cookies)
      • reosarevok
        This is in discourse, not MB proper, right?
      • zas
        yes
      • I'll enable SSO verbose logging and see what's going on
      • reosarevok
        Maybe the stuff that should propagate updates to discourse broke or something. I'm not sure how that is set up though
      • Let me know what you find
      • BrainzGit
        [musicbrainz-docker] ta264 opened pull request #179 (master…update): Update https://github.com/metabrainz/musicbrainz-docke...
      • [musicbrainz-docker] ta264 closed pull request #179 (master…update): Update https://github.com/metabrainz/musicbrainz-docke...
      • alastairp
        ruaok: I want to run some more database/testing stuff past you
      • ruaok
        k
      • alastairp
        timescale tests currently drop db/createdb after each test. unit tests don't drop the db, they just remove all of the tables
      • ruaok
        I've slowly been working to make TS tests more robust.
      • namely, so that sequential tests can be run on the same DB, so that we can setup the DB once for any given test run.
      • alastairp
        docker postgres has this functionality to create a db and a user at startup time. I'm wondering if this would be a nice thing to do. In my view it's the correct way to do it
      • ruaok
        e.g random user names for each run.
      • alastairp
        ah, cool. I think that ties in with the direction that I want to go too, then
      • ruaok
        yeah, I think we're on the same path.
      • alastairp
        because there are a _lot_ of moving parts here - lots of different test superclasses that do slightly different things
      • ruaok
        effectively I want the tests to be ... not idempotent, but.. isolated
      • ?
      • alastairp
        yeah, I see what you mean
      • another way I've seen these kind of tests work, at the beginning of each test a transaction is started, and then it's rolled back at the end. This is a lot faster than tearing down database tables after each test
      • but that's for another day, I think
      • ruaok
        that would work too...
      • alastairp
        oh, I guess I understand the reasoning for not creating db on container startup for LB - it's because we have both LB and MsB stuff in the same database cluster
      • now I remember
      • so now the question is do we keep things consistent between TS and regular PG cluster, or do we do setup differently in each?
      • ugh, I'm opening a can of worms here, but for LB dev, there's really no reason to not just use the TS cluster for all 3 databases, right??!
      • ruaok
        make TS better. I don't see the importance of consistency here. just document that they do things differently.
      • TS can be used for all.
      • part of the current state of things is because we haven't drank the kool aid on TS yet.
      • alastairp
        I'll open a ticket for that
      • ruaok
        but I'm ok with it now. its been solid and I've been enjoying having it.
      • shivam-kapila
        Are you talking about migrating postgres stuff to TS in lb
      • alastairp
        shivam-kapila: just using the same server process for all databases
      • shivam-kapila
        Okay okay
      • alastairp
        because timescale _is_ postgres, just with an extension
      • so it seems a waste to start 2 postgres servers. Let's just start one, and use it for all 3 of our databases (listens, user data, messybrainz)
      • shivam-kapila
        Got it. Thanks
      • BrainzGit
        [musicbrainz-server] mwiencek opened pull request #1813 (beta…beta-cookie-samesite-none): Set SameSite=None on beta cookie https://github.com/metabrainz/musicbrainz-serve...
      • alastairp
      • kilroy was here?
      • ruaok
        wow, I haven't seen kilroy in a while. no idea how that came to be. :)
      • alastairp
        abhinavohri: hi, how are you? I'm sorry I haven't had time recently to look at your work
      • what are your questions?
      • CatQuest
        hi, so I updated the my email on https://wiki.musicbrainz.org/ used. i still have no gotten a confirmation email
      • abhinavohri has quit
      • alastairp
        who worked on the original integration tests in listenbrainz? especially the ./test.sh int part? shivam-kapila?
      • remind me why we have a separate docker-compose file for the two tests? is it because of the timescale-writer container?
      • pristine___
        Mr_Monkey: is #1149 on your radar today
      • Mr_Monkey
        Yep!
      • pristine___
        :)
      • Mr_Monkey
        Today or tomorrow, but likely today since we're so close to the end
      • alastairp
        hi Mr_Monkey!
      • Mr_Monkey
        Hai !
      • alastairp
        ça va?
      • CatQuest
        vraiment?
      • Mr_Monkey
        Ça va bien, et toi?
      • alastairp
        CatQuest: hi. I have a fuzzy memory that email in the wiki isn't working. at least it was mail in some wiki that I used often
      • Mr_Monkey: fine thanks, I guess
      • kind of wish that it'd decide to rain or not, and stop with this almost but not quite
      • CatQuest
        alastairp: ahaha
      • yea that's a shame and something we aughto fix asap
      • BenOckmore
        Mr_Monkey: hey :) if you wanted to chat about the TypeScript PR, I'm free for the next few hours (on vacation today)
      • Mr_Monkey
        Ooh, nice :)
      • I've started reviewing the PR, but haven't had time to finish. It's on my list for today though, so perfect :)
      • alastairp
        hi BenOckmore!
      • happy ... thanksgiving?
      • cyber bank holiday monday?
      • CatQuest
        tsk