#metabrainz

/

      • BenOckmore
        alastairp: coincidental British thanksgiving holiday! :P
      • CatQuest
        BenOckmore: we also have #bookbrainz for bookbrainz now! :D
      • and hi!!!
      • Mr_Monkey
        again*
      • BenOckmore
        CatQuest: I'll join :)
      • CatQuest
        yay
      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1184 (master…test-timescale): Make timescale test setup part of generic testing code https://github.com/metabrainz/listenbrainz-serv...
      • zas
        Freso: ping
      • sumedh has quit
      • reosarevok: I found the reason user cannot log in, his email domain is blacklisted on our discourse
      • CatQuest
        :(
      • alastairp
        ruaok: for bono dataset hoster, you just use the bono-data-sets repo + run docker without docker-compose, right?
      • ruaok
        no compose, correct.
      • abhinavohri joined the channel
      • there are now start-production.sh and stop-production.sh
      • which deal with bringing up the https front end
      • BrainzGit
        [bookbrainz-site] MonkeyDo closed pull request #523 (master…snyk-upgrade-34a01beaef373af5128228fc761aad8f): [Snyk] Upgrade snyk from 1.385.0 to 1.398.1 https://github.com/bookbrainz/bookbrainz-site/p...
      • sumedh joined the channel
      • [listenbrainz-server] mayhem merged pull request #1171 (master…solve-500-in-feedback-api): LB-755: Solve 500 in feedback api https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        heh. now I forgot what I had left to do on the weekly-flashback-jams. its been too long. sigh.
      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1814 (master…MBS-11258): MBS-11258: Support internationalized domains in isValidURL https://github.com/metabrainz/musicbrainz-serve...
      • ruaok
      • zas: outsidecontext: ^^ I've got a pile of tracks that cause this error.
      • do you want one?
      • outsidecontext
        ruaok: yes please
      • ruaok
        how should I deliver that?
      • reosarevok
        "in wrapper"
      • reosarevok hides
      • ruaok
        outsidecontext: in mail.
      • shivam-kapila
        > who worked on the original integration tests in listenbrainz? especially the ./test.sh int part?
      • alastairp: yes
      • Sorry I was away due to exams
      • alastairp
        shivam-kapila: I opened LB-768
      • BrainzBot
        LB-768: Merge unit and integration tests back into a single docker-compose configuration https://tickets.metabrainz.org/browse/LB-768
      • alastairp
        you don't have to apologise about doing exams
      • CatQuest
        indeed
      • shivam-kapila
        alastairp: thanks for the ticket. I will take a look post exams.
      • alastairp
        shivam-kapila: do you understand what the ticket is suggesting?
      • jmp_music joined the channel
      • reosarevok
        (unless you do them really badly, then maybe you should apologize. but probably not to us :p )
      • CatQuest
        yeh
      • jmp_music
        Hello guys! I won't make it for the meeting today! However I have to notice that as for my progress, I have completed some of the core coding for the results to be loaded into the CM for the outputs to be like gaia (folded instances + matrix dictionary)
      • shivam-kapila
        Freso: can you take me off the review list. I will be back after exams
      • jmp_music
        alastairp: I'll send you my updates later this week
      • alastairp
        jmp_music: no problem! have a good evening
      • jmp_music
        also I have a problem and I can't log into the irccloud
      • do you know what happened? thanks
      • Freso
        <BANG>
      • It’s Monday of Remembrance for all Victims of Chemical Warfare!
      • People up for reviews tonight: ruaok, Mr_Monkey, yvanzo, alastairp, zas, bitmap, Freso, reosarevok, CatQuest – anyone else who want to give review, please let me know ASAP! :)
      • ruaok: Go!
      • ruaok
        k
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, punycode urls (reo)
      • last week was a doozy.
      • shivam-kapila
        (alastairp: I think yes. I will ping you before working on it)
      • ruaok
        after the playlist hacking I needed a day off, but couldn't get one because of the leak.
      • the leak really overshadowed my week and things are still not fully settled. we haven't heard back yet from the lawyer whom we asked about GDPR related issues.
      • the mbid mapping code has been revamped completely to make the typesense based version the new MBID mapping.
      • the PR is open (rather large, ugh). once that is merged, I will push it to production and have a follow up PR.
      • gah. that's all. kinda don't want to think about last week. blearg.
      • bitmap, go!
      • bitmap
        hey
      • last week I mostly worked on https://github.com/metabrainz/musicbrainz-serve... which should hopefully make the kind of leak we found even more impossible
      • Freso
        (At least we’re not Parler; no leaked social security numbers and driver license etc. scans…)
      • ruaok
        more impossible. lol.
      • bitmap
        other than that, I was testing MBS-11092 again per psychoadept's comment
      • BrainzBot
        MBS-11092: Some issue with userscripts/plugins and beta site https://tickets.metabrainz.org/browse/MBS-11092
      • bitmap
        set up a simulation of prod/beta instances on my dev server to check that importing to prod correctly forwards you to beta and doesn't log you out
      • it works though I did find one minor issue I submitted a PR for earlier today, https://github.com/metabrainz/musicbrainz-serve...
      • jmp_music has quit
      • I also worked a bit on adding event art archive support to coverart_redirect. nothing too major otherwise
      • fin! go Mr_Monkey
      • Mr_Monkey
        Hiya !
      • Last week was pretty simply divided for me: Reviewing PRs for BB and LB, and working on the LB playlist feature.
      • The latter is shaping up nicely, I was able on the web page to create playlists and search and add items, and play that playlist.
      • shivam-kapila
        !m Mr_Monkey
      • BrainzBot
        You're doing good work, Mr_Monkey!
      • Mr_Monkey
        That should be finished (at least an alpha version) quite soon™.
      • Also kept an eye on the forums.
      • That's it ! zas go !
      • zas
        Hey
      • apart usual maintenance, upgrades, supervision, I investigated some abnormal traffic on MB web service
      • basically we have a significant increased of 304s since a week, it seems related to web radios and mobile, perhaps some new mobile app using our services
      • I keep an eye on this, for now, not really an issue, but it increased the load on kiki
      • plus user support, Picard dev and PR reviews, fin.
      • yvanzo: ?
      • yvanzo
        hi!
      • I figured how many mails we are currently sending daily, so we can mail all potentially affected accounts within a week.
      • It seems likely that most of these accounts have not even been found by spammers.
      • ruaok
        good to know.
      • maybe we should just do this...
      • reosarevok
        I have a suggested email text somewhere, wait.
      • yvanzo
        Beside investigating data leak: reviews, docker fixes, and Jira maintenance.
      • Fin, go reosarevok!
      • reosarevok
        Hi!
      • I looked into the leak stuff a bit more (mostly checking bitmap's code a bit)
      • Fixed a couple small issues where the JSON WS was returning unexpected stuff
      • And played quite a bit of AC Valhalla, which is a buggy mess but still fun
      • Now I've been looking at tickets that are for some reason assigned to me
      • CatQuest hides
      • And trying to figure out why and what to do about it
      • CatQuest: not only that, also a bunch of MBS and AREQ and whatnot :)
      • CatQuest
        :D
      • reosarevok
        Anyway, next. CatQuest, since you're here :p
      • CatQuest
        Meow! `😺`
      • Have worked on the BookBrainz edition types and work formats!
      • Now working with Mr_Monkey and others to improve this!
      • Continuing to add things to BookBrainz - recently I have read several books!
      • Today was a lunar eclipse I didn't see :(
      • And, altought there is a monday between now and then, I will say that my birthday is on the ninth, because on the fourth we have another Bandcamp-Friday! ;)
      • fin, go freso!
      • Freso
        (Passing to alastairp rn, I can go after.)
      • alastairp
        hello
      • CatQuest
        ok, go alastairp !
      • alastairp
        I didn't get a lot done last week, it turns out that a 2 day sprint on playlisting really takes it out of you
      • I'm getting too old for this
      • ruaok
        you????
      • sheesh
      • alastairp
        :)
      • Freso
        (Also, I’m the only one left on my list, so also last call for anyone else who may want to give review this week. :p)
      • alastairp
        I did spend some time on some Listenbrainz improvements. I added the ability to run unit tests against the timescale database, and I opened a bunch of tickets related to improving the workflow that we have for running tests and development environments
      • and unfortunately, that's really about it
      • I did make a bit of a list of all of the MeB things that I seem to have got myself involved with, and it's quite big. I'm going to have to take a look at what's on my plate and work out how to prioritise based on what everyone needs from me
      • ruaok: might be a good thing to take some time on weds to talk about
      • Freso: next pls
      • ruaok
        amen.
      • Freso
        o/
      • CatQuest
        \\o
      • Freso
        Another another slow week for me. :/ Didn’t get much done, other than trying to prod a bit at the usuals. Also, celebrated my birthday virtually with some friends/comrades.
      • fin.
      • And that seems to be it for reviews, unless someone quickly shouts out that I forgot/missed them, or that they want to go…
      • If not, thank you everyone who gave reviews!
      • One more item on today’s agenda…
      • reo: punycode urls
      • CatQuest
        reosarevok:
      • Freso
        Or maybe that’s for next week…
      • yvanzo
        just a note about mailing for data leak in the meantime
      • Freso
        yvanzo: note about mailing for data leak
      • :p
      • reosarevok
        Hi!
      • Sorry
      • yvanzo
        ruaok: It seems to be the best option indeed, so that everyone knows if his/her account is personally affected or not.
      • reosarevok
        Was quickly researching an instrument. I'll go after yvanzo
      • CatQuest agrees with yvanzo for once :D
      • yvanzo
        And it doesn’t bother users who are not.
      • CatQuest is legit curious if they will get an email or not in this
      • Someone suggested to show a banner on the website just for affected users, but it would be take more time to implement/deploy, and inactive users would not be informed either.