#metabrainz

/

      • ruaok
        yvanzo: ok, I think its the right course of action.
      • please proceed to do this and to draft up a statement that we can post to the community page.
      • (including ho wlong it will take to get the emails out)
      • yvanzo
        reosarevok already did that
      • CatQuest
        didn't reo actually post a yes
      • reosarevok
        I didn't draft anything for the forum
      • But I can
      • CatQuest
        but emails
      • ruaok
        reosarevok: plz do.
      • reosarevok
        Yes, but the idea is to tell them we're going to send emails. Will do :)
      • ruaok
        ding.
      • CatQuest
        punycodethingies?
      • ruaok
        ok, thanks reosarevok, thanks yvanzo !
      • yvanzo
        reosarevok: punycode?
      • reosarevok
        Hi!
      • So: I submitted a fix for MBS-11258
      • BrainzBot
        MBS-11258: Internationalized domain cannot be entered as homepage for an artist https://tickets.metabrainz.org/browse/MBS-11258
      • yvanzo
        reosarevok: no problem, I will post to the forum about that.
      • reosarevok
        But then I noticed this was an older issue (MBS-9674)
      • BrainzBot
        MBS-9674: URLs with IDN domains not considered valid https://tickets.metabrainz.org/browse/MBS-9674
      • Freso
        (TFW you open a Jira ticket and find out you were the one reporting it…)
      • reosarevok
        And that we have another ticket (MBS-8683) that suggests we at some point planned to store these in ASCII encoding and decode for display only
      • BrainzBot
        MBS-8683: Display internationalized domain names in decoded form https://tickets.metabrainz.org/browse/MBS-8683
      • CatQuest
        Freso: ikr? :D
      • reosarevok
        (I'm putting this on the meeting rather than just talking to MB devs because maybe it is relevant for Mr_Monkey / BB too at least)
      • bitmap
        yes, I checked and it seems we don't store any urls with non-ascii characters in the DB (we canonicalize IDNs to punycode already)
      • reosarevok
        Do we canonicalize them actively, or did we just block the non-ASCII chars by accident so that nobody could send them? :)
      • That's what I was not sure about
      • Mr_Monkey
        Interesting
      • bitmap
        we do URI->new($url)->canonical in find_or_insert so it's done right before they're added
      • reosarevok
        If we do it intentionally (or we ever agreed we should do that) then we should be allowing the URL to be submitted but just store it encoded
      • CatQuest
        huh but I could have sworn I had added unicode (japanese glyphs) style urls before
      • reosarevok
        Yes, that's different :)
      • CatQuest
        oh
      • reosarevok
        (but IIRC those do get encoded too)
      • CatQuest
        yea they do. ugly af too
      • bitmap
        but yeah, we should accept either as input, but continue to store as punycode
      • reosarevok
        Ok. So I guess we should be able to tell it's a duplicate and block the submission then? :)
      • (which I assume we can't do now)
      • bitmap
        yup, if we code it
      • reosarevok
        Sure, I mean, we want to do that, I assume. Ok. So, always store as ASCII, always display as unicode? :)
      • CatQuest
        yes plox
      • and for things like edit notes too?
      • bitmap
        +1 to 'store as ASCII, always display as unicode'
      • CatQuest
        +1 too
      • (again)
      • Freso
        As reporter of MBS-9674, +1 :p
      • reosarevok
        CatQuest: I assume for edit notes they'll just be displayed as they get pasted, I don't think we currently do anything to URLs there now - if you think we should, maybe that's a separate ticket (and would also be relevant to stuff like the JP ones you mentioned)
      • BrainzBot
        MBS-9674: URLs with IDN domains not considered valid https://tickets.metabrainz.org/browse/MBS-9674
      • reosarevok
        Ok, that's about it then, thanks!
      • Freso
        Alright. That wraps up today’s meeting then!
      • Thank you everyone for your time! Stay hydrated, and do something kind to/for yourselves! 😄
      • </BANG>
      • Mr_Monkey
        Ciao !
      • CatQuest
        reosarevok: tbh my one gripe with links in edit notes is that they get shorted ... visually so i can't copy-paste edit notes fro msoemwhere to somewhere else beasue links don't get copied proerly
      • you too freso
      • reosarevok
        Yes, I hate that too tbh
      • Although I get why we do it
      • sumedh has quit
      • CatQuest
        i wish there was a prefrence for it tbh
      • Freso
        I wish it could be toggle per-message. Most of the time I’m fine with them being truncated, but every so often I’d really like to just copy/paste a message.
      • CatQuest
        oh yea that's a good idea a toggle
      • v6lur has quit
      • yvanzo
      • ruaok
        +1
      • thomasross joined the channel
      • reosarevok
        Seems good to me :)
      • yvanzo: do you want to post it or should I?
      • yvanzo
        reosarevok: I just did :)
      • Thanks ruaok and reosarevok!
      • abhinavohri
        @alastairp I am fine. How are you? I am facing some issues in my PR. All the tests are passing offline but some tests are failing online. https://github.com/metabrainz/critiquebrainz/pu... https://github.com/metabrainz/critiquebrainz/pu... .Also, in the second PR, i used rating and the test results were passing offline but failing online so i modified and used latest-revision.rating but the test
      • results were same.
      • alastairp
        abhinavohri: right, that's strange that it works for you but not online. No problem. I'll check out the code myself and see if I can work out what is going on
      • abhinavohri
        @alastairp ok . Thank you
      • abhinavohri has quit
      • Nyanko-sensei has quit