#metabrainz

but jeez

Over the weekend BenOckmore reported that the BB last dump on the ftp was early last month. I spent a bit of time investigating the issue and finished fixing it today.

Now to implement an email server to receive cronjob failure alerts !

!m BenOckmore & Mr_Monkey

You're doing good work, BenOckmore & Mr_Monkey!

That's it for me.

ruaok: go !

yoyoyo

CatQuest: As a Dane, I’ve said a lot of bad things about Sweden this year.

lol

last week was a lot of playlist hacking and also working up some data for the LB xmas present.

if you've been submitting listens to LB, you should be able to see the tracks that you first submitted in 2020 here:

this is for mr_monkey, for example.

🐒

<3 Vibe Killer

amazing work! so nice to see all of this work over the last few years turn into super simple "get results quickly" infrastructure

I have never heard (of) Endless Boogie before but awesomename!

the idea is to make two playlist for people in the next couple of days: tracks that you discovered in 2020 (well submitted first) and tracks released in 2020 that you played a few times.

alastairp: thanks.

so, yes, it is now easy to produce some pretty complex things with all the work we've been doing.

we've hoping to release the playlist stuff in production, but call the playlist features "beta".

huh so lastfm import no works

we need it in production in order to be able to make the playlists for other people.

I really hope we can finish this before xmas. 🤞

_lucifer: go

Hi! all

I worked on improving the tests so that the resources (sample xml files) used in MB SOLR become human readable and easier to review.

(Only jmp_music__ left on my list! Last call for anyone else who wants to give review!)

Further, as yvanzo completed the work in the sir part, I updated my PRs in the solr for merging.

That's it for me.

jmp_music__: next?

Or maybe jmp_music__ is not around. :)

Alright, final item on the agenda:

Freso: Next meeting

i januar

So the next meeting will be on January 4th!

And that’s all for this item. :p

Still no jmp_music__

🎄

So I guess that rounds out the last meeting of this year.

Happy holidays to all!

Thank you everyone who gave reviews, everyone who was around, everyone who’s worked on any of all our projects over this year!

Buenas Fiestas !

God Jul!

Take care of yourselves this holiday season, happy celebrations if you celebrate, and remember to still adhere to all the guidelines. The pandemic is not over yet, so stay safe! ❤️

</BANG>

alastairp: aroun?

Thanks Freso!

Thanks Freso!

alastairp: when do you want to get moving on the playlist stuff?

ruaok: I just pushed, collaborator tests are working now

did you make the changes to the API layer too?

I'm continuing to work on other improvements, but they're not necessary for your stuff. what do you think is next?

yes, I fixed the API

great, thanks!

I think the next thing to do is to consider what remains to be done for us to merge this PR.

should I do a quick 15 minute review?

5 minute even

that would be great.

my code has no more TODOs in it, so I think I am done. which would be great, so I can focus on the troi work this evening.

ok, sounds good

I didn't do private collaborating playlists, will look at that after the review

Mr_Monkey: did you add the new spotify permissions?

Yes. It'll require users to un-link and re-link their account, and there's a prompt for that if the permissions aren't set for playlists

ah, I guess I didn't get to that part of the code

good-o

_lucifer: hi, sorry. didn't see your question

alastairp: I hope to resume work on CB in the coming days and wanted to discuss a few things beforehand in case you are unavailable at that time.

sure! what's on your mind

i just took a look on my pending PRs. the artist and recording ones need tests, i'll try to take that up first. what's the status of the mocks pr? I saw your comment on it.

I think if possible we should just increase the timeout for now and merge it

and handle the db image part separately

yes, let's just increase the timeout for now

give that a go and see if it makes the tests pass

sure, will try that and let you know if it works.

what else do you have in mind for future work?

any particular tickets or should i pick up any?

just the stuff off the next ticket I guess

'next' version, I mean: https://tickets.metabrainz.org/projects/CB/vers...

honestly, there's not really anything which strikes me as more urgent than any other thing

oh, right. i had forgotten about the `next` version thing.

the DB tests in BU would be another thing to look at - update the config settings and get CI working, and then add tests and fix those bad queries

yeah, right. i'll add that to the list.

I think that's probably the most useful thing to do next

yup, makes sense.

that's all i wanted to talk about. Thanks!

great. have a good week!

I'm around all week until the 24th

have a good week you too! nice, i'll be in touch.

how goes the 5 min review, alastairp ?

`for collaborator in jspf["playlist"]["extension"]["https://musicbrainz.org/doc/jspf#playlist"]["collabortors"]:`

CORLABORTOR

ruaok: fruitful ;)

and the tests passed?? O_O

review done

I think there are only 3-4 things that should be addressed for this release, everything else can be improved after the fact

ok, I'll see about getting all the comments addressed this evening.

alastairp: was the public in the arg only about not having it in the JSON? I thought there was more to it than that... but I cant recall from the haze of hackdays.

alastairp: still about?

ruaok: hi, for ~15m more

I'm pretty sure that the public arg was because there was nowhere else to put it

aight, lets hammer out two issues, should be doable.

which means that we must have decided to not put it in the json?

ok, I can't recall another reason. I'll make that happen, since it is in the json and the UI needs the flag.

ah right, that's why it's there. good idea

I'll do it between commits so if it asplodes then I can back it out.

comment about listenbrainz/tests/integration/test_playlist_api.py line 654...

currently there is not `playlist_count` field.

*no

mmm, but online 625 you check playlist_count?

on line

I dont see what you are referring to.

self.assertEqual(response.json["playlist_count"], 2)

ok, now your comment makes sense. thanks.

when you query with ?offset=0&count=1, I understand that you should get 1 playlist back, but there should be a field that says that there are 2 playlists in total matching this query

yeah, understand what you are saying now.

> 'count' is the parameter

ok, the rest should be doable.

was probably a bit unclear

nic

nice

I'll add tomorrow morning the private flag to the collaboration db method

and hook it into the api

k

good, because tomorrow I need to be 100% on troi.

The guy is asking for a bitcoin deposit lol

ha!

I know ****** is one of your password on day of hack..

Lets get directly to the point.

Not one person has paid me to check about you.

You do not know me and you're probably thinking why you are getting this email?

in fact, i actually placed a malware on the...

and it goes on

it's an old password though, not using it anymore :)

wait. hang. on.

an MB password?

I think it was yeah in 2019

but I changed it

was something guessable?

nope, not even a word from the dictionary

yvanzo: bitmap reosarevok : did we miss something in our audit???