ruaok: whenever you have some time, do check the "Edit notes linking to a download server with MP3" email and make sure you agree with my take, please :)
D4RK-PH0_ has quit
Nyanko-sensei joined the channel
hlecuanda has quit
sumedh joined the channel
CatQuest
reosarevok: tha's it's a bad idea?
sumedh has quit
alastairp
morning
!
yvanzo
mo’’in’
davic joined the channel
ruaok
moin!
BrainzGit
[listenbrainz-server] alastair merged pull request #1215 (master…docs-content-type): Document that Content-Type header is required for submit-listens https://github.com/metabrainz/listenbrainz-serv...
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='labs.api.listenbrainz.org', port=443): Max retries exceeded with url: /recording-mbid-lookup/json?count=1 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7ff9f15d7fd0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))
I wondered if it was docker networking issues due to the docker-in-docker setup that we have for jenkins, but I tried to simulate it myself and it seemed to work fine
Gazooo79494 has quit
Gazooo79494 joined the channel
sumedh joined the channel
ruaok
Zas is better at that i...
zas
alastairp: likely missing dns config somewhere
it'd be intesting to dump content of /etc/resolv.conf
and /etc/docker/daemon.json for docker daemon config
alastairp
I'll have a look
zas
check if you have any resolver set ('dns' key for /etc/docker/daemon.json)
alastairp
however I did log into williams, docker exec to jenkins, then docker run a container. and inside there, `ping` successfully resolved the domain name
zas
hmmm, perhaps a python thing then
alastairp
yes, I'll look at that next
ruaok
zas: perhaps review the lb.org DNS records? did I make a mistake?
zas: yes, there are a number of exceptions there, and it's possible that the cause is due to that
however, tests succeed when run locally, they only fail on williams/jenkins
_lucifer: hi, what do you mean by "the follow server is going to be removed soon"?
I wasn't aware of that, maybe we had some discussions in the office that we didn't share to you about our plans
_lucifer
alastairp: ruaok had shared some days ago that the playlist feature is to replace the follow server
alastairp
right, that's possible :)
zas: I have reproduced the error. it doesn't appear when I use `docker run` from inside jenkins, but it appears when we use docker-compose and our compose config file
so it's very likely that it's due to the docker-compose network
zas
do you have dns: key in docker-compose.yml ?
alastairp
no
sumedh has quit
zas
alastairp: try adding one pointing at 8.8.8.8 to see if it changes anything
alastairp
yes, I just noticed. jenkins has 8.8.8.8 in its resolv.conf, lb tests have 127.0.0.11
it doesn't seem to be overriding the dns of the container. I'm looking into it more to see if it's because of our docker-in-docker setup
it's using a new network - jenkins is on 172.17.0.blah, but inside the listenbrainz container it's using 192.168.112.6
I'm going to configure it to use the host network instead of making its own
ruaok
reosarevok: I kinda think we ought to be more proactive and remove that link from that edit.
sumedh joined the channel
reosarevok
Ok, in that case we also need to be more clear about that (IIRC we only mention "don't link to such sites" on relationships)
We have to think about what happens when such a link is being given to prove a bootleg release, too :)
(since that might be the only proof the whole thing exists)
ruaok
let's be more clear, please. can you adjust the docs and follow up with the user?
reosarevok
Not until we know how to do so
Do we want to block *any* links on any edit notes to any download sites / pages?
ruaok
zas: our hosting credits with Google cloud have run out and we're unlikely to get any more.
reosarevok
And if so, what do we do with cases where that's the only available source of data
Do we make an exception for those?
ruaok
going forward lets make sure that we use our resources there wisely and see if we can run most of our stuff at hetzner.
reosarevok: seems fine.
reosarevok
We will also need a way to modify edit notes that doesn't require direct DB editing
But I guess that'd then be my job :p
ruaok snickers
And I guess a COC of who is allowed to do so (admins?) and for what reasons
(since this isn't something we've actively done before)
ruaok
jeez, lots of work. :(
I just wanted to remove one little link, lol.
reosarevok
I know :D That's why I was going with "well, it's an edit note, it's not really public unless logged in, maybe it doesn't matter" :p
ruaok
aight, lets leave it be then.
reosarevok
But long term anyway we *will* want a proper way of doing this (also for like "X insults Y" or even "X doxxes Y" situations)
I'd suggest leaving it be for now, but starting work on a good way to do all this
And once we have that, we can be more proactive and also ask the community to report infringing links for us to remove
We will need to do that if we ever want to open edit notes to logged-out viewing anyway (which is not something we will certainly want, but it's also not something we will certainly never want)
Sounds good to you?
ruaok
it does, thanks.
good forward thinking!
reosarevok
I also recently wrote some "search in edit notes" code, so that would allow us to find more links if we are pointed to one
(it also allowed me to find a fair amount of notes containing "fuck you" :p Although not all are directed against another person)
ruaok
wow. the UK won't extradite assange. he got really lucky.
reosarevok
yvanzo: assigned some more https cleanup to you, hope you don't mind :)
ruaok
Mr_Monkey: alastairp Freso zas : invoices please!
Mr_Monkey
Oh, right. New year.
alastairp
wait, what day is it?
is it bed time yet?
ruaok
ah, no not Freso, sorry.
alastairp
zas: I think I'm going to need your help on this. It's possible that there's a firewall issue preventing things from getting out of williams
reosarevok
"preventing things getting out of williams" seems like an euphemism of some sort for keeping stuff under control
I like it
alastairp
we're using this docker-in-docker pattern, by mounting the docker control socket of williams into the jenkins container. This means that inside jenkins running `docker whatever` will use the main williams container without having to actually run docker twice
however, when we run docker-compose for our tests, it creates a new network (e.g. 192.168.114.0/20). The gateway of this network appears on williams (192.168.114.1), and I can ping it from the container
yvanzo
reosarevok: no problem, will check after lunch.
alastairp
I was thinking of flattening the network out, and using the jenkins network as an `external`. However this won't work, because we run the same tests multiple times simultaneously. If we shared a network then we'd have a conflict with the same container names in different test executions
ruaok
hmmm, I think SEPA and even US wire payments all got faster in 2021. neat.
alastairp
maybe some banks rolled out sepa instant? transferwise -> bbva is always immediate for me
ruaok
likely. paying freso got faster. lets see if zas did as well.
zas: let me know when the payment arrives, please.
and end of year. no technical work for me until wednesday at the earliest.
reosarevok
Not a believer in Ballmer peak?
Here all the celebrations are gone. I kinda wish we had Reyes Magos now :p
alastairp
didn't you hear? we turned them away at the port for not having a negative test
yeah, they're "here", and letter delivery is open, but that's about it
reosarevok
Heh. Two of my friends flew in from Scandinavia and back for Christmas (very responsible of them, I know...)
Nobody even checked their tests or anything
ruaok
alastairp: ha, that would be the first time someone was *actually* checked at a spanish border that is not an airport.
the requirement of a negative PCR test seems to only apply to people flying.
alastairp
yeah, I thought it sounded a bit far-fetched even as I wrote it
reosarevok
This was flying, FWIW, so they don't even check that properly
Freso: I'd love your feedback on MBS-11312 and especially on the things that should qualify as "we will remove this from an edit note". I'm expecting "personal info" on self-request, and "spam, insults and piracy" on report, but :)