#metabrainz

/

      • cyclone has quit
      • Nyanko-sensei joined the channel
      • D4RK-PH0_ has quit
      • davic has quit
      • d4rkie has quit
      • d4rkie joined the channel
      • BrainzGit
        [bookbrainz-site] LordSputnik opened pull request #546 (master…webpack5): Migrate to Webpack 5 and improve bundle size https://github.com/bookbrainz/bookbrainz-site/p...
      • adhi001 joined the channel
      • vasharma05 joined the channel
      • sumedh joined the channel
      • ephemer0l has quit
      • yvanzo
        mo’’in’
      • updating beta.mb.o
      • Lyto joined the channel
      • Lyto has quit
      • sumedh has quit
      • updating mb.o
      • antlarr has quit
      • sumedh joined the channel
      • antlarr joined the channel
      • done with both
      • vasharma05 has quit
      • reosarevok
        !m yvanzo
      • BrainzBot
        You're doing good work, yvanzo!
      • yvanzo
        reosarevok: blog post is available for review
      • reosarevok
        Lemme see
      • yvanzo: added one word, seems fine to me :)
      • Thanks!
      • Lyto joined the channel
      • sumedh has quit
      • ephemer0l_ joined the channel
      • sumedh joined the channel
      • alastairp
        hi Lyto and _lucifer, the link appears to work for me too - take note that it's on an ftp site, not http and your connection may be doing funny things with it
      • _lucifer
        alastairp: hi!
      • yeah that's a poosibility
      • I have added the tests for editor to BU as well. These database tests however only work with Python3. I tried testing with Python2 but they fail due to some encoding errors.
      • It might be possible to make the tests work with Python2 byt changing the test data used but I am not sure if its worth the effort.
      • alastairp
        specifically, chrome (and I believe firefox now too?), don't support ftp natively any more. on my mac it passed off the download to finder.
      • I don't mind not supporting those tests in python2
      • early this year I should look at finalising the python3 migration for AB
      • _lucifer
        I'd like to help with that :)
      • alastairp
        great
      • really, the main focus here is jmp_music__'s work on integrating scikit-learn.
      • we have to make sure that it's integrated through the whole model training pipeline, and then ensure that the models using both the old and new system are approximately equal
      • we did a lot of work on that over the last year, so I'm quite happy with it
      • _lucifer
        I do not have any other particular tasks at hand currently so I can take that up.
      • Is there some document or ticket which I can read to get upto date on work, alastairp ?
      • Darkloke joined the channel
      • alastairp
        great, let's organise a time to have a quick chat with jmp_music__ about what he's done and what's missing
      • Gazooo79494 has quit
      • I'll write up some quick notes about all of the things that we need and we can see what step we're up to
      • Gazooo79494 joined the channel
      • _lucifer
        great, thanks!
      • alastairp
      • iliekcomputers
        hello
      • happy new year!
      • alastairp
        these are the 4 key features that we need. We're still looking at testing the first two items, but you could definitely continue with the third one
      • iliekcomputers: !!!
      • hi! how are you?
      • ruaok
        moin!
      • hi alastairp, hi iliekcomputers!
      • long time no see!
      • iliekcomputers
        alastairp: good good, last 3 months at work were quite busy. i took 3 weeks off for the new years, just getting back now. :D
      • congrats on shipping the playlists, they look really nice!
      • ruaok
        thanks. loads of cleanup still...
      • iliekcomputers
        ooh, we moved off travis to jenkins, nice
      • ruaok
        we got a lot of shit done in the past 3 months. :)
      • alastairp
        yeah, trying to follow your lead in lots of small incremental improvements
      • zas
        Hey iliekcomputers, happy new year to you too!
      • _lucifer waves at iliekcomputers
      • iliekcomputers
        hey zas, _lucifer !
      • alastairp
        zas: I cleaned up ~10gb of images from williams, but I think that the amount of free space is low enough that this will always be a problem if we don't move stuff
      • do you have some thoughts? I'll try and update test scripts to clean up better, I don't know why they weren't doing it
      • otherwise we look at moving jenkins? :/
      • ruaok
        if jenkins is using the disk space, then lets.
      • having the FTP site AND jenkins on one machine is bound to create diskspace issues.
      • lets find a machine that has more free diskspace and move there. it would be easier than moving the FTP to the storage box.
      • which would likely affect FTP speeds.
      • alastairp
        theoretically, if we get it to clean up after itself it should use no more than 1 version of the image per test run
      • but that's still looking at many gb given how many tests we have now
      • yvanzo
        my guess is that recording's first release date increased search indexes dumps and maybe JSON dumps too.
      • ruaok
        it still sounds like a diskspace heavy task that might be best elsewhere.
      • yvanzo: very likely yes.
      • alastairp
        OK. I'm happy to try and tackle the migration if someone suggests a new location
      • ruaok
        zas: do you have an idea for another server?
      • alastairp
        iliekcomputers: hey, while I have you here, can you give my user (alastairp) on readthedocs admin on listenbrainz? I see that you're the only other admin there :)
      • iliekcomputers
        yes, sure.
      • alastairp
        ruaok: you asked me to ping you after we had finished doing playlist stuff to remind you to configure https on similarity.acoustibcrainz.org on bono
      • ruaok
        ah yes.
      • where does that installation live, again?
      • alastairp
        /home/acousticbrainz/acousticbrainz-server
      • using the docker-compose.yml file in that directory
      • ruaok
        I think your docker-compose foo is stronger than mine... I just got used to using docker run commands from a shell script.
      • alastairp
        what needs doing?
      • ruaok
        making a gist
      • alastairp
        Mr_Monkey: ruaok: I'm teaching the next 3 weeks on weds and thurs, plus the newer restrictions and recommendations I'm not sure I'll make it into the office this week
      • maybe next week I'll see how things are going and see if Friday works
      • ruaok
        agreed, this week I have too much other stuff that needs doing.
      • friday would be better than wed for me now.
      • alastairp
        ruaok: is the network flag necessary for LE, or is it just what you use to link your containers to have access to the mb database?
      • Mr_Monkey waves at iliekcomputers
      • ruaok
        alastairp: LE
      • Mr_Monkey
        alastairp: Sure, I was also thinking of staying in this week at least
      • ruaok
        but its both, really, alastairp
      • alastairp
        can you please un-vim?
      • ruaok
        done
      • but what the LE container does is look for HTTP ports that get exposed from containers. if it finds some and these magic variables are set, it configures the HTTPS LE bits and the proxy.
      • once you bring your container up, look at the output from the le container.
      • alastairp
        btw, I suspect that the trick that you were after was this: https://docs.docker.com/compose/networking/#use...
      • to link to an external network you have to define it first before using it in the service
      • ruaok
        yes, I've used that trick before.
      • and I have that code laying around in some docker compose file, I just couldnt find it last time I looked.
      • oh. funkwhale on a personal VM. heh.
      • outsidecontext
        ruaok: just in case it helps: what I use as a setup in a lot of projects is having nginx proxy + letsencrypt installed with the compose file at https://github.com/phw/docker-nginx-proxy-letse...
      • ruaok
        we use the same stuff. yay. :)
      • alastairp
      • outsidecontext
        with a separate project. then the actual project also uses the same network + the variables
      • alastairp
        that's some serious black magic, thansk!
      • ruaok stars the project
      • ruaok
        alastairp: yeah, I'd normally be opposed to that, but it turns out to be quite solid.
      • alastairp
        Mr_Monkey: dry hopping now
      • Mr_Monkey
        Yum !
      • yvanzo
        updating mb.o for logs sanity
      • iliekcomputers
        alastairp: what's your username on rtd?
      • alastairp
        alastairp
      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1855 (master…MBS-11324): MBS-11324: Trim input in the barcode otherlookups field https://github.com/metabrainz/musicbrainz-serve...
      • iliekcomputers
        added
      • alastairp
        thanks
      • ah, now I can see the build failure
      • reosarevok
        yvanzo: logs sanity as in?
      • yvanzo
        reosarevok: thanks for the blog post, I just published it.
      • reosarevok: checking cover art presence, see https://github.com/metabrainz/musicbrainz-serve...
      • BrainzGit
        [musicbrainz-docker] release v-2021-01-11 has been published by yvanzo: https://github.com/metabrainz/musicbrainz-docke...
      • yvanzo
        reosarevok: it was bugged already but rarely triggered until then.
      • reosarevok
        Oh, ok. Good catch, thanks
      • yvanzo
        Good catch from zas actually ^
      • reosarevok grumbles at MBBE-31
      • reosarevok
        New stuff that needs changing keeps appearing even before I'm done with the previous one :D
      • yvanzo
        updating beta.mb.o too
      • zas
        ruaok, alastairp: you want to move jenkins somewhere else? can it run on a hetzner VM? does it depend on mb-hetzner infrastructure (consul etc...)?
      • alastairp
        it has no requirements on other hetzner infrastructure
      • although I think bitmap has a few processes that do work on jenkins and then put the data somewhere, but I guess that's just an rsync
      • zas
        ok, let's wait for bitmap then, and we'll decide what to do
      • ruaok: I thought about kiki, I think we should just replace the machine, with new OS & SSDs, but can we still have the second interface as an option? I would go for AX41-NVME since they provide more cores. That's the time to upgrade our scripts to fit new Ubuntu versions.
      • So the plan would be to switch to herb (fully, with mbstats)
      • and just replace kiki hardware
      • then I need some time to configure it properly and adapt scripts to new OS, so we are a bit weak for few days... (herb's failure is always possible)
      • or do we have one rack space left?
      • ruaok appears from the office