#metabrainz

2 days is pretty good lol

I really want to see a histogram of that, because I bet there is 50% merged within a few hours and a whole bunch of other things that take weeks and weeks

zas: are you familiar with this redis error? https://sentry.metabrainz.org/metabrainz/listen...

I believe LB is just using the main redis service, I don't know exactly what action was happening here to cause this error

> ResponseError: MISCONF Redis is configured to save RDB snapshots, but it is currently not able to persist on disk. Commands that may modify the data set are disabled, because this instance is configured to report errors during writes if RDB snapshotting fails (stop-writes-on-bgsave-error option). Please check the Redis logs for details about the RDB error.

ruaok: do you know what https://github.com/metabrainz/listenbrainz-serv... is?

more specifically, it appears that it's not referenced anywhere, so I guess we're dealing with this on the gateways instead. looks like a candidate for deletion. do you agree?

at first glance it appears to be part of the last.fm compatible API.

which does not go through the gateways -- it actually exposes a port on lemmy.

it's installed in https://github.com/metabrainz/listenbrainz-serv..., but I can't find a build script that uses this Dockerfile

mm

I see, on lemmy it's called listenbrainz-api-compat-nginx, and uses an image of the same name. But I can't see where it's built from. Is it possible that we built this as a one-off and are missing docs describing how to use it?

I don't recall, sorry.

OK, so I won't blindly delete it.

maybe its not built, but just using standard docker images?

last pushed: 3 years ago. that matches with the commit date

and it's actively used in start_listenbrainz_api_compat_nginx() in docker-server-configs

it's a standard nginx image with a single config file added

that sounds about right.

will open a ticket to remind us to add instructions to the build tools

alastairp: which redis does lb use? this error can be due to perms issue or disk full

zas: according to https://github.com/metabrainz/listenbrainz-serv... it uses a service `listenbrainz-redis`

which is just the normal `redis` image with no additional config, according to start_listenbrainz_redis()

[listenbrainz-server] MonkeyDo opened pull request #1241 (master…LB-796): LB-796: Correct link to playlist exported to Spotify https://github.com/metabrainz/listenbrainz-serv...

I see that start_redis() configures a volume for /data as described in the readme at https://hub.docker.com/_/redis, I think we should consider doing the same for LB and CB

alastairp: your redis instance is missing persistence config

yes, I just noticed. not my instance :)

I'll open a ticket

you need a volume and --appendonly yes

alastairp: remind me, there was a pip config snafu last year and we needed to change something in our config to avoid it -- what was the change?

install exactly the version of pip that's in the LB Dockerfile

or wait a day for me to release a new version of BU and update to that

this is for meb.org ...

> requests 2.20.0 requires idna<2.8,>=2.5, but you'll have idna 3.1 which is incompatible.

is the immediate issue I'd like to resolve.

yeah, look for the `RUN pip install pip@exact-verion` in LB

ok

RUN pip3 install pip==20.2.4

yeah, that's the one

reosarevok or yvanzo : Hi! Could one of you two (not sure who has JIRA admin rights) please change the default ticket assignment for ListenBrainz? It's currently still param.

In BB's Jira the tickets are unassigned by default until someone claims them; I'm suggesting we do the same.

rebooting grafana machine, expect alerts

oh good. the world needs more lerts. :)

alastairp: > brainzutils 1.8.0 requires werkzeug==0.15.0, but you'll have werkzeug 1.0.1 which is incompatible.

ah fuck

heh.

this causes nearly all meb.org tests to fail.

mmm, I think this is tending towards being fixed by https://github.com/metabrainz/brainzutils-pytho...

Mr_Monkey: yes, can do that, should I just left it unassigned?

BU is up to 1.15, so we should probably update that in MeB

Yes please yvanzo :)

I guess currently nobody is directly in charge of LB in a manner that they should be responsible for taking care of tickets, and we share the load, so unassigned makes the most sense to me.

oh, BU 1.15 that problem. so, thats good.

Mr_Monkey: 1197 looks good now

I hope to merge and release it soon!

Yep, I'm reading it as we speak :)

Mr_Monkey: Done, LB has no more project lead in Jira, and new tickets will be unassigned by default. I did not update existing tickets though.

Thank you !

(project lead is mandatory, so it is set to "We want you!" instead)

ruaok: http://smarden.org/runit/runsv.8.html

> runsv switches to the directory service and starts ./run. If ./run exits and ./finish exists, runsv starts ./finish. If ./finish doesn’t exist or ./finish exits, runsv restarts ./run.

so, looks like we can hook into `finish` to send a log message? Not sure if we can get the return code of `run`

very promising!

Mr_Monkey: can we fix a day to merge and release? And then ruaok can use it for BP so that we don't have "51 years ago anymore" And we can start collecting feedback

I could do a release once a couple of PRs are merged. so, lets focus on getting PRs merged and then I'll do a release.

Mr_Monkey: thnx for quick fix

are there any al1ens of t1me travlers here? I need your help

I think you have the wrong IRC channel

they tend to disguide themself and be amoung concerts, tourest, politics,

<shivam-kapila "Lorenzo: ideally they should go "> Lorenzo: Hi folks, regarding this request, right now it is the 18th of January, is it normal to still see stats in the report related to listens that I've wiped from my library in late December?

lorenzuru: Hi. don.t think so. Can you share your LB profile and some info about those wrong stats you are seeing?

Here's the wrong report I'm talking about: https://listenbrainz.org/user/lorenzuru/reports...

I've done a complete library wipe in late December 2020, and I'm assuming everything prior to that shouldn't be displayed in the reports, right?

It should be. you only have 1141 listens but stats are according to 30k listens

Yeah, that's approximately my number of listens prior to the library wipe

ruaok: when you're free can you please take a look on when a full import was last imported into the Spark cluster. looking at the cron tabs it should have been imported yesterday

It's National Thesaurus Day!

Freso can't be with us, so I'm your FakeFreso for the day.

I've got one mailed-in review, and you'll never guess who sent it.

Freso said:

"""

Haven’t gotten anything done this last week, except for stressing over

my exam assignment, which I am also almost certainly stressing over this

very minute. 😬

"""

Good luck with the assignment, Freso!

People up for reviews tonight: Mr_Monkey, yvanzo, shivam-kapila, _lucifer, bitmap, CatQuest, ruaok, alastairp, jmp_music, reosarevok, zas – anyone else who wishes to give a review, let me know ASAP. :)

CatQuest: go!

Or maybe I'll bring it back to you :) ruaok: go!

k

last week was a bit slower than hoped, still ramping up...

the usual background stuff for Meb, but that is now done. I'm finally back on tech work and reviewing PRs.

I did a bit of work of cleaning up the dangling bits that were left over from the xmas present and the playlist hacking spree.

glad to be back on that.

also been thinking about how to upgrade consul -- alastairp and I chatted at length about that.

I think we can make some really nice improvements there.

"glad to be reviewing PRs". Wow. The previous bit must have been awful :p

fin. zas!

hey

reosarevok: accounting. 'nuff said

I mainly worked on registrator replacement

discovered a lot of features in consul/docker/registrator we don't use (some useful, some not)

plus planning kiki's upgrade (we'll replace the machine, not urgent)

uhm sorry

and usual stuff, supervision, upgrades, Picard code reviews

fin. Mr_Monkey ?

CatQuest: no worries :)

Heyo !

i kinda need ot do a thing :/

hi!

If you need to go first CatQuest , then go :)

nah it cna be after you :)

OK

Last week I've been working on BookBrainz and ListenBrainz build setups

And reviewing PRs for both projects

I also worked on finishing small PRs and unfinished fixes for BookBrainz, nothing big but tying up loose ends feels good

Finally getting back in full steam, took a long time

And that's it for me! CatQuest Go !

Meow! `😺`

Mostly I've been ediing not "working" - it's a very big box of british beat bands.

Worked on disambiguating these. Most of these are wrong so have to add new, in the same vein I add some rare 45's and suches. and I disambiguated "Blue chips" artists and cleaned up recordings

These aren't InstrumentBrainz or BookBrainzStyle, but I'm getting to that later this week :D

♐

fin, go bitmap

hey

last week I mostly worked on updating https://github.com/metabrainz/musicbrainz-serve... with selenium tests for the CAA

which are the first integration tests we have that actually test MBS and the artwork indexer/redirect services all together

Neat!

fixed a few minor things in the artwork-indexer I found while working on that

I like tests as long as I don't have to write them :D

Is this still preparations for EAA?