ok. fixed and deployed. sentry seems clear. but will need to check the db to confirm if it worked.
sumedh joined the channel
sampsyo has quit
sampsyo joined the channel
ruaok
Mooin!
_lucifer: i will check once I am in BCN again, this afternoon.
Do you have stuff to work on in the meantime?
_lucifer
great, thanks!
yes need to resolve the merge conflicts on the follow feature PR
ruaok
Ok
_lucifer
also, amending tests that are using hardcoded values so that we can restrict searching listens to the last 6 months and not go to the medivial times :p
yvanzo
good time of the day
CatQuest has quit
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
MajorLurker joined the channel
MajorLurker has quit
pristine___
ruaok: hey
_lucifer
Mr_Monkey: I have fixed the conflicts. The RecentListens.tsx file had a few conflicts. Can you please take a look at that file again?
Mr_Monkey
Hiya !
Yes, I was actually looking at 1296 as we speak, thanks for cleaning it up !
ruaok: alastairp: iliekcomputers: Mr_Monkey: how about doing a release today? we have a ws bugfix, ui improvements for timestamp and follow feature removal. plus i can test my changes in spotify reader ;).
Mr_Monkey
I'm all for it
iliekcomputers
sounds good to me
alastairp
nice, sure thing
_lucifer: depending on what your plans are, and what you've discussed with ruaok, you and I can have a bit of a chat about AB today too
ruaok
All good by me. If you want help doing that, I'll be fully online in 2-3 hours.
_lucifer
awesome, i'll get to it soon.
alastairp: we didn't discuss anythin in particular about AB. but I think the starting would to improve MeB admin interface?
ah, yeah. when we met in the office last Monday we talked about a lot of things, including the admin interface, and the plans for api keys and auth - that kind of merged into the oauth document that I started. later this afternoon we can straighten out all of the plans
ruaok: I think that prototyping the oauth could be a neat idea
ruaok
But easier to define things for meb could be tackled. E.g update node and python dependencies.
alastairp: I'm fine with that, but am trying to address your lament that AB gets little love.
Doing oauth is good for everyone, though.
alastairp
I'm planning on doing AB from next week anyway
ruaok
Ok, kewl.
alastairp
so I'm happy to get _lucifer working on it at a later stage
ruaok
_lucifer: you could work on the node upgrade when you have some spare time.
alastairp
for me, the oauth stuff is still full of a lot of unknowns, but I think having a prototype will help us work out what works and what needs to be revisited
ruaok
Ok, sounds like a rough plan for the week.
_lucifer
sure
alastairp
_lucifer: ever worked with oauth before? :)
ruaok
Agreed, on prototype.
_lucifer
not much, only what we have in the android app, alastairp
alastairp
feel free to add questions to that document. let's talk about it in ~2 hours
_lucifer: yes, right. as I said, I'll start looking at AB stuff next week too. There are 4-5 half-finished projects that I want to get released in the next 3 months
as you can see, there are lots of projects, lots of ideas, and not many programmers :) you're a great asset to help us get through these plans...
_lucifer
:-D
alastairp: regarding the release, should i tag before or after merging master into production or does it not matter?
alastairp
I've not really thought about that much before. theoretically it should be the same
(unless for some reason production has some other commits or weird commit order that master doesn't have)
this is for an earlier release. i can update it or open a new one
we updated dependencies so i think it makes sense to restart all services except cron. excluding spark reader as well because that is running a different branch currently.
alastairp
just approved 140, let's merge that and then do another one for this release
_lucifer
👍
alastairp
sounds fine to me to update all of those services. why do you not want to upgrade cron?
when do you think that we'll be able to merge the spark reader branch?
_lucifer
no changes to cron so i thought no need to update that
hopefully sometime later this week. ruaok can probably provide a better estimate on that
alastairp
ok, no problem. If this is going to be a common occurrence going forward maybe we need to think about splitting some things into separate images. Let's not worry about it for now