#musicbrainz-devel

hmm.

hmm?

I seem to recall there being a (java?) open source fingerprinting system

j<something>

jhears

that's it

Odd; getting 400 bad request whenever I try to open an edit form

hrm. test behaving differently from my dev machine.

heh

always fun

http://imgur.com/0eLOd.png woohoo

wow. :)

That is a very large image.

Nice work

now that release events are separate releases, looking up a disc id currently attached to a release with three release events will return three releases in ngs, right? or would it just return the track list and a list of releases the track list is used on?

nikki: disc ids are attached to mediums

and 3 release events creates 3 releases, but with shared mediums

oh wait... that's not right

mediums aren't shared, tracklists are

yea

A medium is just a release-tracklist relation with a couple bits of info, right?

I'm not sure how it works then i'm afraid, I'm guessing that the discid is attached to 3 mediums

Leftmost: yes

navap: nice work with the edit branch btw, I'm just merging it in now

sorry it took so long!

woohoo!

Alright, it's in - if there are any bugs it fixes, please close them :)

Did you merge it into core.git?

doing so now

Or push it up rather

Ah okay

ok, just merged and pushed to core.git

wow that's a lot of merging

haha

well, I did merge 70 odd branches

Can you also merge it/them into next?

on that too

then I gotta fix the commit emails for murdos, then it's gym time

when will we be able to see the converted edits?

nikki: still going to be a good 10 days for that I think

aww

but that's what I'll be working on now - I have to get the migration scripts running faster

Why are there so few files listed here? http://git.musicbrainz.org/gitweb/?p=musicbrain...

I see my commits and test looks like it should, but I edited quite a few more files than that.

I think that's just how the merge commit is displayed - you want to see the stat of your merge against a certain point in history

but you can't do that in gitweb

those are only the changes that happened during that merge)

So then what happens to all the other changes? Were they handled before that merge commit?

They were handled in your commits

in your branch

(if you follow one of the parent links, you'll see the history of your commits)

The thing with git is a merge isn't where the changes is happens, it just shows where 2 branches join together

Yeah I think I understand that bit, but what I don't understand is why only those six files are being shown in the merge commit.

I'd expect it to either be all the files, none of the files, or only files that required manually changing due to conflicts or something.

a merge commit would normally show no files at all, but in this case there are some changes in the merge commit from me fixing conflicts, and some changes that show up because I think they were changed in both branches (your branch, and the master branch)

(work/header.tt for example)

So then wouldn't it be a conflict..which would make it be listed above in the conlflicts section?

so work/header.tt was changed in your branch, and in master after you started work. So the changes have to be merged, but they didn't conflict (so git merged them automatically)

Oh.. that's kind of makes sense.

not necessarily, if they were changed in different places (which they were) that wouldn't create a conflict

Yeah

I just encountered an error loading search/edits:

Caught exception in MusicBrainz::Server::Controller::Edit->search "Couldn't load class (MusicBrainz::Server::Edit::Historic::AddRelease) because: Can't locate Devel/Dwarn.pm in @INC

I manually installed Devel::Dwarn and the problem seemes to have gone away. Should Devel::Dwarn be in the MakeFile?

nikki: ping

pong?

at the music festival I went to this weekend, there was a fellow who invented and played an earth harp.

pang

it was strung between a tiny stage and the main stage.

the earth makes up its body.

I was so amazed by this instrument that I want to get it into our instrument tree. :)

what is the policy on that these days?

normally it involves adding it to http://wiki.musicbrainz.org/Talk:Advanced_Instr... and finding five releases with it

ok, still the same then.

5 releases might be hard to find tho. :)

Leftmost: ping

aCiD2, pong

Hey, sorry I'm running a bit late - gym was busy

No worries.

So, where abouts are we?

You've got the server running right, but no coding yet?

Right, though I've dug through the code and know what files I need to modify and how for my next week's goals.

Ok - and what are those?

Well

in which order are you tackling them

Well, I think probably the first thing to do is make the changes I need to the schema, then create a simple page that gathers together an editor's collections, so I'll need a new controller class and data access module. (Something like /user/editor-collections/EDITOR_NAME.)

Then I can make the modifications to the collection page so that it works based on a collection ID.

Ok

So what we'll need here then is modifications to admin/sql/CreateTables.sql, but also a admin/sql/updates/collections-yyyy-mm-dd.sql script with ALTER statements in

Ahh, I was going to ask about that. I knew I'd have to mess with CreateTables, but I wasn't sure about how to alter existing structure.

Yea, we don't really have a system in structure for it

But the admin/sql/update scripts are the best way for now

One thing that I think will need some work is UIs. I think most of it will be pretty straightforward, but there are some specific things I'll probably want to get feedback from a few people on.

aCiD2: Does Devel::Dwarn needs to be added to MakeFile.PL?

No, it needs to be removed from the code

sorry about that

how come it keeps getting re-added?

because I use it for debugging

and sometimes I forget to remove it

tsk tsk :P

tsk tsk

exactly :P

How about

Caught exception in MusicBrainz::Server::Controller::Edit->search "Attribute (data) does not pass the type constraint because: Validation failed for 'MooseX::Types::Structured::Dict[types,MooseX::Types::Structured::Tuple[Str,Str],name,Str,link_phrase,Str,reverse_link_phrase,Str,description,Str,attributes,ArrayRef[MooseX::Types::Structured::Dict[name,Str,min,Int,max,Int]]]' failed with value { new_version: 40453, old

I think that was when I pressed the button to search for edits.

on what server?

you'll probably have to clear your edit table

Mine

aw

Okay

yea, some edits probably changed :(

Is there a set of test edits that can be easily loaded into the database?

It's a pain to keep making new ones.

Nope, but that sure would be ince