re: types of coverart, would it be prudent to make some simple images ilustrating wich part of the cd/vinyl etc each "type" is supposed to be? eg spine, [image of a jewelcase with cd goes here, but the part that is the inner is redoutline/solid some colour] ?
2011-11-01 30524, 2011
CatCat
erh spine/iner or iner/spine as apropriate
2011-11-01 30518, 2011
nikki
CatCat: once we've figured out what they actually mean :)
2011-11-01 30525, 2011
CatCat
cool
2011-11-01 30540, 2011
CatCat
natta
2011-11-01 30546, 2011
kepstin joined the channel
2011-11-01 30539, 2011
marvs_ joined the channel
2011-11-01 30529, 2011
davitf joined the channel
2011-11-01 30509, 2011
teuf joined the channel
2011-11-01 30557, 2011
bitmap impatiently wrote a patch for http://tickets.musicbrainz.org/browse/MBS-3708 despite not understanding perl and having no idea what he's doing :P http://pastebin.com/FPnZx50J
2011-11-01 30532, 2011
ruaok
that doesn't look like someone who doesn't know what he's doing.
nikki said "obscure interfaces are something people can at least learn to use, missing interfaces are unusable on account of them being missing :P" and I tend to agree
2011-11-01 30505, 2011
reosarevok goes try to convince the local uni to give me an erasmus for next year
2011-11-01 30508, 2011
reosarevok
Back later!
2011-11-01 30502, 2011
voiceinsideyou
reosarevok: I'm not really sure. I'd tend to agree with nikki; assuming it's obscure, rather than buggy - to put it bluntly :)
2011-11-01 30532, 2011
nikki
well right now people ask how to do it and we have to say you can't
2011-11-01 30537, 2011
reosarevok
Well, that depends on how it is implemented, the question is whether we want it to be like that
2011-11-01 30537, 2011
flamingspinach joined the channel
2011-11-01 30539, 2011
voiceinsideyou
Indeed.
2011-11-01 30553, 2011
reosarevok
Obviously whatever we do, we won't want it to be buggy
2011-11-01 30500, 2011
nikki
whereas if we have a way to do it that's not obvious, we can write an explanation and point people to it when they ask
Well the current situation is that the release editor is so ridden with bugs and 502s that I'm not personally willing to push for any features at all :)
2011-11-01 30516, 2011
nikki
well ollie would be doing the relationships stuff, kuno does the release editor
2011-11-01 30501, 2011
reosarevok
voiceinsideyou, this would be outside the RE as far as I understood
2011-11-01 30524, 2011
reosarevok
Oh, you mean because you want that to be fixed
2011-11-01 30530, 2011
reosarevok
Yeah, that's warp vs ocharles
2011-11-01 30514, 2011
reosarevok
TSK
2011-11-01 30516, 2011
reosarevok
More 502
2011-11-01 30519, 2011
nikki
yea
2011-11-01 30519, 2011
reosarevok
What is going on?
2011-11-01 30528, 2011
voiceinsideyou
Indeed. Who does what is of course a decision for the team; but I guess I personally see this specialization as a bit arbitrary (although obviously some people are better than others at JS) when we have this burning fire of an RE
2011-11-01 30538, 2011
nikki wonders if we get more 502s around 10 minutes past the hour, or if that's just her
2011-11-01 30549, 2011
reosarevok goes for real now
2011-11-01 30554, 2011
voiceinsideyou
:)
2011-11-01 30525, 2011
voiceinsideyou
i just got a 502 on reo's link too; it was a "quick 502" which IIRC ruaok indicated the other day was probably due to something wrong with nginx or that layer, rather than the server
2011-11-01 30506, 2011
voiceinsideyou
(as opposed to RE 502s, which are generally slow ones - server failed to respond quickly enough, etc)
nikki: looks like a session timeout of some description?
2011-11-01 30552, 2011
nikki
how nice of it
2011-11-01 30523, 2011
nikki
I got about 6 tracks in and decided to go to the next tab to stop it from timing out, only for it to crash on me and lose my stuff anyway
2011-11-01 30542, 2011
voiceinsideyou
however, given the frequency of timeouts (and people logging tickets recently), I have grown suspicious that there is something else going on
2011-11-01 30516, 2011
nikki
ocharles: btw you said last week that you would post on the style list about inheritance yesterday :P
2011-11-01 30514, 2011
Mineo joined the channel
2011-11-01 30526, 2011
ocharles
i said I'd do it on my monday? I thought I just said it was on my todo list :P
2011-11-01 30555, 2011
ocharles just got a 504 from jira
2011-11-01 30543, 2011
ocharles
still haven't got a 200, curse you blasted bug tracker!
2011-11-01 30529, 2011
warp
hello!
2011-11-01 30538, 2011
warp is late for work.
2011-11-01 30525, 2011
ocharles
g'morn
2011-11-01 30504, 2011
warp
ocharles: I'd like your opinion on HTTP status codes again.
2011-11-01 30520, 2011
ocharles
sure
2011-11-01 30553, 2011
warp
ocharles: "202 Accepted" seems a suitable response to a PUT request to change an entity
2011-11-01 30520, 2011
ocharles
And returning a pointer to the edit?
2011-11-01 30541, 2011
warp
(asynchronous processing, location is supposed to point something informational about the processing taking place)
2011-11-01 30545, 2011
warp
ocharles: yes.
2011-11-01 30546, 2011
ocharles nods
2011-11-01 30547, 2011
ocharles
sounds fine to me
2011-11-01 30501, 2011
warp
ocharles: but what should the status be if a NoChanges exception is thrown server side?
2011-11-01 30513, 2011
davitf joined the channel
2011-11-01 30514, 2011
warp
"304 Not Modified" seems to map well, but is only supposed to be used at the HTTP level, with "If-Modified-Since" headers and such.
2011-11-01 30510, 2011
jdlh joined the channel
2011-11-01 30500, 2011
warp
in a sense it is an error (4xx), because the edit wasn't created. but it's also success (2xx), because the entity has already been changed in the way the PUT was trying to change it.
2011-11-01 30502, 2011
ocharles
hrm
2011-11-01 30510, 2011
ocharles
I don't think it's right to use 304
2011-11-01 30515, 2011
ocharles
so that only seems to leave 409?
2011-11-01 30538, 2011
warp
I was leaning towards 409 for error yes.
2011-11-01 30503, 2011
warp
but I was also thinking of 204 or 205 to indicate, look dude, it's already like this, success!
2011-11-01 30548, 2011
ocharles
Well, currently in the form when you try and submit with no changes, you don't leave the page
2011-11-01 30507, 2011
warp
ok, 409 is closer to that.
2011-11-01 30507, 2011
ocharles
But where are you going to display a message saying it hasn't changed?
2011-11-01 30549, 2011
warp
yes, a 409 response probably can have a body.
2011-11-01 30519, 2011
warp
so $serializer->output_error ("bla bla no changes blah")
2011-11-01 30531, 2011
ocharles
sure, but we said it should have the body you gave the request with information on each attribute with information on what's wrong
2011-11-01 30552, 2011
warp
oh, right, I haven't done that at all yet.
2011-11-01 30542, 2011
ocharles
In TreeValidator, cross-validation errors are put at the deepest node that contains all nodes that failed cross-validation
2011-11-01 30556, 2011
ocharles
which in this case would mean an "errors" node under the root node (<label>)
2011-11-01 30559, 2011
ocharles
I'd be ok with that
2011-11-01 30534, 2011
warp
ok
2011-11-01 30558, 2011
warp
and any kind of error (including nochanges) should be a 409?
2011-11-01 30558, 2011
ocharles
well, we couldn't find any other appropriate codes last time we discussed this, iirc :)
2011-11-01 30500, 2011
warp
er, any kind of validation error I mean. a parse error still is just a 400 or something.
2011-11-01 30518, 2011
warp
yes, ok.
2011-11-01 30525, 2011
ocharles
right
2011-11-01 30532, 2011
warp
ocharles: where should validation go in our architecture?. it's obviously not going to be in the MusicBrainz::Server::Form::* anymore.
2011-11-01 30557, 2011
warp
should that be part of the models, the entities, or have a seperate set of validator objects?
2011-11-01 30509, 2011
ocharles
I'd prefer a separate set of objcets
2011-11-01 30545, 2011
warp
ok
2011-11-01 30550, 2011
ocharles
Effectively moving towards a factory pattern
2011-11-01 30522, 2011
ocharles
"LabelFactory->create_label( %label_info_here)" yielding either a Label object, with certain attributes transformed (trim, whatever), or a set of errors
2011-11-01 30534, 2011
ocharles
then you can create edits from that Label object
2011-11-01 30511, 2011
warp
right, so the edits would also change (eventually) to just take old and new objects.
