#musicbrainz-devel

)

Typing thoughts out sucks.

A bit, yeah...

But I guess we have to do with what we have

If we modify links and make them external wiki links, do you think that would be odd when a user's browsing /doc and then all of a sudden ends up browsing on our wiki?

but typing something and having 36 people hear it is quite useful

navap, maybe

But it can be documented as the way doc works :p

I don't think it is ideal

But it is better than displaying all the userspace

which kinda makes it feel as if we were endorsing its contents

One thought I had was to create (yet another) namespace for just content that is available on /doc. If a page isn't in that namespace it won't load and any links to non-doc namespace articles are automatically removed (like we remove broken links)

warp: want me to just discard that review given that the code will be changed a lot, and the diff there is obsolete?

Hmm

I could see that working in an ideal wiki but ours is far from that

I mean, it involves reviewing every page and deeming it doc-(un)worthy

warp: referring to http://codereview.musicbrainz.org/r/1391/ I mean

Which is really not that hard. We'd start with everything in the wikidoc table and then add other pages only when necessary.

So you'd keep the /doc part only for actual documentation?

(and a few other things)

That would definitely make sense to me

Yes. Like you said, only for things we actually endorse

It might even make me start seeing the point of the whole /doc thingy

:p

Yeah

Yes

You could add a ticket for it :)

It would be very similar to how we'd put the metabrainz pages into the wiki.

Would a namespace be the right way though?

Can't it be done with that?

It could, but I think it's much clearer if it's done either via a separate namespace or by nesting everything under one page.

That way the url itself is different and it's more obvious.

Hmm

I'd be against the nesting method though.

But it would mean we'd have

"Whatever:Style/Titles/Whatever2"?

Or are you proposing "Style:Titles/Whatever2"?

(and "Documentation:Whatever"?

)

The problem with that way would be the difficulty of finding the right "box" to put some pages

I don't think we need to separate style pages from other pages available on /doc.

Sure

But the style pages have crazy names already

Without them having *also* a namespace...

I'd use Doc as the namespace. (WikiDoc would be annoying to type out all the time)

bitmap: if the diff is obsolete, yes, discard the review.

bitmap: just submit a new one later.

warp: okay. provided review board works with Picard still :P

not that it did to begin with, but I’d think it should be easier to fix now that it's on git

(not that I am a songwriter anyway, but I'm curious)

warp: status on http://codereview.musicbrainz.org/r/1570/ ?

ocharles: one issue mentioned in a post on mb-users I need to double check.

ocharles: I'll put that on my TODO for tomorrow.

ocharles, did you sort the database on test ?

ijabz_: still going

ijabz_: on 3rd attempt :(

first failed because the server was running/cron jobs were on. then it failed because I imported on next instead of master

this one should get it

its the seemingly straight forward things that get you

ocharles, did you merge the two codereviews I asked for in the end?

ijabz_: :)

(they both need the new database anyway, just asking)

reosarevok: no, I haven't done that, but I am working on reviews today. I'm on lukas' atm, when I get to yours I will merge them

I will be clearing next as well, and setting that back up

hm, does anybody know which base directory I'm supposed to use on codereview.mb.org for python-musicbrainz2?

which repository?

(if that's the one for python-musicbrainz2)

yeah, I would think so.

if its not, it will barf, so no reason not to try it

it's already barfing, that's why I'm askin :)

Mineo: if you cannot get code review to not barf, just link to a changeset (e.g. on github) in the review itself.

I can't create a review at all

ah

Mineo: might be easier to just use mb-devel if you're having troubles

python-musicbrainz2 is for http://svn.musicbrainz.org/python-musicbrainz2/ fwiw

that's what I was going to do if asking here didn't bring up any results

Mineo: what path are you using?

(base directory)

I tried that svn url, ., /

try /trunk

or 'trunk'

I have a hard time getting svn patches up against the xml schema

both trunk and /trunk didn't work either

** I have just reset the next branch **

a quick fyi if anyone was going to work with that at all

hobbes is indexing the new data atm

:)

ijabz_: ping

test.musicbrainz.org is back up with fresh data, and a reset `next`

i lie, it's not starting up

all done

finally

:)

reosarevok has broken the artist index page though

yay

and its snappy. :)

ijabz_: ping ding ding!

And what should I do if my merge conflict was handled incorrectly?

ruaok: pong dong dong

lol

what was the reload url again?

been out trying to burn off some calories

if that the right port

navap: bug the person who cocked the merge up :)

ijabz_: do I need to re-do the mmap call if I do a reload?

no

ok.

can you do me a favor and make mmap the default on the branch you made?

reload just updates modified parts of the existing index

ok

thx

I tried one reload and that slightly increased the load.

I'm watching it now.

ruaok: checked in the mmap as default

navap: oh, right, what did I get wrong?

https://github.com/navap/musicbrainz-server/com... vs https://github.com/metabrainz/musicbrainz-serve...

I was adding the IF statemnt, not taking it out.

navap: ah

that first link is empty for me.

"master is up to date with all commits from nitpick-2011-10. Try switching the base for your comparison. "

navap: so I just need to put the if statement back in, that's everything?

Yeah

Here https://github.com/navap/musicbrainz-server/com...

Thanks!

navap: ok, pushed. (commit 87cdee195b7bac547345e7dba5c03f976917d2d5).

navap: thanks for noticing :)

ijabz_: r13318 ?

yes