german also has cases, but the system's a lot less complicated than estonian's
2012-10-01 27522, 2012
warp
ah, then a german example would probably help me understand it better.
2012-10-01 27529, 2012
ianmcorvidae
but for example "{age} ago" doesn't work in german because the preposition you have to use to translate 'ago' changes the thing into a different case than what you'd use for an age alone
2012-10-01 27542, 2012
ianmcorvidae
i.e. 'am 7 Jahren' rather than '7 Jahre'
2012-10-01 27559, 2012
ianmcorvidae
er, not am, vor
2012-10-01 27539, 2012
ianmcorvidae
and the case ending isn't always just 'add n', so you can't just make it 'vor {age}n', which would of course be a gross hack anyway :P
2012-10-01 27552, 2012
ianmcorvidae
I could easily see estonian translating "Artist" and "Artist:" differently, because the context provided by the ':' might change the case
Previously if you talked in an edit you would receive notifications…
2012-10-01 27535, 2012
ijabz joined the channel
2012-10-01 27501, 2012
ijabz_ joined the channel
2012-10-01 27532, 2012
ijabz
warp, ping
2012-10-01 27533, 2012
stefans joined the channel
2012-10-01 27555, 2012
warp
ijabz: ack
2012-10-01 27516, 2012
reosarevok joined the channel
2012-10-01 27533, 2012
ocharles
good morning
2012-10-01 27536, 2012
ocharles
warp: no standard way
2012-10-01 27541, 2012
ocharles
and yes, you've asked before :)
2012-10-01 27510, 2012
warp
ocharles: ok
2012-10-01 27525, 2012
ocharles
warp: the 'standard' postgres way is to update, check the row count returned, insert if it's not what you expected, and do all this in a loop; you break if the insert completed without exceptions, and you loop if there was a primary key violation
2012-10-01 27515, 2012
warp
what I have now is:
2012-10-01 27556, 2012
warp
INSERT INTO cover_art_archive.release_group_cover_art (release_group, release)
2012-10-01 27559, 2012
warp
(SELECT ? AS release_group, ? AS release WHERE NOT EXISTS
2012-10-01 27502, 2012
warp
(SELECT 1 FROM cover_art_archive.release_group_cover_art
2012-10-01 27504, 2012
warp
WHERE release_group = ?));",
2012-10-01 27547, 2012
ocharles
that's what an approach
2012-10-01 27548, 2012
warp
(which I haven't tested yet)
2012-10-01 27557, 2012
ocharles
you can simplify it with a function in postgresql and use try/catch
2012-10-01 27510, 2012
ocharles
but you can't do that outside a postgresql function without causing the exception to be logged, which i would like to avoid :)
2012-10-01 27531, 2012
warp
ah
2012-10-01 27515, 2012
warp
I'll stick to this, assuming it works. you can offer alternatives on the code review if you come up with something better :)
2012-10-01 27532, 2012
ocharles
ocharles has changed the topic to: Arctic week! | http://musicbrainz.org/#devel | Agenda: replication packets (ocharles), schema change progress, nes3 (ocharles), github (ocharles), translations (ian), MBS-2377 DR (ocharles), MBS-3059 DR (ocharles), echoprint "partnership" (reotab)
2012-10-01 27539, 2012
ianmcorvidae
ianmcorvidae has changed the topic to: Arctic week! | http://musicbrainz.org/#devel | Agenda: replication packets (ocharles), schema change progress, nes3 (ocharles), github (ocharles), MBS-2377 DR (ocharles), MBS-3059 DR (ocharles), echoprint "partnership" (reotab), translations (ian)
2012-10-01 27555, 2012
ianmcorvidae puts myself at the end of the line, everything else seems more important
2012-10-01 27536, 2012
reosarevok
Not mine :p
2012-10-01 27512, 2012
reosarevok
(and heh, sounds like another looong meeting)
2012-10-01 27509, 2012
warp
ocharles: I guess we should release today.
2012-10-01 27531, 2012
reosarevok
Remember to revert the relationship editor first, if it's not done yet
2012-10-01 27549, 2012
ocharles
i know
2012-10-01 27551, 2012
ocharles
i'm doing it now
2012-10-01 27513, 2012
warp
ok :)
2012-10-01 27524, 2012
ocharles
well that was to reosarevok, but I guess it applies to your comment too :)
2012-10-01 27533, 2012
warp
haha
2012-10-01 27536, 2012
warp
>_<
2012-10-01 27554, 2012
ianmcorvidae hopes jenkins for master is fixed?
2012-10-01 27526, 2012
ocharles ponders how to revert the relationship editor
2012-10-01 27508, 2012
ocharles
ianmcorvidae: not that i know
2012-10-01 27516, 2012
nikki
is that why beta is so slow then?
2012-10-01 27523, 2012
DremoraLV joined the channel
2012-10-01 27527, 2012
ocharles
possibly
2012-10-01 27537, 2012
ocharles
but i don't think so right now, cause jenkins isn't doing anything
2012-10-01 27506, 2012
ocharles questions how well this revert is going to work
2012-10-01 27512, 2012
ocharles
doing it on the day of the release is fun
2012-10-01 27516, 2012
warp
:)
2012-10-01 27543, 2012
ocharles
All tests successful.
2012-10-01 27549, 2012
ocharles
ok, the site will be perfect. yay
2012-10-01 27503, 2012
ocharles
ianmcorvidae: what exactly am I testing on the edit search?
2012-10-01 27523, 2012
ianmcorvidae
ocharles: do a search, get results, then try to add a new property and hit search again
2012-10-01 27539, 2012
ocharles
ok
2012-10-01 27547, 2012
ianmcorvidae
before my fix that wouldn't work, but it had to do with the new jquery version, so I want to make sure my fix doesn't need reverting too.
