#musicbrainz-devel

warp: it would be good if you could review https://bitbucket.org/metabrainz/musicbrainz-se..., and warp/ocharles, it'd be good to get that into the release

Where "good" means "fucking necessary"

If I might be blunt :p

may? whatever

warp, ocharles: likewise https://bitbucket.org/metabrainz/musicbrainz-se...

of course I have that in local changes on astro, but

recordings RFC out on style

warp: I'm guessing your track mbids stuff will affect the set track lengths edit type, so http://tickets.musicbrainz.org/browse/MBS-6113 might be of interest to you

warp, ocharles, ianmcorvidae, 500s and 502s abound.

yep, pingu is fukkered again.

bah

I'm rebooting it.

and it looks like pingu is not coming back.

power cycle later and pingu is back

hi guys

hi

quick question: is there a way to load replication changes for a specific artist?

no

:(

too bad

how about for only part of the database?

you could write the code to do those things

but it does not exist at present

Hello

* Ian McEwen: MBS-5964: clear the cache for artist credits after artists would be deleted from the cache

* bitbucket: fix syntax error in sql update 20130125

* Oliver Charles: MBS-6019: Extend FreeDB parser to support multiple occurances of the same field

* Ian McEwen: MBS-5694: use any rather than IN, for working properly on the empty list

* bitbucket: use dedicated html5.validator.nu

* Ian McEwen: MBS-6038: don't use the terrible-for-i18n string 'See all {num} {entity}', instead having a string per entity. Also, really use ln for languages without Germanic pluralization rules

* Ian McEwen: MBS-6042: add ReleaseCountry predicate in the (remaining) place it is missing

* Ian McEwen: MBS-5980: on release cover art page, wrap comment text to the image width

* Ian McEwen: MBS-5524: in edit relationship type/attribute edits, always show name and description; in type edits, show entity0 and entity1 types as well

splendid

warp: shall we release?

Project full-import build #4: STILL FAILING in 1 min 24 sec: http://ci.musicbrainz.org/job/full-import/4/

Project full-import build #5: STILL FAILING in 1 min 7 sec: http://ci.musicbrainz.org/job/full-import/5/

Project full-import build #6: ABORTED in 13 min: http://ci.musicbrainz.org/job/full-import/6/

hmmm, what does "bunzip2: Broken pipe" mean :|

an incomplete bzip stream, I think? unsure

oh, splendid

it's because scooby is eons out of date

is at least my guess

scooby?

why are we running things on scooby?

oh wait, it's not on scooby

it's on rocko

hr.m

md5sum -c works right before it, so the file is fine

check locally that the file wasn't just plain output wrong?

i'll leave it and see if the import ends up working

it should, -cdstubs isn't required

but it may be indicative of a problem anyway

all of them do it, not just cdstubs

oh, hm, the one I'd looked at it was only cdstubs

anyway

(or I thought it was, I mean)

ianmcorvidae: I'm going to release MBS-6091 into master

ocharles: cool, good

Project musicbrainz-server_master build #389: SUCCESS in 27 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

Ian McEwen: Lucene 4.0 added a / operator that was making webservice search queries fail dramatically, this escapes it

Ouch, that USB drive on rocko aint much fun

50 minutes to load the `edit` table

ocharles has changed the topic to: vanilla-ices | http://musicbrainz.org/#devel | Agenda: reviews, timeouts/MBH-309 (ian), emailing password resets (ocharles)

* reosarevok: Modifying to take comments into account

* Ian McEwen: Exports are broken because of a missing comma.

* Oliver Charles: Add the 'prepare_release' Fabric step

ocharles: goodmorning!

ocharles: https://bitbucket.org/metabrainz/musicbrainz-se... is fixed now (dunno if it mails you or not)

hi warp

hello

luks, ping

ocharles: yes!

warp: woohoo! i'm all ready

ocharles: ok, I will log into the load balancers

ready

ocharles: asterix is out

(sidenote, internet and electricity here is less reliable than in .nl, so if I stop responding, things have broken)

warp: ok, working on asterix now

got distracted by the whole Thatcher-death thing

many ppl seem to have not like the woman (/ her opinions)

(when they all default to mb anyway)

+d

warp: they are quite justified in those feelings

those who think she is a good woman have political views that don't quite agree with mine, lets put it that way :)

reosarevok: pong?

hi!

So, about https://bitbucket.org/metabrainz/musicbrainz-se...

Meh mb

cl

I agree with that... partially

I probably wasn't following politics much when she was active, so I wouldn't know.

warp: asterix done

I see absolutely no reason non-logged-in users shouldn't be able to see results for elections

ocharles: asterix back, pingu out.

reosarevok: then change it in the function

So I was thinking it should rather be "[% IF (c.user_exists && election.can_see_vote_count(c.user) == "yes") || election.close_time %]"?

but that's a separate issue, because they can't see it on the election page either

Well, yeah, I was thinking about doing the same for the election page

I think those two pages should be consistent

so if you want not-logged users to see the counts, it should be changed in the can_see_vote_count function

e.g. to allow undefined $user

then the check will be election.can_see_vote_count(c.user) == "yes"

Meh, why do we always like to do things in the complicated way :p

or remove the function completely

and use only the close_time

but I think it should be done the same way on both pagesa

No, some people *should* still be able to see it

(while it's open)

warp: pingu done

It's just that everyone should be able once it's closed

ocharles: pingu back, astro out.

reosarevok: well, I think it's better to just use the function for now

Ok

I think I can add a second ticket to "fix" the function

if you want not-logged-in users to see the vote counts, that can be changed later for both pages