Gentlecat: On the release group page, I'm displaying average rating if a user is not logged in, and a User's rating otherwise.
2015-06-01 15216, 2015
dufferzafar
no issues, right?
2015-06-01 15253, 2015
Gentlecat
that's fine, I guess
2015-06-01 15212, 2015
dufferzafar
I still need to work on rating a release group without actually writing a review.
2015-06-01 15224, 2015
dufferzafar
Apart from that, what do you think still needs to be done?
2015-06-01 15229, 2015
Gentlecat
I still don't understand how you cherry pick commits btw
2015-06-01 15210, 2015
dufferzafar
I just pick them, but don't actually commit!
2015-06-01 15219, 2015
Gentlecat
solving issues with sync, if you still want to keep ratings locally in cb
2015-06-01 15250, 2015
Gentlecat
we make way too many requests to MB even without that
2015-06-01 15252, 2015
dufferzafar
that is one of the reasons, i don't think it makes sense to keep them in cb too
2015-06-01 15217, 2015
dufferzafar
what happens if a user updates their rating of a release group from mb?
2015-06-01 15221, 2015
Gentlecat
then you need to fetch them every time for each review
2015-06-01 15240, 2015
Gentlecat
I don't know solution, that's why it's unfinished
2015-06-01 15252, 2015
dufferzafar
i was thinking of NOT showing the rating with a review
2015-06-01 15200, 2015
dufferzafar
just showing it with a release group
2015-06-01 15216, 2015
ianmcorvidae joined the channel
2015-06-01 15257, 2015
Gentlecat
what if people want to associate a rating with their review?
2015-06-01 15247, 2015
dufferzafar
they're writing a review, but the rating is still associated with the release right?
2015-06-01 15250, 2015
Gentlecat
it should be associated with entity that review is being written for (currently it's release group)
2015-06-01 15251, 2015
dufferzafar
what if we don't sync the changes? so a review's 'rating' will be updated only when the user updates the review
2015-06-01 15245, 2015
Gentlecat
1:33:06 AM <dufferzafar> what happens if a user updates their rating of a release group from mb?
2015-06-01 15257, 2015
Gentlecat
it will be outdated
2015-06-01 15232, 2015
Gentlecat
maybe we need to decide if it should be separate
2015-06-01 15232, 2015
dufferzafar
i'm getting a feeling that the pull i created will have the same fate as the old one...
2015-06-01 15227, 2015
dufferzafar
it's the same thing, with just a different ratings plugin!
2015-06-01 15215, 2015
Gentlecat
I told you it's not as simple as it looks
2015-06-01 15249, 2015
Gentlecat
try asking for more feedback, maybe someone else has a better idea
2015-06-01 15212, 2015
Gentlecat
work on something else in the meantime
2015-06-01 15224, 2015
dufferzafar
okay, I'll write a mail to the devel list explaining the problem
2015-06-01 15225, 2015
Gentlecat
you can also extract a few improvements into separate pull requests
2015-06-01 15256, 2015
dufferzafar
yeah, i need to look into the other pulls too
2015-06-01 15216, 2015
dufferzafar
btw, we're still supposed to reply to the "Dev Chat Reminder" posts; explaining what we did in the week, like the last time, right?
2015-06-01 15228, 2015
bitmap
no, we switched to doing reviews in the meetings
2015-06-01 15244, 2015
bitmap
but you can still reply to the email if you want, especially if you can't make the meetings
2015-06-01 15242, 2015
dufferzafar
i'll reply to the mail, as i need to go somewhere early morning tomorrow.
2015-06-01 15202, 2015
diana_olhovik_ joined the channel
2015-06-01 15231, 2015
weeksio joined the channel
2015-06-01 15211, 2015
kepstin-laptop joined the channel
2015-06-01 15219, 2015
nikki joined the channel
2015-06-01 15234, 2015
bitmap
meeting time!
2015-06-01 15250, 2015
bitmap
and ruaok put me in charge for some reason
2015-06-01 15229, 2015
ianmcorvidae
heh
2015-06-01 15232, 2015
ianmcorvidae
moin everyone
2015-06-01 15233, 2015
Gentlecat
yay! meetings
2015-06-01 15243, 2015
bitmap
I'll start with his update since it's already written
2015-06-01 15259, 2015
bitmap
<ruaok>
2015-06-01 15203, 2015
bitmap
My week consisted of:
2015-06-01 15211, 2015
bitmap
- Chasing people to give us money: BMAT, Wolfram Alpha, Songkick
2015-06-01 15218, 2015
bitmap
- Keep up with requests from the new MetaBrainz site.
2015-06-01 15227, 2015
bitmap
- Running around london meeting up with people: BBC, Byta, 2Pears
2015-06-01 15235, 2015
bitmap
- Attending and espousing about MB at the Web We Want conference
2015-06-01 15243, 2015
bitmap
Back to mainly sysadmin work this week once I get home.
2015-06-01 15246, 2015
bitmap
</ruaok>
2015-06-01 15255, 2015
ohrstrom joined the channel
2015-06-01 15244, 2015
bitmap
anyone else want to go next, or should I?
2015-06-01 15251, 2015
ianmcorvidae
I can go whenever
2015-06-01 15218, 2015
bitmap
ok, go ahead
2015-06-01 15223, 2015
ianmcorvidae
right
2015-06-01 15249, 2015
ianmcorvidae
so most of my week was working on reviewing stuff, and working on finishing up the collections stuff
2015-06-01 15219, 2015
ianmcorvidae
the work collections bits and bitmap's work on the credits UI should go into the release I'll do after this meeting plus lunch, accordingly
2015-06-01 15243, 2015
MBJenkins
* Ian McEwen: Clear memcached at the end of SetLanguageFrequencies, as mentioned in TODO
2015-06-01 15244, 2015
MBJenkins
* Michael Wiencek: Merge relationship credits
2015-06-01 15245, 2015
ianmcorvidae
I also did some work on hopefully getting us to the bottom of the pgbouncer process consumption problems we've been having that have been resulting in the 502s
2015-06-01 15245, 2015
MBJenkins
* Michael Wiencek: Add UI to change all relationship credits on the page
2015-06-01 15246, 2015
MBJenkins
* Michael Wiencek: Fix WS::js::Release test
2015-06-01 15247, 2015
MBJenkins
* Michael Wiencek: Remove unused FormRenderer methods
2015-06-01 15248, 2015
MBJenkins
* Ian McEwen: Normalize URLs provided to the 'resource' parameter of /ws/2/url, as normalized upon insertion, before looking them up.
2015-06-01 15249, 2015
MBJenkins
* Ulrich Klauer: INSTALL.md: Correct extension for signature files
2015-06-01 15250, 2015
MBJenkins
* Ulrich Klauer: INSTALL.md: Move JSON::XS to the database section
2015-06-01 15251, 2015
MBJenkins
* Ian McEwen: Also produce a SHA256SUMS file for data dumps, for a more cryptographically secure hashsum.
2015-06-01 15201, 2015
ianmcorvidae
quiet, bot
2015-06-01 15202, 2015
ianmcorvidae
anyway
2015-06-01 15207, 2015
bitmap
heh
2015-06-01 15223, 2015
ianmcorvidae
where was I
2015-06-01 15239, 2015
bitmap
that was the per-pid log stuff I guess
2015-06-01 15242, 2015
ianmcorvidae
right, I have a PR up, though not ready to merge, about logging which requests each individual worker PID makes to log files
2015-06-01 15245, 2015
ianmcorvidae
yeah
2015-06-01 15254, 2015
bitmap
cool
2015-06-01 15213, 2015
ianmcorvidae
the goal there being, we have stuck processes that seem to be what are holding those processes, so hopefully with a record of what their last request was we can figure it out
2015-06-01 15219, 2015
ianmcorvidae
or at least figure out if that'll help us figure it out :P
2015-06-01 15254, 2015
ianmcorvidae
thursday through sunday I was up in phoenix for phoenix comicon and didn't get much done, anyway, so fin
2015-06-01 15203, 2015
bitmap
ok
2015-06-01 15229, 2015
bitmap
my review is short since I pretty much worked on the tags voting UI the entire week
2015-06-01 15216, 2015
bitmap
there's a pull request up now with lots of good comments about how to make the UI better, but hopefully it'll make next release
