#musicbrainz-devel

bitmap: is elasticsearch installed on rika? We don't seem to have a locally installed version under /home/bookbrainz

LordSputnik: we have 1.4.5 on rika, it wasn't running but I started it now

Does that require sudo?

yeah

Ah OK

Project critiquebrainz build #126: SUCCESS in 2 min 25 sec: http://ci.musicbrainz.org/job/critiquebrainz/126/

* dufferzafar0: Admins can now delete a report

* dufferzafar0: Admins can now delete a user account

* dufferzafar0: Schema Update: Added user status enum

* dufferzafar0: Replace delete user view with block user

* dufferzafar0: Blocked users are not allowed to create or vote on reviews

* dufferzafar0: Allow admins to block/unblock a user from the user's page

* dufferzafar0: Add name in TODO comment

* dufferzafar0: Change delete report view to archive instead

* dufferzafar0: Don't list archived spam reports

* dufferzafar0: Use admin log list method rather than queries

* dufferzafar0: Display moderation log page title and a link in footer

* dufferzafar0: Rename status_types to user_status_types in the SQL schema

* dufferzafar0: Add a review property to moderation log

* dufferzafar0: Add a template to take reason from admins

* dufferzafar0: Display a notice and redirect if the review is already archived

* dufferzafar0: Generate new log entry when a user is blocked

* dufferzafar0: Rename Review is_archive to is_archived

* dufferzafar0: Convert user_status (enum) attribute to is_blocked (boolean)

dufferzafar: that's a lot of work, nice :D

Project critiquebrainz build #127: SUCCESS in 2 min 26 sec: http://ci.musicbrainz.org/job/critiquebrainz/127/

roman: Updated strings.

deployed

ruaok: we now have moderation stuff on CB

awesome. I can ignore the CB warnings then?

warnings?

sentry notitifications

oh, I didn't realize you were subscribed to them

yeah, most of these problems were caused by the way I updated CB

we also need to add some moderators

people who can hide reviews and ban users

I could do that, if it just involves getting report mails and banning spam

Let me know if needed

there's no mails

just a page with a list of spam reports

Huh. Ok. What does the Report link do then?

Oh, I see

give me a sec

any suggestions/bug reports are welcome

dufferzafar: I'll create a couple of tickets too

Gentlecat: I think we should add a link to 'Reports' in the footer that's only visible to moderators?

Er. Any reason it is in Italian? I'm a bit confused. I mean, I can change it, but pretty sure my browser has English before Italian...

Apart from that, this looks fine I guess :)

dufferzafar: yeah, I was about to suggest that actually

should we also make the central review column a link?

reosarevok: probably switched to italian before or detection is not working properly

the read button feels *small*

I'd be surprised if I had switched to Italian of all languages :) But dunno

I would kinda expect the title of the album to be a link to the review

(took me a bit to notice the Read thing)

But it's not a big issue anyway, this is not intended for public use I guess so

no, it isn't, only moderators can access this page

dufferzafar: yeah, it probably should be a link to review

funny we're feeling this now that the code has actually been deplyed

well, I actually suggested you that before https://bitbucket.org/metabrainz/critiquebrainz...

not sure if we should include hidden reviews into public data dumps

if we're hiding them on the site, i think we should not include them in dumps either

another thing to be fixed then

ruaok: our ppa has everything packaged for trusty now (currently running tests but I haven't seen any issues yet)

Gentlecat: this is how the reviews get dumped right?

I think hidden reviews will not be listed, because: https://bitbucket.org/dufferzafar/critiquebrain...

bitmap: very cool!

where is this PPA? is it documented in syswiki?

dufferzafar: what about "regular" dumps? we COPY rows directly from the database there

ruaok: https://launchpad.net/~metabrainz/+archive/ubun...

oh, the full_db function?

it's mentioned in PackagingPerlForDebian.md

dufferzafar: yes

ok, cool. that is all I need to try again with the VM.

wait, not

it's what our chef cookbooks currently use for production servers

not this one

full_db is for creating our internal backups

public()

bitmap: ah, ok. the VM code still pulls from ocharles__'s PPA. I'll update that after dinner.

cya

btw, I packaged the postgres extensions too so you don't need to compile them manually anymore

ohh, even better. thanks!

dufferzafar: I created a separate version in JIRA for tickets that you work on during this GSoC http://tickets.musicbrainz.org/browse/CB/fixfor...

feel free to add anything I missed

I only used tickets assigned to you

okay, I'll add stuff that I'll be working on

dufferzafar: CB-158 is done, right?

I don't think so

can you add some more info about what's missing?

let me just check

I remember you added some tests that actually involve logged in users

yeah, i found the code, so 158 is done!

nice

ok, I created a couple more tickets with suggestions for moderation interface

dufferzafar: how is new entity support coming along?

I *think* I'll have event reviews working by tomorrow

I have some notes here: https://gist.github.com/dufferzafar/76423f5f6b4...

dufferzafar: you can use trello for planning btw

I think bitmap uses it for MB too

as of last week, yes :)

I have a board for CB there from last year

can add you there if you want

we can make it public too

I've used trello in the past, but i think i just need something simple that doesn't make me leave sublime

ok, fair enough

I wish there were something like Emacs org mode for sublime (something that's not half-assed anyway)

well, you could just use emacs :-)

I will *someday*

Gentlecat: I'll sign up as a CB moderator too. What paperwork do I need to fill out?

I need to add you to config file :)

dufferzafar: would be useful to have a UI for that

(Should that be part of my job description?)

if that's something you'll have time for

Freso: done