#musicbrainz-devel

/

      • ianmcorvidae
        yeah
      • I decided I'm ignoring the line-length part of PEP8, because it just results in a bunch of gross hacks to make it actually fit
      • some of that is because my code probably could be better, but not much
      • ... heh, oops, it's pep8 checking the *dependencies*, that's clearly wrong
      • MBJenkins
        Project geordi build #9: STILL FAILING in 5 min 20 sec: http://ci.musicbrainz.org/job/geordi/9/
      • * Ian McEwen: PEP8: views.py, except E501
      • * Ian McEwen: PEP8: search.py, except E501
      • * Ian McEwen: PEP8: __init__.py, except E501
      • * Ian McEwen: PEP8: mappings subdir, except E501
      • * Ian McEwen: PEP8: ignore E501, as it results in nasty hacks
      • Leftmost
        Huh. last.fm doesn't associate a release MBID with tracks. Is that because they're using pre-NGS structure?
      • MBJenkins
        Project geordi build #10: STILL FAILING in 2.8 sec: http://ci.musicbrainz.org/job/geordi/10/
      • Ian McEwen: Don't test dependencies in virtualenv for pep8-conformity
      • Project geordi build #11: FIXED in 3.1 sec: http://ci.musicbrainz.org/job/geordi/11/
      • Ian McEwen: fix my idiotic exclusion of the actual *code* in the if block
      • ianmcorvidae
        apparently the pep8 test runs a lot faster when it confurms
      • conforms*
      • ocharles
        the line length thing is really good because it forces you to introduce both small functions and meaningful variables
      • rather than cramming an insane amount onto one line
      • MBJenkins
        * nikki: Add files for converting Discogs data dumps
      • * Ian McEwen: PEP8 fixups for discogs scripts.
      • nikki
        heh
      • ianmcorvidae
        hey, there's even three or four lines that *didn't* touch :P
      • nikki
        the empty ones? :D
      • ianmcorvidae
        nah, also those that aren't indented :P
      • nikki
        it's no secret that I'm a tab lover.
      • ianmcorvidae
        you also had some spaces after [ and before ], and some extra spaces after operators :P
      • nikki
        hm. would be nice if github would show me the differences without the indentation
      • Leftmost
        ianmcorvidae, still can't log in to geordi.
      • ianmcorvidae
      • VxJasonxV just told me about that earlier today :)
      • nikki
        Leftmost: add beta. to the url it takes you to
      • ianmcorvidae
        Leftmost: will fix *that* bit now :)
      • Leftmost
        Thanks.
      • nikki
        hm, but that's all the whitespace changes gone :/ I knew about the tabs vs spaces thing, but not the others
      • MBJenkins
        Ian McEwen: Use beta.mb as the base for oauth, until it ships to production.
      • ianmcorvidae
        Leftmost: should be fixed
      • nikki: oh, hm
      • Leftmost
        Out of curiosity, what exactly does matched by index mean?
      • ianmcorvidae
        nikki: https://github.com/metabrainz/geordi/commit/e05..., and 83 and 92 (two spaces after +), and 116/118 for the spaces inside the []
      • Leftmost: it means that the data as we got it already had an MBID in it, since the provider of the data did their own matching
      • nikki
        ah, thanks
      • Leftmost
        Ahh.
      • nikki
        the first was just a typo, I wouldn't do that intentionally
      • ianmcorvidae
        and the has_key() -> in changes you saw on the whitespace one
      • nikki
        yeah
      • ianmcorvidae
        Leftmost: the wcd index matching was acoustid-based
      • as in, they took the files (which they, of course, actually have) and acoustid'd them, and depending on some criteria that aren't exactly clear (but which seem to be "everything in the release has an acoustid that matches to a recording, and all those recordings are in the same release")
      • ... they made release and release-group matches
      • the recording ones are purely acoustid-based
      • Leftmost
        Ahh, okay. Thanks.
      • ianmcorvidae
        though I think they've now imported luks's process, which used durations and track names
      • (the results of his thing, I mean, I don't think they're actually doing it themselves :/)
      • Leftmost
        Matching last.fm library/scrobble data against MB data is going to be difficult.
      • VxJasonxV
        ianmcorvidae, wasn't that yesterday?
      • /irrelevant
      • voiceinsideyou joined the channel
      • installhelp joined the channel
      • installhelp
        anyone avail that can help troubleshoot an install error?
      • CallerNo6 joined the channel
      • Leftmost joined the channel
      • MBJenkins
        Project libdiscid » autotools build #21: FAILURE in 19 sec: http://ci.musicbrainz.org/job/libdiscid/./build...
      • * github: win32: autotools support for versioninfo
      • * github: win32: libdiscid.rc -> versioninfo.rc
      • Project libdiscid » cmake build #21: FAILURE in 23 sec: http://ci.musicbrainz.org/job/libdiscid/./build...
      • * github: win32: libdiscid.rc -> versioninfo.rc
      • JonnyJD_
        good to have Jenkins in the chat, because I did not receive a mail about this (yet)
      • but it also looks like jenkins doesn't start with a clean working copy
      • ianmcorvidae
        ocharles: next time you're around, how does the EMAIL_BUGS feature thing work? It's supposedly sending things to root, which I think supposedly sends them to us, but I certainly haven't been getting any emails :P so
      • JonnyJD_
        In the log it says a mail was sent to my address. The address is correct, but I did not receive it yet (and never received mails from jenkins)
      • ianmcorvidae
        hm
      • I don't know about jenkins emailing :/
      • Prophet5 joined the channel
      • MBJenkins
        Project libdiscid » autotools build #22: FIXED in 14 sec: http://ci.musicbrainz.org/job/libdiscid/./build...
      • * github: autotools: no conditional LT_INIT
      • * github: linux: always leave room for \0 in ISRC buffer
      • * github: autotools: no conditional LT_INIT
      • JonnyJD_
        I think I can't fix that build without ocharles, because it needs a build file reset. ^
      • ianmcorvidae
        I have access to all the servers and jenkins stuff, what exactly do you need?
      • JonnyJD_
        changing from "cmake ." to "rm -r CMakeFiles/ CmakeCache.txt; cmake ."
      • in the build config
      • I kind of was thinking jenkins builds in a fresh environment every time, but this doesn't seem to be the case
      • ianmcorvidae
        ah
      • added, building now
      • MBJenkins
        Project libdiscid » cmake build #23: STILL FAILING in 12 sec: http://ci.musicbrainz.org/job/libdiscid/./build...
      • ianmcorvidae
        heh
      • JonnyJD_
        CMakeCache.txt
      • but you can change it to rm -rf too
      • ianmcorvidae
        that makes more sense, I suppose
      • and yeah, I'll do that
      • MBJenkins
        Project libdiscid » cmake build #24: STILL FAILING in 13 sec: http://ci.musicbrainz.org/job/libdiscid/./build...
      • JonnyJD_
        woot
      • it sure doesn't exist. I renamed it.
      • ianmcorvidae
        that looks like a real failure this time :)
      • looks like it's trying to send emails to 'github' and failing, also, so I'll turn off the "Send separate emails to individuals who broke the build" feature
      • JonnyJD_
        gut the individual in this case is given as "Johannes Dewender <github [at JonnyJD.net]>"
      • the only place where jenkins could take "github" from is the mail address..
      • ianmcorvidae
        yeah, but it's missing the @JonnyJD.net and doesn't seem to have a way to know that
      • it'll send to the configured address for you specifically still
      • JonnyJD_
        why would it be missing the @JonnyJD.net? It's part of the commit and in a standard way.
      • looks like a bug in the plugin to me
      • ianmcorvidae
        probably
      • disabling is still the fix :P
      • ah, it doesn't autocreate an email address at *all* for things, it seems
      • so it's just sending it to nobody :/
      • MBJenkins
        Yippie, build fixed!
      • github: cmake: finish versioninfo rename
      • JonnyJD_
        hm, ocharles put my brainz address in the config explicitely, but that didn't reach me either.
      • ianmcorvidae
        yeah, that bit should still have been sending
      • but I think the broken email may have made the whole email-sending bit fail
      • so we'll see
      • JonnyJD_
        yeah. Anyways. Would be great if that works. I like to know when my build fails and I might not always be in the chat.
      • ianmcorvidae
        yeah, understood :)
      • JonnyJD_
        nobody is probably the user that runs the jenkins build. And mail might not be configured on that machine.
      • Now that is fixed, I should go to bed.
      • nikki
        I guess you just have to break it again so you can check it works :P
      • JonnyJD_
        Well, breaking stuff for jenkins seems to be a daily activity anyways
      • ianmcorvidae
        haha
      • JonnyJD_
        so we don't have to force it ;-)
      • It should be the same issue for mb-server
      • ianmcorvidae
        I don't think mbserver sends emails, though, since all the main devs idle in here nonstop :P
      • Leftmost
        Usually my fault anyhow.
      • adhawkins-away joined the channel
      • ianmcorvidae
        speaking of, I've discovered collection subs are making subscribed entity pages 502!
      • but it's not actually your fault :P
      • Leftmost
        It's sort of my fault, it's just that the query is so slow.
      • Make your collection smaller! :-P
      • ianmcorvidae
        I'm not looking at *mine*, lol
      • mine works fine
      • Leftmost
        Make other people's collections smaller!
      • ianmcorvidae
        or I could add a status column to edit_release so it doesn't have to touch the edit table :P
      • Leftmost
        True.
      • Leftmost joined the channel
      • ruaok
        omfg. reo and nikki both submitted invoices. hours early. minutes apart. O_O
      • nikki
        :P
      • ianmcorvidae
        you'll get mine in two hours, unless I decide I'm not going to get any more work done and ship it out a bit early :P
      • ruaok
        :-)
      • the paypal account almost has enough money too.
      • nikki
        well, reo mentioned it, so I was like "oh yeah!" and thought I'd surprise you :P
      • ruaok
        you did. :)
      • I need to add another $200 to the account.
      • nikki: would you like everything but $200 now, or the whole bit later?
      • like monday or so.
      • nikki
        eh, the whole bit later is fine
      • ruaok
        :-)
      • ok
      • ianmcorvidae
        just delays the order of japanese music a couple days ;)
      • Leftmost
        ruaok, it was mentioned to me that the FreeDB gateway could use adding to nagios. Would it be okay for Ian to give me the necessary access to do that?
      • ruaok
        yes. that sounds like a great project for you to look after.
      • nikki
        ianmcorvidae: given that I use a credit card for that, it doesn't even do that :P