#bookbrainz

/

      • MRiddickW joined the channel
      • akashgp09 joined the channel
      • MRiddickW has quit
      • monkey
        I found the problems with these two issues: bad coding by yours truly :p
      • Thanks for reporting these issues akashgp09 !
      • In PR #606 I changed how we used the submission section and applied that change to the entity editor but not to the merge editor. That's why clicking on submit in the merge editor does nothing.
      • akashgp09
        that's awesome monkey. I would love to see the fix for /delete route once you make a PR for it .
      • I have spend a considerable amount of time debugging it but wasn't able to fix it :p
      • monkey
        And same for the delete route, I see that in the `handleCreateOrEditEntity` method we return a jsonified entity, but not in the delete handler. I probably missed it needed to be changed there too.
      • akashgp09
        > https://github.com/bookbrainz/bookbrainz-site/b... Alternatively If we jsonify savedMainEntity.toJSON() we don't have use entity.get(''bbid') in deleteEntity function instead we can directly access entity.bbid
      • i think i was close :p
      • monkey
        Very much so
      • I pushed both fixes to test.bb.org, everything seems to be back in order !
      • MRiddickW joined the channel
      • akashgp09
        tested it, woking fine now. nice fix monkey 🎉
      • monkey
        Thanks for confirming, I'll do a release
      • MRiddickW has quit
      • CatQuest is pleased to note that we are actually more people here on libera than on oldnet :D
      • akashgp09 has quit
      • MRiddickW joined the channel