#bookbrainz

Hey monkey !

Hi Shubh

Saw your message about debugging with vscode. Any luck with that?

Nah , i ran that launch script given for for debugging in readme but that stupid error related to some import utils keep popping up

btw i realized what was causing the website/container to crash !

BB-635

BB-635: Uncaught ElasticSearch error crashes the website https://tickets.metabrainz.org/browse/BB-635

Ah nice!

What's the culprit ?

i don't know if it cause the production build to go down as well but still i think its important to be fix !

ah culprit was that god damn deleted enitty !

Right, the crash was caused by deleting an already deleted entity. But what is the root cause?

handleDelete got that deleted entity it tries to delete all the relation of that enitty without any try error

Ah I see.

i made a PR where i check its dataId

Thank you!

will it cause production build to go down if same error occurs?

It's abannk holiday here but I should have a bit of time today to look that and the vscode debugging

Yes, it crashes the website too

(But it comes back up automatically)

Ahh thats a relief

But with your PR disallowinh deleting an already deleted entity, that shouldn't happen anymore

And once both fixes are merged I'll deploy a new version of the website

are you able to debug BB in vscode?

Will try today

Haven't used it in a while

console logs sometimes don't make it into console! , have to rebuild the whole thing :'

Hey monkey !

👋

what would the right way to access data from database like details about some entity

I would recommend installing this open-source database tool: DBeaver

It's honestly the best tool I've used to access database data, schema diagrams, etc.

ahh in BB-site

monkey i mean in BB-site using orm ..

Sorry, I don't understand the question

I need to fetch information regarding entities ..

Maybe this: the website uses an ORM (see https://github.com/bookbrainz/bookbrainz-data-js)

Hi

Which is what we use to access the database in the website and API

Hi vishal5251!

Hi Everyone!

Hi vishal5251 !

Uploaded file: https://uploads.kiwiirc.com/files/8424b1123f976...

hey monkey, my postgres is running in docker

Uploaded file: https://uploads.kiwiirc.com/files/2c8c51e7a353a...

vishal5251: That all looks right

You might have to stop and restart bookbrainz-site for the configuration changes to take effect

Uploaded file: https://uploads.kiwiirc.com/files/086312799c3c1...

Ah, well that's a step forward. Connection to database is working

Did you follow these steps to create the database? https://github.com/bookbrainz/bookbrainz-site#d...

while I was setting up, npm install shows error. So I deleted some scripts from package-json just to see that how this project gonna look.

We've made a few changes last week regarding NPM install, so I would recommend to checkout the latest commit from the master repository, and try rebuilding the docker image (`docker-compose build bookbrainz-site`)

If you still run into an issue we can try to figure it out together

Hey monkey ..

Yo

relationshipTypeId

it is unique for all relation, i assume?

I need some context :)

But at a glance, relationshipType refers to one of the possible types of relationships (i.e. "author wrote work", etc;) rather than each relationship (i.e. "J.K. Rowling wrote Harry Potter")

Hmm so i need to get some data about entity so i was looking at code which fetches data using orm so i got this

why relationTypeId hardcoded like this isn't page suppose to show all relation an entity has ?

This code is front-end code, so not related to fetching the data.

This hardcode type gets extracted ffrom other relationships in order to be shown in a separate table, let me make a screenshot for you

Shubh: If you visit this page https://bookbrainz.org/edition/39fc0f2e-206b-4c...

You will see a table of "Works" and below it "Relationships"

Yes so that means..

All of these are relationships. The code you linked to extracts relationships of a certain type (edition contains work) to show them in that Works table

But if you're looking for how to get data from the database you're looking in the wrong spot. I fyou describe what you're trying to resolve I can point you to a more relevant piece of code

wait isn't that code for showing relations in Relationships tab?

P.S: The ORM we use has its own repository here: https://github.com/bookbrainz/bookbrainz-data-js/

No this is the WorkDisplayPage

The other relationships are shown in the EntityLinks component below: https://github.com/bookbrainz/bookbrainz-site/b...

which renders the EntityRelationships component https://github.com/bookbrainz/bookbrainz-site/b...

from where EntityRelationships component get its data i mean relations

So for that we need to look at the server code (rather than the client code)

isn't it that specific line of code that fetches them?

Relationships are loaded using an expressJS middleware called loadEntityRelationships: https://github.com/bookbrainz/bookbrainz-site/b...

N, again you're looking at front-end code which doesn't fetch anything.

You want to be looking at files in src/server, not in src/client

but but that workPage

let start again , how workpage (work/:bbid) load its data?

Here: https://github.com/bookbrainz/bookbrainz-site/b...

There is a preliminary step that loads the entity for routes with a BBID: https://github.com/bookbrainz/bookbrainz-site/b...

And after that you see that middleware.loadEntityRelationships is called

That's where we load relationships from the database

And then all that is sent to the react components in entityRoutes.displayEntity

so that middleware responsible for loading relationships data in req.entity object?

Correct

Right here: https://github.com/bookbrainz/bookbrainz-site/b...

And then more data is loaded about the other entity in the relationship here: https://github.com/bookbrainz/bookbrainz-site/b...

so to get data about relationships of an entity i have to add that middleware , correct?

actually they are loaded in `res.locals.entity` which is what is used

Well, I guess it depends where.

If you explained the issue you're trying to solve it would help

Depending on what you're trying to modify, it's possible that the relationships are already loaded

In which case the solution will be to figure out how to access them

is there way to access to them in client side like without getting that entity object with relations ..

I still don't understand what you're trying to do. Which route are you modifying that doesn't have the entity and its relationships loaded already?

Or which page I should say

I want to access the relationships data of an entity on /create entity page..

So for an entity that is being created (i.e that doesn't exist yet in the database), the relationships data is contained in the Redux state

Including whatever data we fetch when adding a new relationship using the search dropdown

data of an entity *which already exist in database

Uploaded file: https://uploads.kiwiirc.com/files/5725ae4534442...

Shubh: So in the RelationshipEditor component, there is a search box component that is used here: https://github.com/bookbrainz/bookbrainz-site/b...

hey monkey, see there comes an error while installing packages.

vishal5251 it might help if you paste whole error log in pastebin

Shubh: But we don't have access too all the entity's data here

vishal5251: That's odd. You're running on Docker for Windows, is that correct?

yeah

vishal5251: I'll try to dig into the issue. I suspect this is a windows-only issue, which I won't be able to reproduce.

The sort of thing that shouldn't happen with Docker, but…

In the meantime if it help I think your instinctwas correct and you can remove the "postinstall" script in package.json

This guy https://usercontent.irccloud-cdn.com/file/yUboO...

See if that allows you to build the image correctly

As Shubh suggested, more debug logs could come in handy, which you can send as a pastebin for example

after removing that thing, it builds but I'll lost the connection with database

Those two issues seem unrelated

monkey https://github.com/bookbrainz/bookbrainz-site/b... here in client i need to add that relations ..

Please try building again with the script removed, and with the correct configuration you sent earlier